)]}'
{"inc/python":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b85438ef7e4e4231b8dc99c67096a4da8ed58591","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        if ! lib_installed_from_git \"$project_dir\"; then"},{"line_number":502,"context_line":"            die $LINENO \"The following LIBS_FROM_GIT was not installed correctly: $project_dir\""},{"line_number":503,"context_line":"        fi"},{"line_number":504,"context_line":"    fi"},{"line_number":505,"context_line":"}"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# determine if a project as specified by directory is in"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf659307_ea637eb0","line":504,"updated":"2018-04-05 15:59:09.000000000","message":"All current uses of use_library_from_git call setup_develop_lib which calls this, so I think this is safe, but your suggestion sounds reasonable too, so I\u0027ve implemented it in a followup patch: https://review.openstack.org/559113","commit_id":"88b3ff90dcb745ff6f21123acf855632a0e26ec5"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"461321c223d2b5dbc100d9958077330fc029b1db","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    local extras\u003d$2"},{"line_number":496,"context_line":"    _setup_package_with_constraints_edit $project_dir -e $extras"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    # If this project is in LIBS_FROM_GIT, verify it was actually installed"},{"line_number":499,"context_line":"    # correctly.  This helps catch errors caused by constraints mismatches."},{"line_number":500,"context_line":"    if use_library_from_git \"$project_dir\"; then"},{"line_number":501,"context_line":"        if ! lib_installed_from_git \"$project_dir\"; then"},{"line_number":502,"context_line":"            die $LINENO \"The following LIBS_FROM_GIT was not installed correctly: $project_dir\""},{"line_number":503,"context_line":"        fi"},{"line_number":504,"context_line":"    fi"},{"line_number":505,"context_line":"}"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# determine if a project as specified by directory is in"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf659307_3fd82b79","line":504,"range":{"start_line":498,"start_character":0,"end_line":504,"end_character":6},"updated":"2018-04-02 09:02:09.000000000","message":"Why only on setup_develop? IMHO every installation should be checked like this","commit_id":"88b3ff90dcb745ff6f21123acf855632a0e26ec5"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"e2b90904938cd46054d1d939d1978457da70c2de","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    local extras\u003d$2"},{"line_number":496,"context_line":"    _setup_package_with_constraints_edit $project_dir -e $extras"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    # If this project is in LIBS_FROM_GIT, verify it was actually installed"},{"line_number":499,"context_line":"    # correctly.  This helps catch errors caused by constraints mismatches."},{"line_number":500,"context_line":"    if use_library_from_git \"$project_dir\"; then"},{"line_number":501,"context_line":"        if ! lib_installed_from_git \"$project_dir\"; then"},{"line_number":502,"context_line":"            die $LINENO \"The following LIBS_FROM_GIT was not installed correctly: $project_dir\""},{"line_number":503,"context_line":"        fi"},{"line_number":504,"context_line":"    fi"},{"line_number":505,"context_line":"}"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# determine if a project as specified by directory is in"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf659307_6ae343a5","line":504,"range":{"start_line":498,"start_character":0,"end_line":504,"end_character":6},"in_reply_to":"bf659307_3fd82b79","updated":"2018-04-02 11:02:04.000000000","message":"Probably the best place to put it is at the end of `_setup_package_with_constraints_edit`","commit_id":"88b3ff90dcb745ff6f21123acf855632a0e26ec5"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"f8f04db43ae2d4b2ee5a253b3b868977e1571b93","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        if ! lib_installed_from_git \"$project_dir\"; then"},{"line_number":502,"context_line":"            die $LINENO \"The following LIBS_FROM_GIT was not installed correctly: $project_dir\""},{"line_number":503,"context_line":"        fi"},{"line_number":504,"context_line":"    fi"},{"line_number":505,"context_line":"}"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# determine if a project as specified by directory is in"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf659307_a80a0076","line":504,"in_reply_to":"bf659307_ea637eb0","updated":"2018-04-11 07:46:08.000000000","message":"I\u0027m okey with it coming in a next patch but I think it\u0027s more correct to not introduce a potential problem if we identified it already.\n\nI mean, it\u0027s equally easy to put this check in this patch already in `_setup_package_with_constraints_edit` and then it doesn\u0027t creates a potential oversight.","commit_id":"88b3ff90dcb745ff6f21123acf855632a0e26ec5"}],"roles/write-devstack-local-conf/library/devstack_local_conf.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6cdbe008e45a21a3b87f8306586612908c9dc7f4","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                if k \u003d\u003d \u0027LIBS_FROM_GIT\u0027:"},{"line_number":250,"context_line":"                    lfg \u003d True"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if not lfg and self.projects:"},{"line_number":253,"context_line":"            required_projects \u003d []"},{"line_number":254,"context_line":"            for project_name, project_info in self.projects.items():"},{"line_number":255,"context_line":"                if project_info.get(\u0027required\u0027):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_642dbaa6","line":252,"range":{"start_line":252,"start_character":11,"end_line":252,"end_character":18},"updated":"2018-04-02 08:35:55.000000000","message":"+1. i was thinking to check if LIBS_FROM_GIT has some value then, generate the list automatically but then it will remove the ability of install everything from pypi with disabling automatic generation.","commit_id":"88b3ff90dcb745ff6f21123acf855632a0e26ec5"}]}