)]}'
{"roles/setup-devstack-source-dirs/README.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7f298214ab20ce03489f50941758ba6f54be213a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"   The devstack base directory."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" .. zuul:rolevar:: devstack_branch"},{"line_number":14,"context_line":"    :default: None"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    The target branch to be setup (where available)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_532989ee","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":34},"updated":"2018-12-06 10:22:05.000000000","message":"devstack_sources_branch","commit_id":"147388466daef8e6589013d9bae684f9f8b8c57a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"49eb8401377ecc86161da284e6e8583ca5ec93ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"   The devstack base directory."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" .. zuul:rolevar:: devstack_branch"},{"line_number":14,"context_line":"    :default: None"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    The target branch to be setup (where available)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_d3a7d950","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":34},"in_reply_to":"3f79a3b5_532989ee","updated":"2018-12-06 10:26:14.000000000","message":"fixed in https://review.openstack.org/#/c/623180/","commit_id":"147388466daef8e6589013d9bae684f9f8b8c57a"}],"roles/setup-devstack-source-dirs/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"797f772c7d1ec4e681f9ccc9e805f1ef7bc8aae2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      base_branch\u003d{{ devstack_sources_branch }}"},{"line_number":21,"context_line":"      if git branch -a | grep \"$base_branch\" \u003e /dev/null ; then"},{"line_number":22,"context_line":"          git checkout $base_branch"},{"line_number":23,"context_line":"      elif [[ \"$base_branch\" \u003d\u003d stable/* ]]; then"},{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff6b8bd7_8ea9bde0","line":23,"updated":"2018-03-06 01:35:54.000000000","message":"i think this will need an executable: /bin/bash to make sure it\u0027s in bash mode for the [[ ]], etc","commit_id":"6a8fd20af476ea2a215335632110f99002c047c7"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"28ebd32cf1c1eeceb2fcf03e179bc248e717a82b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      base_branch\u003d{{ devstack_sources_branch }}"},{"line_number":21,"context_line":"      if git branch -a | grep \"$base_branch\" \u003e /dev/null ; then"},{"line_number":22,"context_line":"          git checkout $base_branch"},{"line_number":23,"context_line":"      elif [[ \"$base_branch\" \u003d\u003d stable/* ]]; then"},{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff6b8bd7_e58e4f2d","line":23,"in_reply_to":"ff6b8bd7_8ea9bde0","updated":"2018-03-06 11:47:46.000000000","message":"Done","commit_id":"6a8fd20af476ea2a215335632110f99002c047c7"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"1164f7cb798159533e2150bcbc32f7e652d2b535","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  become: yes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Setup refspec for repos into devstack working directory"},{"line_number":16,"context_line":"  shell:"},{"line_number":17,"context_line":"    # Copied almost \"as-is\" from devstack-gate setup-workspace function"},{"line_number":18,"context_line":"    cmd: |"},{"line_number":19,"context_line":"      cd {{ devstack_base_dir }}/{{ item.path | basename }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_ddcf09ae","line":16,"updated":"2018-03-28 12:33:04.000000000","message":"Could this be rewritten with the ansible git module? If yes perhaps it would be good to invest on doing that or at least add a TODO.","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"a7948357b22312cb880c325064fc744d2426f359","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  become: yes"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Setup refspec for repos into devstack working directory"},{"line_number":16,"context_line":"  shell:"},{"line_number":17,"context_line":"    # Copied almost \"as-is\" from devstack-gate setup-workspace function"},{"line_number":18,"context_line":"    cmd: |"},{"line_number":19,"context_line":"      cd {{ devstack_base_dir }}/{{ item.path | basename }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_5bd4de47","line":16,"in_reply_to":"bf659307_ddcf09ae","updated":"2018-04-04 10:08:35.000000000","message":"I think I would settle or a TODO for now. I agree this is not ideal, but I want to get things working first.","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"1164f7cb798159533e2150bcbc32f7e652d2b535","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      base_branch\u003d{{ devstack_sources_branch }}"},{"line_number":21,"context_line":"      if git branch -a | grep \"$base_branch\" \u003e /dev/null ; then"},{"line_number":22,"context_line":"          git checkout $base_branch"},{"line_number":23,"context_line":"      elif [[ \"$base_branch\" \u003d\u003d stable/* ]]; then"},{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_9d6511e4","line":23,"updated":"2018-03-28 12:33:04.000000000","message":"This failed on http://logs.openstack.org/36/548936/23/check/grenade/d3e9c63/job-output.txt.gz#_2018-03-05_12_07_15_293003\n\nI think because the job ran before you added executable: /bin/bash\n\nI\u0027ll issue a recheck just to check, but it\u0027s important not to miss it. It seems to me that because of that failure it didn\u0027t switch the branch correctly and remained in master.","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"71d7837e85e9ac026a9dedceaebc922dbcc19316","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      base_branch\u003d{{ devstack_sources_branch }}"},{"line_number":21,"context_line":"      if git branch -a | grep \"$base_branch\" \u003e /dev/null ; then"},{"line_number":22,"context_line":"          git checkout $base_branch"},{"line_number":23,"context_line":"      elif [[ \"$base_branch\" \u003d\u003d stable/* ]]; then"},{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_abea0c72","line":23,"in_reply_to":"bf659307_9d6511e4","updated":"2018-03-28 15:31:14.000000000","message":"Effectively now the error doesn\u0027t popup again. \n\n\u003e It seems to me that because of that failure it didn\u0027t switch the branch correctly and remained in master.\n\nIgnore this part, I just see that it wasn\u0027t related.","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"1164f7cb798159533e2150bcbc32f7e652d2b535","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      elif [[ \"$base_branch\" \u003d\u003d stable/* ]]; then"},{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"},{"line_number":27,"context_line":"              git_checkout_tag $PROJECT $eol_tag"},{"line_number":28,"context_line":"          fi"},{"line_number":29,"context_line":"      else"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_627c1cb5","line":26,"range":{"start_line":26,"start_character":13,"end_line":26,"end_character":24},"updated":"2018-03-28 12:33:04.000000000","message":"this depends on sourcing devstack-gate/functions.sh\n\nI haven\u0027t checked in detail, but are you sure this works? This portion of code was never executed in the CI runs.","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"a7948357b22312cb880c325064fc744d2426f359","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      elif [[ \"$base_branch\" \u003d\u003d stable/* ]]; then"},{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"},{"line_number":27,"context_line":"              git_checkout_tag $PROJECT $eol_tag"},{"line_number":28,"context_line":"          fi"},{"line_number":29,"context_line":"      else"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_1bf18601","line":26,"range":{"start_line":26,"start_character":13,"end_line":26,"end_character":24},"in_reply_to":"bf659307_627c1cb5","updated":"2018-04-04 10:08:35.000000000","message":"Nice catch, thanks, this would not work","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"1164f7cb798159533e2150bcbc32f7e652d2b535","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"},{"line_number":27,"context_line":"              git_checkout_tag $PROJECT $eol_tag"},{"line_number":28,"context_line":"          fi"},{"line_number":29,"context_line":"      else"},{"line_number":30,"context_line":"          git checkout master"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_9dd8b17f","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":30},"updated":"2018-03-28 12:33:04.000000000","message":"same as L26","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"a7948357b22312cb880c325064fc744d2426f359","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          # Look for an eol tag for the stable branch."},{"line_number":25,"context_line":"          eol_tag\u003d${base_branch#stable/}-eol"},{"line_number":26,"context_line":"          if git_has_tag $PROJECT $eol_tag; then"},{"line_number":27,"context_line":"              git_checkout_tag $PROJECT $eol_tag"},{"line_number":28,"context_line":"          fi"},{"line_number":29,"context_line":"      else"},{"line_number":30,"context_line":"          git checkout master"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_3bf48af0","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":30},"in_reply_to":"bf659307_9dd8b17f","updated":"2018-04-04 10:08:35.000000000","message":"Nice catch, thanks, this would not work","commit_id":"eed78bb1d4d7dd67f1b621d265b316fdbc7ac4e3"}]}