)]}'
{"functions":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"2536d6bfb94e3d72ee855d277ca571fed09ae762","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027.vmdk\u0027 ]]; then"},{"line_number":1318,"context_line":"        IMAGE\u003d\"$FILES/${IMAGE_FNAME}\""},{"line_number":1319,"context_line":"        IMAGE_NAME\u003d\"${IMAGE_FNAME%.vmdk}\""},{"line_number":1320,"context_line":""},{"line_number":1321,"context_line":"        # Before we can upload vmdk type images to glance, we need to know it\u0027s"},{"line_number":1322,"context_line":"        # disk type, storage adapter, and networking adapter. These values are"},{"line_number":1323,"context_line":"        # passed to glance as custom properties. We take these values from the"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F%2FZBM%3D","side":"PARENT","line":1320,"updated":"2013-11-07 12:14:03.000000000","message":"Removing this blank line does not seem to have much to do with the patch.","commit_id":"1c1aef0eb7796f0fe8b2502eb4aaa62369b7842a"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"868d5b5c63f481a353e99d55b5ac1387bb4d0559","unresolved":false,"context_lines":[{"line_number":1342,"context_line":"        elif [[ \"$vmdk_create_type\" \u003d \"monolithicFlat\" ]]; then"},{"line_number":1343,"context_line":"            vmdk_disktype\u003d\"preallocated\""},{"line_number":1344,"context_line":"        else"},{"line_number":1345,"context_line":"            vmdk_disktype\u003d\"$vmdk_create_type\""},{"line_number":1346,"context_line":"        fi"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"        property_string\u003d`echo \"$IMAGE_NAME\" | grep -oP \u0027(?\u003c\u003d-)(?!.*-).+:.+:.+$\u0027`"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F%2FcQo%3D","line":1345,"updated":"2013-11-06 06:01:20.000000000","message":"can you log this to help in debugging as the other disk types (AFAIK) are not understood by the nova driver","commit_id":"21948564a14b91f8918fdfb027d56f5cf2ee531f"},{"author":{"_account_id":8163,"name":"Sreeram Yerrapragada","email":"syerrapragada@vmware.com","username":"syerrapragada"},"change_message_id":"67647258c1bd4c0a6659aa02cc7aa36a2dc2889d","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"        property_string\u003d`echo \"$IMAGE_NAME\" | grep -oP \u0027(?\u003c\u003d-)(?!.*-).+:.+:.+$\u0027`"},{"line_number":1349,"context_line":"        if [[ ! -z \"$property_string\" ]]; then"},{"line_number":1350,"context_line":"            IFS\u003d\u0027:\u0027 read -a props \u003c\u003c\u003c \"$property_string\""},{"line_number":1351,"context_line":"            if [[ -z \"${props[0]}\" ]]; then"},{"line_number":1352,"context_line":"                vmware_disktype\u003d\"${props[0]}\""},{"line_number":1353,"context_line":"            fi"},{"line_number":1354,"context_line":"            if [[ -z \"${props[1]}\" ]]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F%2Fh5I%3D","line":1351,"updated":"2013-11-02 00:42:50.000000000","message":"You missed a \u0027!\u0027 before \"-z\"","commit_id":"21948564a14b91f8918fdfb027d56f5cf2ee531f"},{"author":{"_account_id":8163,"name":"Sreeram Yerrapragada","email":"syerrapragada@vmware.com","username":"syerrapragada"},"change_message_id":"67647258c1bd4c0a6659aa02cc7aa36a2dc2889d","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"            if [[ -z \"${props[0]}\" ]]; then"},{"line_number":1352,"context_line":"                vmware_disktype\u003d\"${props[0]}\""},{"line_number":1353,"context_line":"            fi"},{"line_number":1354,"context_line":"            if [[ -z \"${props[1]}\" ]]; then"},{"line_number":1355,"context_line":"                vmdk_adapter_type\u003d\"${props[1]}\""},{"line_number":1356,"context_line":"            fi"},{"line_number":1357,"context_line":"            vmdk_net_adapter\u003d\"${props[2]}\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F%2Fh5E%3D","line":1354,"updated":"2013-11-02 00:42:50.000000000","message":"You missed a \u0027!\u0027 before \"-z\"","commit_id":"21948564a14b91f8918fdfb027d56f5cf2ee531f"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"a4ebacfe015ec018c845fd13219c88390675be42","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"        # driver will supply default values."},{"line_number":1331,"context_line":""},{"line_number":1332,"context_line":"        # vmdk adapter type"},{"line_number":1333,"context_line":"        vmdk_adapter_type\u003d\"$(grep -a -F -m 1 \u0027ddb.adapterType \u003d\u0027 $IMAGE)\""},{"line_number":1334,"context_line":"        vmdk_adapter_type\u003d\"${vmdk_adapter_type#*\\\"}\""},{"line_number":1335,"context_line":"        vmdk_adapter_type\u003d\"${vmdk_adapter_type%?}\""},{"line_number":1336,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAATn%2F%2FNKM%3D","line":1333,"updated":"2013-11-12 23:04:22.000000000","message":"if this is a 20GB vmfs flat disk, grep will end up scanning a while for nothing (or worse, hit some false positive depending on what\u0027s in the vmdk). I would suggest taking something like \"head -25 $IMAGE\" and pipe it to grep.","commit_id":"08fd2780754b0f5226474ca95665e17d3ea41318"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"a4ebacfe015ec018c845fd13219c88390675be42","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"        if [[ \"$vmdk_create_type\" \u003d \"monolithicSparse\" ]]; then"},{"line_number":1342,"context_line":"            vmdk_disktype\u003d\"sparse\""},{"line_number":1343,"context_line":"        elif [[ \"$vmdk_create_type\" \u003d \"monolithicFlat\" ]]; then"},{"line_number":1344,"context_line":"            vmdk_disktype\u003d\"preallocated\""},{"line_number":1345,"context_line":"        else"},{"line_number":1346,"context_line":"            vmdk_disktype\u003d\"$vmdk_create_type\""},{"line_number":1347,"context_line":"            if [[ ! -z $vmdk_disktype ]]; then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAATn%2F%2FNJA%3D","line":1344,"updated":"2013-11-12 23:04:22.000000000","message":"mono flat disks uses a descriptor-data pair, so this case cannot happen, unless the descriptor file was incorrectly supplied instead.\nWhich brings me to...\none common source of user error is exactly that -- specifying the descriptor file instead of the data file. It would be worthwhile to detect this case and return an error.","commit_id":"08fd2780754b0f5226474ca95665e17d3ea41318"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"a4ebacfe015ec018c845fd13219c88390675be42","unresolved":false,"context_lines":[{"line_number":1343,"context_line":"        elif [[ \"$vmdk_create_type\" \u003d \"monolithicFlat\" ]]; then"},{"line_number":1344,"context_line":"            vmdk_disktype\u003d\"preallocated\""},{"line_number":1345,"context_line":"        else"},{"line_number":1346,"context_line":"            vmdk_disktype\u003d\"$vmdk_create_type\""},{"line_number":1347,"context_line":"            if [[ ! -z $vmdk_disktype ]]; then"},{"line_number":1348,"context_line":"                echo $LINENO $vmdk_disktype \" won\u0027t be understood by the Nova VMware driver.\""},{"line_number":1349,"context_line":"            fi"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAATn%2F%2FNHk%3D","line":1346,"updated":"2013-11-12 23:04:22.000000000","message":"What is set here will most likely be incorrect. If no createType is found, assume flat, so use disk type of preallocated. If createType is found, either it is a user error (descriptor supplied) or a legit disk (only two cases: monolithicSparse or streamOptimized)). We should set the former. Once the latter is supported in nova/cinder we can add that.","commit_id":"08fd2780754b0f5226474ca95665e17d3ea41318"}]}