)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"dc497e1d99c259aa80459d68566f7f5d0562a50f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     65ad7940 (Configure console proxy settings for nova-cpu.conf)"},{"line_number":2,"context_line":"Author:     shilpa.devharakar \u003cshilpa.devharakar@nttdata.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2018-05-11 16:12:17 +0530"},{"line_number":4,"context_line":"Commit:     shilpa.devharakar \u003cshilpa.devharakar@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-11 16:12:17 +0530"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_efddca13","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":61},"updated":"2018-06-28 11:07:36.000000000","message":"Please don\u0027t do this, retain the original author when you amend the commit in future.","commit_id":"6a3abc9d369e4c196f1b2e12e76b2b51afa8cfb0"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"1bd157c04d225b0488174d62714aabcc09d34b48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     65ad7940 (Configure console proxy settings for nova-cpu.conf)"},{"line_number":2,"context_line":"Author:     shilpa.devharakar \u003cshilpa.devharakar@nttdata.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2018-05-11 16:12:17 +0530"},{"line_number":4,"context_line":"Commit:     shilpa.devharakar \u003cshilpa.devharakar@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-11 16:12:17 +0530"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_42905550","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":61},"in_reply_to":"5f7c97a3_efddca13","updated":"2018-06-28 11:51:54.000000000","message":"Sorry that my miss, will surly take care n future.","commit_id":"6a3abc9d369e4c196f1b2e12e76b2b51afa8cfb0"}],"lib/nova":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6d41422c6465e789b003b1f214a18add9afd09d7","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":613,"context_line":"        NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_lite.html\"}"},{"line_number":614,"context_line":"        iniset $NOVA_CPU_CONF vnc novncproxy_base_url \"$NOVNCPROXY_URL\""},{"line_number":615,"context_line":"        XVPVNCPROXY_URL\u003d${XVPVNCPROXY_URL:-\"http://$SERVICE_HOST:6081/console\"}"},{"line_number":616,"context_line":"        iniset $NOVA_CPU_CONF vnc xvpvncproxy_base_url \"$XVPVNCPROXY_URL\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f7c97a3_ac7040a6","line":613,"range":{"start_line":613,"start_character":0,"end_line":613,"end_character":83},"updated":"2018-06-28 09:55:01.000000000","message":"So this is conditional on devstack building from src at the moment, packages should be providing a symlink to vnc_auto.html to retain backward compatibility.","commit_id":"6a3abc9d369e4c196f1b2e12e76b2b51afa8cfb0"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6659964ad1f79941cf04dee0d1c75c35ba422ecc","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":613,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":614,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":615,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":616,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_8e83c155","line":613,"updated":"2018-07-02 01:33:31.000000000","message":"we have a vercmp function, couldn\u0027t we do something like\n\n if vercmp ${NOVNC_BRANCH} \"\u003c\" \"1.0.0\"; then\n   use old url\n else\n   use new url\n fi\n\nthen it would consistently?","commit_id":"5c9995583ba79ab10f3a189dff4efa4db2fcb80b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"079b257dce1d9389fb89bce878180d11a4d34751","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":613,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":614,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":615,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":616,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_c28fd873","line":613,"in_reply_to":"5f7c97a3_8e83c155","updated":"2018-07-31 13:45:45.000000000","message":"\u003e we have a vercmp function, couldn\u0027t we do something like\n \u003e \n \u003e if vercmp ${NOVNC_BRANCH} \"\u003c\" \"1.0.0\"; then\n \u003e use old url\n \u003e else\n \u003e use new url\n \u003e fi\n \u003e \n \u003e then it would consistently?\n\nACK thanks, I\u0027ve used that when building from src.","commit_id":"5c9995583ba79ab10f3a189dff4efa4db2fcb80b"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"6d859a94b9e8babbd968b496c0ba7e2c884cf766","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":613,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":614,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":615,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":616,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_c8e0c49a","line":613,"in_reply_to":"5f7c97a3_8e83c155","updated":"2018-07-02 13:49:50.000000000","message":"@Lee Yarwood: if in future, if we updated novnc packages to v1.0.0, then this will won\u0027t work (since novnc renamed vnc_auto.html to vnc_lite.html ), code changes will again require.\n\n@Ian Wienand: here if $NOVNC_FROM_PACKAGE is \u0027False\u0027 then only devstack downloads novnc updated package from git url configured else IT will referred from novnc packages.\nHere in this patch, we are Bump noVNC to 1.0.0 \n\nIMO we should not have if clause here, instead we should make $NOVNC_FROM_PACKAGE as \u0027False\u0027 at [1] and provide required novnc URL mentioned  ${NOVNC_BRANCH}\n\n[1]: https://github.com/openstack-dev/devstack/blob/master/.zuul.yaml#L125","commit_id":"5c9995583ba79ab10f3a189dff4efa4db2fcb80b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"079b257dce1d9389fb89bce878180d11a4d34751","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"},{"line_number":613,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":614,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":615,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":616,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_423748b0","line":613,"in_reply_to":"5f7c97a3_c8e0c49a","updated":"2018-07-31 13:45:45.000000000","message":"\u003e @Lee Yarwood: if in future, if we updated novnc packages to v1.0.0,\n \u003e then this will won\u0027t work (since novnc renamed vnc_auto.html to\n \u003e vnc_lite.html ), code changes will again require.\n\nThat isn\u0027t going to be true for the el packages I\u0027m working to rebase where I plan on providing a symlink between the older vnc_auto.html and newer vnc_lite.html pages. TBH I think we should assume that packagers will provide this.\n\n \u003e @Ian Wienand: here if $NOVNC_FROM_PACKAGE is \u0027False\u0027 then only\n \u003e devstack downloads novnc updated package from git url configured\n \u003e else IT will referred from novnc packages.\n \u003e Here in this patch, we are Bump noVNC to 1.0.0\n \u003e \n \u003e IMO we should not have if clause here, instead we should make\n \u003e $NOVNC_FROM_PACKAGE as \u0027False\u0027 at [1] and provide required novnc\n \u003e URL mentioned  ${NOVNC_BRANCH}\n \u003e \n \u003e [1]: https://github.com/openstack-dev/devstack/blob/master/.zuul.yaml#L125\n\nUnless we remove NOVNC_FROM_PACKAGE then we need to support both approaches here.","commit_id":"5c9995583ba79ab10f3a189dff4efa4db2fcb80b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2c27ce548da64cc32018567357f6b2002401deae","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":616,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":617,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":618,"context_line":"        elif [ vercmp ${NOVNC_BRANCH} \"\u003c\" \"1.0.0\" ]; then"},{"line_number":619,"context_line":"             # Use the old URL when installing older novnc source."},{"line_number":620,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":621,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f79a3b5_bd045f19","line":618,"updated":"2018-08-13 05:27:00.000000000","message":"I don\u0027t think this actually works in the \"[\" ... it\u0027s supposed to just be\n\n elif vercmp ${NOVNC_BRANCH} \"\u003c\" \"1.0.0\" ; then\n  ...\n fi\n\nas it\u0027s the return value of the function we want to check","commit_id":"c1334a0102aa14d7e7a6854e4835b15f34d9d08a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f661ca602b3fdbdb3a1e7905090bd65f4b46416b","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":616,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":617,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":618,"context_line":"        elif [ vercmp ${NOVNC_BRANCH} \"\u003c\" \"1.0.0\" ]; then"},{"line_number":619,"context_line":"             # Use the old URL when installing older novnc source."},{"line_number":620,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:6080/vnc_auto.html\"}"},{"line_number":621,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f79a3b5_8ab0a642","line":618,"in_reply_to":"3f79a3b5_bd045f19","updated":"2018-10-08 13:11:10.000000000","message":"Oh, good point. Fixed.","commit_id":"c1334a0102aa14d7e7a6854e4835b15f34d9d08a"}]}