)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"3c2c4bf68947c67c232aad6264d0531cbd61453e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip curl pip package, if exists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It can save several seconds for doggy network."},{"line_number":10,"context_line":"If the existing pip package is not in the good state,"},{"line_number":11,"context_line":"the later tar operation will fail. Thus no need to worry"},{"line_number":12,"context_line":"for using a wrong pip package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BDqY%3D","line":9,"updated":"2014-01-30 15:58:21.000000000","message":"I think you meant \"dodgy\" here. :-)","commit_id":"7c4d97857fb7edfeecc97a44be30fe713b136ee3"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"ae12e72b10318fbed0170c41f12dae7d51bedaf9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip curl pip package, if exists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It can save several seconds for doggy network."},{"line_number":10,"context_line":"If the existing pip package is not in the good state,"},{"line_number":11,"context_line":"the later tar operation will fail. Thus no need to worry"},{"line_number":12,"context_line":"for using a wrong pip package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2BDQA%3D","line":9,"in_reply_to":"AAAAUH%2F%2BDqY%3D","updated":"2014-01-30 16:57:50.000000000","message":"I like doggy network version too ;)","commit_id":"7c4d97857fb7edfeecc97a44be30fe713b136ee3"}],"tools/install_pip.sh":[{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"35f4d419638784a434094d47703df7dba9f82c1a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    (cd $FILES; \\"},{"line_number":74,"context_line":"        if [[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]];"},{"line_number":75,"context_line":"        then"},{"line_number":76,"context_line":"            echo \"pip file already exists: exists: pip-$INSTALL_PIP_VERSION.tar.gz\""},{"line_number":77,"context_line":"        else"},{"line_number":78,"context_line":"            curl -O $PIP_TAR_URL"},{"line_number":79,"context_line":"        fi; \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAUH%2F%2BQo0%3D","line":76,"updated":"2014-01-28 15:59:17.000000000","message":"exists: is written twice","commit_id":"d3c547cd19eb0358b309c4e1cd1a4d8fc28ccce3"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"512cc09b502fc2b895d63e6a199ab4ac7a4b36cb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"function install_pip_tarball() {"},{"line_number":73,"context_line":"    (cd $FILES; \\"},{"line_number":74,"context_line":"        if [[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]];"},{"line_number":75,"context_line":"        then"},{"line_number":76,"context_line":"            echo \"pip file already exists: pip-$INSTALL_PIP_VERSION.tar.gz\""},{"line_number":77,"context_line":"        else"},{"line_number":78,"context_line":"            curl -O $PIP_TAR_URL"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAUH%2F%2BO3s%3D","line":75,"updated":"2014-01-28 20:56:58.000000000","message":"if you see the other if then the then is after a ; with a space on the same line.","commit_id":"7c4d97857fb7edfeecc97a44be30fe713b136ee3"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"512cc09b502fc2b895d63e6a199ab4ac7a4b36cb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if [[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]];"},{"line_number":75,"context_line":"        then"},{"line_number":76,"context_line":"            echo \"pip file already exists: pip-$INSTALL_PIP_VERSION.tar.gz\""},{"line_number":77,"context_line":"        else"},{"line_number":78,"context_line":"            curl -O $PIP_TAR_URL"},{"line_number":79,"context_line":"        fi; \\"},{"line_number":80,"context_line":"        tar xvfz pip-$INSTALL_PIP_VERSION.tar.gz 1\u003e/dev/null; \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAUH%2F%2BO3U%3D","line":77,"updated":"2014-01-28 20:56:58.000000000","message":"do we really need to echo it ? what about just something like that (please verify the syntax/variable is proper this is just an example)  :\n\n[[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]] || curl $PIP_TAR_URL","commit_id":"7c4d97857fb7edfeecc97a44be30fe713b136ee3"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"f058381c56c477b8b9e041a6fca0c96e011d4e85","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"function install_pip_tarball() {"},{"line_number":73,"context_line":"    (cd $FILES; \\"},{"line_number":74,"context_line":"        ([[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]] || curl -O $PIP_TAR_URL); \\"},{"line_number":75,"context_line":"        tar xvfz pip-$INSTALL_PIP_VERSION.tar.gz 1\u003e/dev/null; \\"},{"line_number":76,"context_line":"        cd pip-$INSTALL_PIP_VERSION; \\"},{"line_number":77,"context_line":"        sudo python setup.py install 1\u003e/dev/null; \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAUH%2F96ng%3D","line":74,"updated":"2014-02-01 08:12:09.000000000","message":"why would you need parenthesis here?\n\nthat should just work :\n\n        [[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]] || curl -O $PIP_TAR_URL; \\\n\nright?","commit_id":"7fb73c749331f718ee4862e5647830ff020438e0"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"34a5222000c141937fb039574be2037c07baaf31","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"function install_pip_tarball() {"},{"line_number":73,"context_line":"    (cd $FILES; \\"},{"line_number":74,"context_line":"        ([[ -f \"pip-$INSTALL_PIP_VERSION.tar.gz\" ]] || curl -O $PIP_TAR_URL); \\"},{"line_number":75,"context_line":"        tar xvfz pip-$INSTALL_PIP_VERSION.tar.gz 1\u003e/dev/null; \\"},{"line_number":76,"context_line":"        cd pip-$INSTALL_PIP_VERSION; \\"},{"line_number":77,"context_line":"        sudo python setup.py install 1\u003e/dev/null; \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAUH%2F94f8%3D","line":74,"in_reply_to":"AAAAUH%2F96ng%3D","updated":"2014-02-02 14:54:48.000000000","message":"Chmouel, without parenthesis, it also works.\n\nBut I prefer the current one, since it makes the logic more apparent.","commit_id":"7fb73c749331f718ee4862e5647830ff020438e0"}]}
