)]}'
{"lib/savanna":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1f30c0c7fe23272086c3a87ad1282935ade97431","unresolved":false,"context_lines":[{"line_number":37,"context_line":"SAVANNA_SERVICE_PORT\u003d${SAVANNA_SERVICE_PORT:-8386}"},{"line_number":38,"context_line":"SAVANNA_TEMPLATES_DIR\u003d${SAVANNA_TEMPLATES_DIR:-$TOP_DIR/files/savanna-templates}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"AUTO_ASSIGNMENT\u003dFalse"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# Support entry points installation of console scripts"},{"line_number":43,"context_line":"if [[ -d $SAVANNA_DIR/bin ]]; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FVbg%3D","line":40,"updated":"2013-11-09 19:42:14.000000000","message":"This should be a more descriptive name, auto assignment of what?","commit_id":"c9159223cf6a1e14395a74b3b3a42a72140dabf7"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1f30c0c7fe23272086c3a87ad1282935ade97431","unresolved":false,"context_lines":[{"line_number":91,"context_line":"}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"check_auto_assignment() {"},{"line_number":94,"context_line":"    for I in \"${EXTRA_OPTS[@]}\"; do"},{"line_number":95,"context_line":"        str\u003d$(echo ${I/\u003d/ } | grep \"auto_assign_floating_ip\")"},{"line_number":96,"context_line":"        if [[ \"$str\" !\u003d null ]]"},{"line_number":97,"context_line":"        then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FVbk%3D","line":94,"updated":"2013-11-09 19:42:14.000000000","message":"using EXTRA_OPTS here is a bad idea, with the new local.conf setup the auto_assign_floating_ip config shold now be set that way and will not appear in EXTRA_OPTS; actually, EXTRA_OPTS should be blank after that changes.\n\nmaybe use iniget() to retrieve the setting from nova.conf? That config should be done before this executes.  oh, wait, it isn\u0027t.  It should be that way, I\u0027ll propose a patch...","commit_id":"c9159223cf6a1e14395a74b3b3a42a72140dabf7"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1f30c0c7fe23272086c3a87ad1282935ade97431","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        sed -i \"/__floating_ip__/d\" $worker_template $master_template"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"    ID_MASTER_TEMPLATE\u003d$(curl -d @$master_template -H \"Content-Type: application/json\" -H \"X-Auth-Token: $TOKEN\" http://$SAVANNA_SERVICE_HOST:$SAVANNA_SERVICE_PORT/v1.1/$TENANT/node-group-templates | sed -e \u0027s/,/,\\n/g\u0027 | grep -w id | sed -e \u0027s/id//g;s/[^0-9A-Za-z\\-]//g\u0027)"},{"line_number":125,"context_line":"    ID_WORKER_TEMPLATE\u003d$(curl -d @$worker_template -H \"Content-Type: application/json\" -H \"X-Auth-Token: $TOKEN\" http://$SAVANNA_SERVICE_HOST:$SAVANNA_SERVICE_PORT/v1.1/$TENANT/node-group-templates | sed -e \u0027s/,/,\\n/g\u0027 | grep -w id | sed -e \u0027s/id//g;s/[^0-9A-Za-z\\-]//g\u0027)"},{"line_number":126,"context_line":"    sed -i \"s/__mastertemplate_id__/$ID_MASTER_TEMPLATE/g;s/__workertemplate_id__/$ID_WORKER_TEMPLATE/g\" $cluster_template"},{"line_number":127,"context_line":"    curl -d @$cluster_template -H \"Content-Type: application/json\" -H \"X-Auth-Token: $TOKEN\" http://$SAVANNA_SERVICE_HOST:$SAVANNA_SERVICE_PORT/v1.1/$TENANT/cluster-templates"},{"line_number":128,"context_line":"    rm $cluster_template $worker_template $master_template"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FVcY%3D","line":125,"updated":"2013-11-09 19:42:14.000000000","message":"You may need to add --noproxy to the curl commands so they behave properly with http_proxy defined.\n\nYou might also want to grep using \u0027 id \u0027 (add the spaces before and after) to ensure you don\u0027t get false matches.","commit_id":"c9159223cf6a1e14395a74b3b3a42a72140dabf7"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1f30c0c7fe23272086c3a87ad1282935ade97431","unresolved":false,"context_lines":[{"line_number":138,"context_line":"function start_savanna() {"},{"line_number":139,"context_line":"    screen_it savanna \"cd $SAVANNA_DIR \u0026\u0026 $SAVANNA_BIN_DIR/savanna-api --config-file $SAVANNA_CONF_DIR/$SAVANNA_CONF_FILE\""},{"line_number":140,"context_line":"    echo \"Waiting for savanna-api ($SAVANNA_SERVICE_PORT) to start...\""},{"line_number":141,"context_line":"    if ! timeout $SERVICE_TIMEOUT sh -c \"while ! curl http://$SAVANNA_SERVICE_HOST:$SAVANNA_SERVICE_PORT/ 2\u003e/dev/null | grep -q \u0027Auth\u0027; do sleep 1; done\"; then"},{"line_number":142,"context_line":"        die $LINENO \"savanna-api did not start\""},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F%2FVcE%3D","line":141,"updated":"2013-11-09 19:42:14.000000000","message":"use the wait_for_service() function here.  see lib/nova\u0027s start_nova_api() for an example.","commit_id":"c9159223cf6a1e14395a74b3b3a42a72140dabf7"}],"lib/savanna-dashboard":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"19150114f2c91dae89c76032c5db2b350d5bf7c5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"function configure_savanna_dashboard() {"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    local_settings\u003d$HORIZON_DIR/openstack_dashboard/local/local_settings.py"},{"line_number":42,"context_line":"    echo -e \"SAVANNA_URL \u003d \\\"http://$SAVANNA_SERVICE_HOST:$SAVANNA_SERVICE_PORT/v1.1\\\"\" \u003e\u003e $local_settings"},{"line_number":43,"context_line":"    echo -e \"HORIZON_CONFIG[\u0027dashboards\u0027] +\u003d (\u0027savanna\u0027,)\\nINSTALLED_APPS +\u003d (\u0027savannadashboard\u0027,)\" \u003e\u003e $HORIZON_DIR/openstack_dashboard/settings.py"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    for I in \"${EXTRA_OPTS[@]}\"; do"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAATn%2F%2FY1U%3D","line":42,"updated":"2013-11-07 14:40:05.000000000","message":"If Savanna is registered in Keystone, then there is no need to add SAVANNA_URL to local_settings","commit_id":"502c0abc14272185f972036341348f82a41a940d"}]}
