)]}'
{"id":"openstack%2Fdevstack~55421","triplet_id":"openstack%2Fdevstack~master~I673762e802c28335e03390b6608cf6bbee6aaba6","project":"openstack/devstack","branch":"master","topic":"missing_space","hashtags":[],"change_id":"I673762e802c28335e03390b6608cf6bbee6aaba6","subject":"Fixing space issues between \" and ]","status":"MERGED","created":"2013-11-06 14:44:38.000000000","updated":"2013-11-22 09:58:46.000000000","submitted":"2013-11-22 09:58:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aa953ef34b076c0baf944a3679122d4cd387ed91","_number":55421,"virtual_id_number":55421,"owner":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-11-22 09:58:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-11-07 11:33:03.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":2,"date":"2013-11-19 16:06:14.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2013-11-19 12:17:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":2,"date":"2013-11-07 01:22:27.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":1,"date":"2013-11-19 16:06:14.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"date":"2013-11-07 01:22:27.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-07 01:22:27.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-11-07 11:33:03.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2013-11-19 16:06:14.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-11-22 09:58:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4874cdb4a466a1f49f5d7b38886c45ec87fc26ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-06 15:19:42.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/21/55421/1/check/gate-devstack-bash8/7892c4f : SUCCESS in 5s\n- check-tempest-devstack-vm-full http://logs.openstack.org/21/55421/1/check/check-tempest-devstack-vm-full/f5667c9 : SUCCESS in 34m 56s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/21/55421/1/check/check-tempest-devstack-vm-postgres-full/25f4a1b : SUCCESS in 30m 44s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/21/55421/1/check/check-tempest-devstack-vm-neutron/35864b8 : SUCCESS in 25m 46s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/21/55421/1/check/gate-tempest-devstack-vm-large-ops/14c6ff9 : SUCCESS in 17m 12s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/21/55421/1/check/gate-tempest-devstack-vm-neutron-large-ops/1aab1f2 : FAILURE in 20m 33s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/21/55421/1/check/check-grenade-devstack-vm/bf1a01a : SUCCESS in 31m 58s\n- check-swift-devstack-vm-functional http://logs.openstack.org/21/55421/1/check/check-swift-devstack-vm-functional/e63ec4f : SUCCESS in 10m 24s\n","accounts_in_message":[],"_revision_number":1},{"id":"20a0a7fa82c458c4ed597d2046279490e123a556","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-11-07 01:22:27.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"4be730f32b599ae53741454cda77010b89c76e01","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2013-11-07 11:33:03.000000000","message":"Patch Set 1: (1 inline comment)\n\nThanks for working on this. Maybe you have a clever regexp to find such issues that we could add to bash8 ?","accounts_in_message":[],"_revision_number":1},{"id":"0fd239d6a677b5561aacf7a1eaf8b2fe9371ceea","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-11-19 12:17:28.000000000","message":"Patch Set 1:\n\nWithout a good tokenizer and grammar analysis a \u0027simple grep\u0027 could lead to false positives.\n\nNew we would need to look for \u0027[\u0027 commands which last argument is not \u0027]\u0027. \nOf course the comments and multi-line stings needs to be handled correctly.\n\nForbidding the \u0027\"]\u0027 sting anywhere in the analyzed text wouldn\u0027t be difficult, but it can lead to false positives.","accounts_in_message":[],"_revision_number":1},{"id":"e13b9100d36772500687cfddfb53043e41c54eb5","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2013-11-19 13:45:08.000000000","message":"Patch Set 1:\n\nSure, this may be a bit harder than a simple grep. The comment in \u0027functions\u0027 still holds, though: I think this has already been fixed.","accounts_in_message":[],"_revision_number":1},{"id":"1c5908b16763ddb5064bc7f9aad7f880a5beb522","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-11-19 16:06:14.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nfunctions was fixed, build_ramdisk.sh was not.  Who still uses that anyway?","accounts_in_message":[],"_revision_number":1},{"id":"871f7dc42df76f2f0c734f7cb3ff51c9e17c6e72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-19 16:06:15.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"26469ebc870e9fd94b19160652eb418e20be9eed","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-11-22 07:03:37.000000000","message":"Patch Set 1:\n\nreverify no bug","accounts_in_message":[],"_revision_number":1},{"id":"8ab1a6600418227a273a68accbf9026d67beae30","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 07:03:38.000000000","message":"Patch Set 1:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5ab17bfea435b8b1b80a9e81c5443c98402bff5e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 09:58:46.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"6c074ace182e13be04d6fa445068f05c7793447e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-22 09:58:46.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/21/55421/1/gate/gate-devstack-bash8/f1274d8 : SUCCESS in 4s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/21/55421/1/gate/gate-tempest-devstack-vm-full/837f6e7 : SUCCESS in 35m 15s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/21/55421/1/gate/gate-tempest-devstack-vm-postgres-full/696a550 : SUCCESS in 35m 38s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/21/55421/1/gate/gate-tempest-devstack-vm-neutron/bbd710b : SUCCESS in 31m 38s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/21/55421/1/gate/gate-tempest-devstack-vm-large-ops/6477dea : SUCCESS in 14m 13s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/21/55421/1/gate/gate-tempest-devstack-vm-neutron-large-ops/76b46be : SUCCESS in 17m 02s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/21/55421/1/gate/gate-grenade-devstack-vm/df1d09e : SUCCESS in 23m 59s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/21/55421/1/gate/gate-swift-devstack-vm-functional/8e03333 : SUCCESS in 15m 54s\n","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"237225dd394d43e17c5406c8c0549e3e7d5e4cd2","revisions":{"237225dd394d43e17c5406c8c0549e3e7d5e4cd2":{"kind":"REWORK","_number":1,"created":"2013-11-06 14:44:38.000000000","uploader":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"ref":"refs/changes/21/55421/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/21/55421/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/55421/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/55421/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/21/55421/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/21/55421/1"}}},"commit":{"parents":[{"commit":"aa50a131350a4e047a3a2c22f3bfb5563f6f4ba1","subject":"Merge \"Clean up use of global conf vars in start_nova\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/aa50a131350a4e047a3a2c22f3bfb5563f6f4ba1"}]}],"author":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-11-06 14:41:04.000000000","tz":60},"committer":{"name":"Attila Fazekas","email":"afazekas@redhat.com","date":"2013-11-06 14:41:04.000000000","tz":60},"subject":"Fixing space issues between \" and ]","message":"Fixing space issues between \" and ]\n\nWhen we are using \u0027[\u0027 aka. ``test`` , before the closing \u0027]\u0027\nwe need to use a space.\n\nOtherwise the commands return with \u00272\u0027 so the \"expression\" will be a constant\nfalse.\n\nChange-Id: I673762e802c28335e03390b6608cf6bbee6aaba6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/237225dd394d43e17c5406c8c0549e3e7d5e4cd2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/237225dd394d43e17c5406c8c0549e3e7d5e4cd2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}