)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32f9f7b2fb718968f196c201745da41b567830ef","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            iniset $NOVA_CONF filter_scheduler track_instance_changes False"},{"line_number":463,"context_line":"        fi"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        iniset $NOVA_CONF database connection `database_connection_url $db`"},{"line_number":466,"context_line":"        iniset $NOVA_CONF api_database connection `database_connection_url nova_api`"},{"line_number":467,"context_line":"    fi"},{"line_number":468,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf659307_55825b51","side":"PARENT","line":465,"updated":"2018-03-23 22:51:51.000000000","message":"This results in failing nova-manage db sync:\n\nhttp://logs.openstack.org/46/555346/1/check/tempest-full/70980f3/controller/logs/devstacklog.txt.gz#_2018-03-22_16_23_31_633\n\nBut that should be handled via the API DB connection to get the cell0 mapping DB context from the API DB and then sync it, so need to investigate what in devstack is blindly relying on this and fix that.","commit_id":"8288bccc3cabc0ef255cd0c432d3ae7775dd433b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"776b9cbff403bb1232042ef00e888713e4ef645b","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        # at cell0 instead of cell1 to ensure isolation. If not, we point everything"},{"line_number":455,"context_line":"        # at the main database like normal."},{"line_number":456,"context_line":"        if [[ \"$CELLSV2_SETUP\" \u003d\u003d \"singleconductor\" ]]; then"},{"line_number":457,"context_line":"            local db\u003d\"nova_cell1\""},{"line_number":458,"context_line":"            iniset $NOVA_CONF database connection `database_connection_url $db`"},{"line_number":459,"context_line":"        else"},{"line_number":460,"context_line":"            local db\u003d\"nova_cell0\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df7087c5_1ec24935","line":457,"range":{"start_line":457,"start_character":12,"end_line":457,"end_character":33},"updated":"2018-03-22 16:12:16.000000000","message":"Can probably remove this now.","commit_id":"08b0b488b4cf7b211abeb88435e894e0cc69e7f9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"776b9cbff403bb1232042ef00e888713e4ef645b","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            local db\u003d\"nova_cell1\""},{"line_number":458,"context_line":"            iniset $NOVA_CONF database connection `database_connection_url $db`"},{"line_number":459,"context_line":"        else"},{"line_number":460,"context_line":"            local db\u003d\"nova_cell0\""},{"line_number":461,"context_line":"            # When in superconductor mode, nova-compute can\u0027t send instance"},{"line_number":462,"context_line":"            # info updates to the scheduler, so just disable it."},{"line_number":463,"context_line":"            iniset $NOVA_CONF filter_scheduler track_instance_changes False"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"df7087c5_deddb114","line":460,"updated":"2018-03-22 16:12:16.000000000","message":"And this.","commit_id":"08b0b488b4cf7b211abeb88435e894e0cc69e7f9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32f9f7b2fb718968f196c201745da41b567830ef","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        # (Re)create nova databases"},{"line_number":735,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":736,"context_line":"            recreate_database nova_cell${i}"},{"line_number":737,"context_line":"            $NOVA_BIN_DIR/nova-manage --config-file $(conductor_conf $i) db sync"},{"line_number":738,"context_line":"        done"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Migrate nova and nova_cell0 databases."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf659307_95d6b34f","line":737,"range":{"start_line":737,"start_character":12,"end_line":737,"end_character":80},"updated":"2018-03-23 22:51:51.000000000","message":"We should pass --local_cell here otherwise it tries to access the API DB which the nova_cell1.conf isn\u0027t configured to hit on purpose:\n\nhttp://logs.openstack.org/46/555346/1/check/tempest-full/70980f3/controller/logs/devstacklog.txt.gz#_2018-03-22_16_22_42_105","commit_id":"08b0b488b4cf7b211abeb88435e894e0cc69e7f9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32f9f7b2fb718968f196c201745da41b567830ef","unresolved":false,"context_lines":[{"line_number":738,"context_line":"        done"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        # Migrate nova and nova_cell0 databases."},{"line_number":741,"context_line":"        $NOVA_BIN_DIR/nova-manage --config-file $NOVA_CONF db sync"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"        if is_service_enabled n-cell; then"},{"line_number":744,"context_line":"            recreate_database $NOVA_CELLS_DB"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf659307_55f7bbf6","line":741,"updated":"2018-03-23 22:51:51.000000000","message":"OK this is what blows up:\n\nhttp://logs.openstack.org/46/555346/1/check/tempest-full/70980f3/controller/logs/devstacklog.txt.gz#_2018-03-22_16_23_06_924\n\nIt actually does run the schema migration for cell0, but blows up trying to sync the [database]/connection because we removed it. So in superconductor mode we don\u0027t actually want to blindly do this on nova.conf.\n\nI see two options:\n\n1. Create a nova_cell0.conf and run this against that in superconductor mode which would have the API DB and cell0 DB configuration set (although that would sync cell0 twice and be redundant - we could run it with --local_cell though).\n\n2. Temporarily set cell0 in the NOVA_CONF [database]/connection for this sync and then remove it once the sync is done, which would mimic what we do today.","commit_id":"08b0b488b4cf7b211abeb88435e894e0cc69e7f9"}]}