)]}'
{"id":"openstack%2Fdevstack~55685","triplet_id":"openstack%2Fdevstack~master~I9ae722a5470a16555bca9018da342485f6d3e896","project":"openstack/devstack","branch":"master","topic":"bug/1248923","hashtags":[],"change_id":"I9ae722a5470a16555bca9018da342485f6d3e896","subject":"Fix FROM_PACKAGE checks for novnc and spice","status":"MERGED","created":"2013-11-08 17:27:12.000000000","updated":"2013-11-11 22:46:44.000000000","submitted":"2013-11-11 22:46:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b5ee64f82631570116c91601c0c78c8c048f516a","_number":55685,"virtual_id_number":55685,"owner":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-11-11 22:46:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},{"value":0,"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-11-08 23:03:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":1,"date":"2013-11-10 05:49:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":2,"date":"2013-11-09 18:34:19.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2013-11-08 18:43:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},{"value":1,"date":"2013-11-08 20:04:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},{"value":1,"date":"2013-11-10 17:58:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":1,"date":"2013-11-10 18:14:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":1,"date":"2013-11-11 22:12:05.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},{"value":0,"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},{"value":0,"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},{"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-11-08 18:43:10.000000000","updated_by":{"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},"reviewer":{"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},"state":"REVIEWER"},{"updated":"2013-11-08 20:04:46.000000000","updated_by":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"reviewer":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"state":"REVIEWER"},{"updated":"2013-11-08 23:03:47.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2013-11-10 05:49:48.000000000","updated_by":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"reviewer":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"state":"REVIEWER"},{"updated":"2013-11-10 17:58:59.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2013-11-10 18:14:24.000000000","updated_by":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"reviewer":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"state":"REVIEWER"},{"updated":"2013-11-11 22:12:05.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2013-11-11 22:46:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"36d232c7952a4c9ef6d060f770280e7c5c256405","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-08 18:01:18.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/85/55685/1/check/gate-devstack-bash8/a915018 : SUCCESS in 7s\n- check-tempest-devstack-vm-full http://logs.openstack.org/85/55685/1/check/check-tempest-devstack-vm-full/3dd53a3 : SUCCESS in 31m 49s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/85/55685/1/check/check-tempest-devstack-vm-postgres-full/9af0964 : SUCCESS in 32m 19s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/85/55685/1/check/check-tempest-devstack-vm-neutron/ac19ad1 : SUCCESS in 27m 18s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/85/55685/1/check/gate-tempest-devstack-vm-large-ops/0ee7c99 : SUCCESS in 13m 25s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/85/55685/1/check/gate-tempest-devstack-vm-neutron-large-ops/53c343d : FAILURE in 20m 31s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/85/55685/1/check/check-grenade-devstack-vm/60f7a8c : SUCCESS in 33m 57s\n- check-swift-devstack-vm-functional http://logs.openstack.org/85/55685/1/check/check-swift-devstack-vm-functional/4f24fe2 : SUCCESS in 12m 15s\n","accounts_in_message":[],"_revision_number":1},{"id":"820e2ec68ee5d9f03421f7d33386f778d6616452","author":{"_account_id":5387,"name":"Andrew Melton","email":"andrew.melton@rackspace.com","username":"andrew-melton"},"date":"2013-11-08 18:43:10.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nJust tried this out, confirmed it fixes NOVNC_FROM_PACKAGE and allows devstack to be built with NOVNC_FROM_PACKAGE\u003dfalse. Thanks a bunch!","accounts_in_message":[],"_revision_number":1},{"id":"72f61e058bb56bb5ab1baf582418ca4f22c6579e","author":{"_account_id":7051,"name":"Swapnil Kulkarni","email":"skulkarn@redhat.com","username":"swapnilkulkarni2608"},"date":"2013-11-08 20:04:46.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"85be15efbb65792ee1465e9c641dd726cba809b4","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2013-11-08 23:03:47.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1bced563a76d66d095548cb0162cd008eafcbdc9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-11-09 18:34:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"76d5dd0ece01f62b7f940e70c1dc989285b93952","author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"date":"2013-11-10 05:49:48.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6b73057b01c63b789e262d38c18be9ce825b9f01","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2013-11-10 17:58:59.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"94b7b3e51ddf16e6a19f642048e69ceead25e1c3","author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"date":"2013-11-10 18:14:24.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"059c6eaf826ae4c1487f1063d4d36306fe320ad9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-11-11 22:12:05.000000000","message":"Patch Set 1: Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"b4edf1aaa6082bd5a556cd8f965e8c295480621d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-11 22:12:06.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"490ba5dd851c3f591d6539e2f9544337ff324c1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-11 22:46:43.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/85/55685/1/gate/gate-devstack-bash8/7df8460 : SUCCESS in 5s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/85/55685/1/gate/gate-tempest-devstack-vm-full/1d9a58d : SUCCESS in 31m 19s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/85/55685/1/gate/gate-tempest-devstack-vm-postgres-full/34389c9 : SUCCESS in 32m 59s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/85/55685/1/gate/gate-tempest-devstack-vm-neutron/9530fe7 : SUCCESS in 26m 44s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/85/55685/1/gate/gate-tempest-devstack-vm-large-ops/7885dcf : SUCCESS in 17m 39s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/85/55685/1/gate/gate-tempest-devstack-vm-neutron-large-ops/21afb29 : FAILURE in 20m 44s (non-voting)\n- gate-grenade-devstack-vm http://logs.openstack.org/85/55685/1/gate/gate-grenade-devstack-vm/5330a2e : SUCCESS in 34m 30s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/85/55685/1/gate/gate-swift-devstack-vm-functional/159ddd2 : SUCCESS in 9m 53s\n","accounts_in_message":[],"_revision_number":1},{"id":"b55c5eecb45795af1cf72f9d0362f94cac2682b7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-11 22:46:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"add4ca3ef0f916e31a781e118c8c4d04a9bec5cf","revisions":{"add4ca3ef0f916e31a781e118c8c4d04a9bec5cf":{"kind":"REWORK","_number":1,"created":"2013-11-08 17:27:12.000000000","uploader":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"ref":"refs/changes/85/55685/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/85/55685/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/55685/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/55685/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/55685/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/85/55685/1"}}},"commit":{"parents":[{"commit":"5a35e73b3419df571f55efd2a68ef565469e3d1b","subject":"Option for installing spice-html5 and novnc from packages","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5a35e73b3419df571f55efd2a68ef565469e3d1b"}]}],"author":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2013-11-08 17:22:51.000000000","tz":0},"committer":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2013-11-08 17:25:50.000000000","tz":0},"subject":"Fix FROM_PACKAGE checks for novnc and spice","message":"Fix FROM_PACKAGE checks for novnc and spice\n\nThe logic for installing novnc and spice from packages is broken,\nwhich makes it impossible to install from git, which makes bug\n1248923 more serious.\n\nChange-Id: I9ae722a5470a16555bca9018da342485f6d3e896\nRelated-Bug: 1248923\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/add4ca3ef0f916e31a781e118c8c4d04a9bec5cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/add4ca3ef0f916e31a781e118c8c4d04a9bec5cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}