)]}'
{"openrc":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"39a545694792452bc7e00f40273ac7b5b4b457b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# Load the last env variables if available"},{"line_number":30,"context_line":"if [[ -r $RC_DIR/.stackenv ]]; then"},{"line_number":31,"context_line":"    source $RC_DIR/.stackenv"},{"line_number":32,"context_line":"    export OS_CACERT"},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Get some necessary configuration"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f7c97a3_ceb987cc","line":32,"range":{"start_line":32,"start_character":11,"end_line":32,"end_character":20},"updated":"2018-05-10 07:41:24.000000000","message":"yea, it is present in stackenv\n\n- https://github.com/openstack-dev/devstack/blob/a14b78082f3993c62969c06b0a58bbd4d3ac9bc1/functions-common#L53","commit_id":"87c0de5240d33cf053815d90ba8e766958f412bb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c2f1f154b44b3741f663df09220673dbee591550","unresolved":false,"context_lines":[{"line_number":99,"context_line":"fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Set OS_CACERT to a default CA certificate chain if it exists."},{"line_number":102,"context_line":"if [[ ! -v OS_CACERT ]] ; then"},{"line_number":103,"context_line":"    DEFAULT_OS_CACERT\u003d$INT_CA_DIR/ca-chain.pem"},{"line_number":104,"context_line":"    # If the file does not exist, this may confuse preflight sanity checks"},{"line_number":105,"context_line":"    if [ -e $DEFAULT_OS_CACERT ] ; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f7c97a3_74820155","line":102,"updated":"2018-05-17 05:52:53.000000000","message":"It\u0027s a bit nit-picky, but does this make sense?  It says\n\n\"If OS_CACERT is not set, get the default value which is $INT_CA_DIR/ca-chain.pem\"\n\nhowever, INT_CA_DIR/ca-chain.pem doesn\u0027t seem like it can possibly be there unless SSL was turned on.  And by turning on SSL, we\u0027ve ensured that OS_CACERT is saved into stackenv?  Thus making this irrelevant?","commit_id":"87c0de5240d33cf053815d90ba8e766958f412bb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"250f7e1c648722f542325d127c5697e5492f30de","unresolved":false,"context_lines":[{"line_number":99,"context_line":"fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Set OS_CACERT to a default CA certificate chain if it exists."},{"line_number":102,"context_line":"if [[ ! -v OS_CACERT ]] ; then"},{"line_number":103,"context_line":"    DEFAULT_OS_CACERT\u003d$INT_CA_DIR/ca-chain.pem"},{"line_number":104,"context_line":"    # If the file does not exist, this may confuse preflight sanity checks"},{"line_number":105,"context_line":"    if [ -e $DEFAULT_OS_CACERT ] ; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5f7c97a3_e3d8901f","line":102,"in_reply_to":"5f7c97a3_74820155","updated":"2018-05-17 11:38:56.000000000","message":"With \"by turning on SSL\" you are referring to \"enable_service tls_proxy\"? I haven\u0027t checked in detail but maybe there are other ways of using the CA certs?\n\nAlso I don\u0027t think that this is directly related to the current patch, which is just about whether or not OS_CACERT gets exported. If we are hitting this block, the variable will get exported anyway, so the patch doesn\u0027t affect this block in any way. It may be possibly to drop this block, but that\u0027s a different issue IMO.","commit_id":"87c0de5240d33cf053815d90ba8e766958f412bb"}]}