)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"00c9e44064df5bcae1da1846d4f309ad424531a7","unresolved":true,"context_lines":[{"line_number":25,"context_line":"Major hurdles we have to get over are convincing rootwrap to trust"},{"line_number":26,"context_line":"binaries in the virtualenvs (so you\u0027ll notice we update rootwrap"},{"line_number":27,"context_line":"configs)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Depends-On: https://review.opendev.org/c/openstack/grenade/+/880266"},{"line_number":30,"context_line":"Change-Id: If9bc7ba45522189d03f19b86cb681bb150ee2f25"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"4de04aab_c74eebcd","line":28,"updated":"2023-04-13 23:19:11.000000000","message":"You should definitely add a co-authored-by line as anyone pushing this along deserves credit :)","commit_id":"fc29c07a84e6d574d46f6a9a98b837e1defe46d2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e8ad1a00b630a2754cb1ae6759f72ef00ae3432","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Major hurdles we have to get over are convincing rootwrap to trust"},{"line_number":26,"context_line":"binaries in the virtualenvs (so you\u0027ll notice we update rootwrap"},{"line_number":27,"context_line":"configs)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Depends-On: https://review.opendev.org/c/openstack/grenade/+/880266"},{"line_number":30,"context_line":"Change-Id: If9bc7ba45522189d03f19b86cb681bb150ee2f25"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"a7780d90_8cbd5129","line":28,"in_reply_to":"4de04aab_c74eebcd","updated":"2023-05-30 09:33:48.000000000","message":"Done","commit_id":"fc29c07a84e6d574d46f6a9a98b837e1defe46d2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f71d2dbf1546cb1bd36793c6e54f243faf869651","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"38df1093_6b0f6397","updated":"2022-04-19 20:03:15.000000000","message":"ill try and make that change localy if you want too update the patch.\nim going to call it a night but ill see if my local change works and let you know.","commit_id":"7246dbb009c1c15fa17b57290589b493d3fdd533"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"640e5807ef2f7299b8167002c4c3d39f618aaca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"f8ccba94_64f36952","updated":"2023-07-05 04:42:38.000000000","message":"recheck get new logs","commit_id":"1a78862528ddd61f8724e39aa8fdc077cdd227e8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3d5d71c20d0f598d8dc8083ca43d3d12c4d4deb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"a9f49c76_43b30ca4","updated":"2023-07-05 15:44:47.000000000","message":"recheck swift log upload failures","commit_id":"1a78862528ddd61f8724e39aa8fdc077cdd227e8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d8dce274eed42a98f7f024a8aeffd88bb78d4d06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"1c1c76f7_f96ae346","updated":"2023-07-18 14:26:09.000000000","message":"from what I can tell, it looks good, there are a few comments which haven\u0027t been addressed yet, so I put just +1","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"948f2c68ae10d7c73ee0577850194adedaa3da5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"cf10b395_1a8bdcfb","updated":"2023-07-25 15:03:36.000000000","message":"lgtm, but i\u0027ll let other to approve","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e92841ca8421120152a1f80a6934cd0178e5d2b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"28fc3e4c_f775a2ab","updated":"2023-07-06 11:09:31.000000000","message":"recheck failure in neutron-grenade likely unrelated","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5df9f1491dfeeb8532b5a1f25b6d9c131ce98bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"f0b948b3_3a3c6cb8","updated":"2023-07-08 11:31:57.000000000","message":"recheck nova-ceph-multistore also unstable","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"6bceb9608305d8d2f0ea605358f20d20b7008b77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"5ce0140b_deb34d5e","updated":"2023-08-08 16:18:42.000000000","message":"check experimental","commit_id":"a40f9cb91fbedddec89f0ffd6c7dd4b3828a232e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bfa299c8fe508982e0f71e3a6594b943c2d4d5a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"793b4542_62effd85","updated":"2023-08-03 16:02:08.000000000","message":"i ment to say this a few week ago i deployed patchset 32 and it worked quite well for me.\nthis is not a review but i have used this with both the default setup and nova with lvm and it generally seams to work well on ubuntu 22.04","commit_id":"a40f9cb91fbedddec89f0ffd6c7dd4b3828a232e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9be792fe8ecc84cf855fd6d51d85e001fd3d87a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"f83c41d4_d40e4130","updated":"2023-08-11 14:20:45.000000000","message":"let\u0027s not delay this any longer","commit_id":"a40f9cb91fbedddec89f0ffd6c7dd4b3828a232e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f1627931c948dbb490082e78736f12ce106dc364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"606a70d6_95fe3b6f","updated":"2023-08-08 16:18:35.000000000","message":"makes sense to me","commit_id":"a40f9cb91fbedddec89f0ffd6c7dd4b3828a232e"}],"files/apache-horizon.template":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64dc9429605bbdd1dc0b8e974655c0576d01c02c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003cVirtualHost *:80\u003e"},{"line_number":2,"context_line":"    %WSGIPYTHONHOME%"},{"line_number":3,"context_line":"    WSGIScriptAlias %WEBROOT% %HORIZON_DIR%/openstack_dashboard/wsgi.py"},{"line_number":4,"context_line":"    WSGIDaemonProcess horizon user\u003d%USER% group\u003d%GROUP% processes\u003d3 threads\u003d10 home\u003d%HORIZON_DIR% display-name\u003d%{GROUP}"},{"line_number":5,"context_line":"    WSGIApplicationGroup %{GLOBAL}"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"c0f1b1aa_7b9875e3","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":19},"updated":"2022-04-20 10:19:17.000000000","message":"as noted in https://review.opendev.org/c/openstack/devstack/+/558930/26/lib/horizon#132 this causees an error","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b02c5ae624ce9ccf6f1a4e9b8d5e9a130349c723","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cVirtualHost *:80\u003e"},{"line_number":2,"context_line":"    %WSGIPYTHONHOME%"},{"line_number":3,"context_line":"    WSGIScriptAlias %WEBROOT% %HORIZON_DIR%/openstack_dashboard/wsgi.py"},{"line_number":4,"context_line":"    WSGIDaemonProcess horizon user\u003d%USER% group\u003d%GROUP% processes\u003d3 threads\u003d10 home\u003d%HORIZON_DIR% display-name\u003d%{GROUP}"},{"line_number":5,"context_line":"    WSGIApplicationGroup %{GLOBAL}"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"b3492b54_4cc14d03","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":19},"in_reply_to":"c0f1b1aa_7b9875e3","updated":"2023-02-03 15:44:55.000000000","message":"Done","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64dc9429605bbdd1dc0b8e974655c0576d01c02c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    LogLevel warn"},{"line_number":40,"context_line":"    CustomLog /var/log/%APACHE_NAME%/horizon_access.log combined"},{"line_number":41,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"WSGISocketPrefix /var/run/%APACHE_NAME%"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"3f33372c_e58f3a7a","line":42,"updated":"2022-04-20 10:19:17.000000000","message":"i think you need to move %WSGIPYTHONHOME%\nto here","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b02c5ae624ce9ccf6f1a4e9b8d5e9a130349c723","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    LogLevel warn"},{"line_number":40,"context_line":"    CustomLog /var/log/%APACHE_NAME%/horizon_access.log combined"},{"line_number":41,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"WSGISocketPrefix /var/run/%APACHE_NAME%"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"301d3b7d_a16560d2","line":42,"in_reply_to":"3f33372c_e58f3a7a","updated":"2023-02-03 15:44:55.000000000","message":"Done","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"}],"functions-common":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f71d2dbf1546cb1bd36793c6e54f243faf869651","unresolved":true,"context_lines":[{"line_number":1602,"context_line":"    mkdir -p $SYSTEMD_DIR"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    iniset -sudo $unitfile \"Unit\" \"Description\" \"Devstack $service\""},{"line_number":1605,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"\\\"PATH\u003d$PATH\\\"\""},{"line_number":1606,"context_line":"    iniset -sudo $unitfile \"Service\" \"SyslogIdentifier\" \"$service\""},{"line_number":1607,"context_line":"    iniset -sudo $unitfile \"Service\" \"User\" \"$user\""},{"line_number":1608,"context_line":"    iniset -sudo $unitfile \"Service\" \"ExecStart\" \"$command\""}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"04213d03_382aa101","line":1605,"updated":"2022-04-19 20:03:15.000000000","message":"so i played around with this locally and this is not enough\n\nwe have to explictly pass the virtual env to uwsgi by appeding \n --home /opt/stack/data/.venv/\n\nso   the final unit file needs to look like this\n\n(.venv) [stack@controller stack]$ sudo cat /etc/systemd/system/devstack\\@keystone.service                                                                                                                                                                                                                                                                                                                                                   \n[Unit]\nDescription \u003d Devstack devstack@keystone.service\n\n[Service]\nRestartForceExitStatus \u003d 100\nNotifyAccess \u003d all\nRestart \u003d always\nKillMode \u003d process\nType \u003d notify\nExecReload \u003d /bin/kill -HUP $MAINPID\nExecStart \u003d /sbin/uwsgi --procname-prefix keystone --ini /etc/keystone/keystone-uwsgi-public.ini --home /opt/stack/data/.venv/\nUser \u003d stack\nSyslogIdentifier \u003d devstack@keystone.service\nEnvironment \u003d \"PATH\u003d/bin:/opt/stack/data/.venv/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin:/usr/sbin:/sbin\"\n\n[Install]\nWantedBy \u003d multi-user.target\n\n\nif we do that then it can start properly\n\nfor some reason uwsgi does not seam to seach the default path and or pick up the virutal env automatically without that.","commit_id":"7246dbb009c1c15fa17b57290589b493d3fdd533"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"15993ff65fbf300860386c00e103cad994abc541","unresolved":false,"context_lines":[{"line_number":1602,"context_line":"    mkdir -p $SYSTEMD_DIR"},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    iniset -sudo $unitfile \"Unit\" \"Description\" \"Devstack $service\""},{"line_number":1605,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"\\\"PATH\u003d$PATH\\\"\""},{"line_number":1606,"context_line":"    iniset -sudo $unitfile \"Service\" \"SyslogIdentifier\" \"$service\""},{"line_number":1607,"context_line":"    iniset -sudo $unitfile \"Service\" \"User\" \"$user\""},{"line_number":1608,"context_line":"    iniset -sudo $unitfile \"Service\" \"ExecStart\" \"$command\""}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"21e04be6_e6d73816","line":1605,"in_reply_to":"04213d03_382aa101","updated":"2023-07-18 17:11:14.000000000","message":"This is solved now by using the \"--venv $DEVSTACK_VENV\" option.","commit_id":"7246dbb009c1c15fa17b57290589b493d3fdd533"}],"inc/rootwrap":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"90d179ea40247722b09922fd929acc14c7445fad","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # Rely on $PATH set by devstack to determine what is safe to execute"},{"line_number":64,"context_line":"    # by rootwrap rather than use explicit whitelist of paths in"},{"line_number":65,"context_line":"    # rootwrap.conf"},{"line_number":66,"context_line":"    sudo sed -e \u0027s/^exec_dirs\u003d.*/#\u0026/\u0027 -i /etc/${project}/rootwrap.conf"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Set up the rootwrap sudoers"},{"line_number":69,"context_line":"    local tempfile"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"bf659307_d58ce4d8","line":66,"updated":"2018-04-09 12:28:02.000000000","message":"I think that this is o.k.-ish to get things to work fast, but IMO it needs a big fat TODO note to get cleaned up later on, since testing that projects do set up proper defaults here seems important to me in the long run.","commit_id":"f08cb4f7314a86c7ee6b7ff489932eca5488a091"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"51c72f186b0f54dc2cddb76a7b5bd491e2ece44c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # Rely on $PATH set by devstack to determine what is safe to execute"},{"line_number":64,"context_line":"    # by rootwrap rather than use explicit whitelist of paths in"},{"line_number":65,"context_line":"    # rootwrap.conf"},{"line_number":66,"context_line":"    sudo sed -e \u0027s/^exec_dirs\u003d.*/#\u0026/\u0027 -i /etc/${project}/rootwrap.conf"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    # Set up the rootwrap sudoers"},{"line_number":69,"context_line":"    local tempfile"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9f6a8fd7_6022cd54","line":66,"in_reply_to":"bf659307_d58ce4d8","updated":"2018-04-19 23:36:31.000000000","message":"I\u0027m not entirely sure this needs to be cleaned up. Rootwrap requires you whitelist dirs that it will run commands out of. When we move executables into $venv/bin we have to white list those and the overlap between $PATH and what we would end up with using service defaults + $venv/bin is basically complete.\n\nAs an alternative we can append the virtualenv dirs to the defaults if we like. I just don\u0027t know that it helps.","commit_id":"f08cb4f7314a86c7ee6b7ff489932eca5488a091"}],"lib/glance":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b02c5ae624ce9ccf6f1a4e9b8d5e9a130349c723","unresolved":true,"context_lines":[{"line_number":51,"context_line":"if is_opensuse; then"},{"line_number":52,"context_line":"    GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/etc/glance"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":"if [[ \"$GLOBAL_VENV\" \u003d\u003d \"True\" ]] ; then"},{"line_number":55,"context_line":"    GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d${DEVSTACK_VENV}/etc/glance"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":"# When Cinder is used as a glance store, you can optionally configure cinder to"},{"line_number":58,"context_line":"# optimize bootable volume creation by allowing volumes to be cloned directly"},{"line_number":59,"context_line":"# in the backend instead of transferring data via Glance.  To use this feature,"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"6404a4fc_8d89c5fc","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":2},"updated":"2023-02-03 15:44:55.000000000","message":"im not sure this is still required\n\neither data files are not being installed on newer relases or they are not being installed into the venv on debian bookworkm(testing)\n\ni worked around this locally by only copying the file if it extis\n\ni currently see it at s /usr/local/etc/glance/rootwrap.conf\n\nbut i dont know if that is form a previous install.","commit_id":"d5ae805ca49c25a99d8fdde3b0109885091b94e1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"15993ff65fbf300860386c00e103cad994abc541","unresolved":false,"context_lines":[{"line_number":51,"context_line":"if is_opensuse; then"},{"line_number":52,"context_line":"    GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/etc/glance"},{"line_number":53,"context_line":"fi"},{"line_number":54,"context_line":"if [[ \"$GLOBAL_VENV\" \u003d\u003d \"True\" ]] ; then"},{"line_number":55,"context_line":"    GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d${DEVSTACK_VENV}/etc/glance"},{"line_number":56,"context_line":"fi"},{"line_number":57,"context_line":"# When Cinder is used as a glance store, you can optionally configure cinder to"},{"line_number":58,"context_line":"# optimize bootable volume creation by allowing volumes to be cloned directly"},{"line_number":59,"context_line":"# in the backend instead of transferring data via Glance.  To use this feature,"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"f5081272_d28b8dcf","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":2},"in_reply_to":"6404a4fc_8d89c5fc","updated":"2023-07-18 17:11:14.000000000","message":"Well it does work with this, feel free to propose improvements on top of it.","commit_id":"d5ae805ca49c25a99d8fdde3b0109885091b94e1"}],"lib/horizon":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64dc9429605bbdd1dc0b8e974655c0576d01c02c","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        s,%APACHE_NAME%,$APACHE_NAME,g;"},{"line_number":130,"context_line":"        s,%DEST%,$DEST,g;"},{"line_number":131,"context_line":"        s,%WEBROOT%,$HORIZON_APACHE_ROOT,g;"},{"line_number":132,"context_line":"        s,%WSGIPYTHONHOME%,$wsgi_venv_config,g;"},{"line_number":133,"context_line":"    \\\" $FILES/apache-horizon.template \u003e$horizon_conf\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"d87be219_7014e601","line":132,"updated":"2022-04-20 10:19:17.000000000","message":"this generated coorectly \n\nhttps://zuul.opendev.org/t/openstack/build/83544f99d6e94d30b52e45bd05e7acea/log/controller/logs/apache_config/horizon_conf.txt#2\n\nbut it caused a syntax acording to the journal\n\n__CURSOR\u003ds\u003d82b0d264d435406a8cc58a90957d1af8;i\u003d3f1b;b\u003d5be7c974634e4f63b0922e8dbf2d9e62;m\u003d4c6a23a9;t\u003d5dd08bf71882a;x\u003d32f445437b67229d                                      │\n__REALTIME_TIMESTAMP\u003d1650404524918826                                                                                                                                    │\n__MONOTONIC_TIMESTAMP\u003d1282024361                                                                                                                                         │\n_BOOT_ID\u003d5be7c974634e4f63b0922e8dbf2d9e62                                                                                                                                │\n_MACHINE_ID\u003dc0959b08827f480480cc6c75519236e8                                                                                                                             ┤\nPRIORITY\u003d6                                                                                                                                                               │\nSYSLOG_FACILITY\u003d3                                                                                                                                                        │\n_UID\u003d0                                                                                                                                                                   │\n_GID\u003d0                                                                                                                                                                   │\n_SYSTEMD_SLICE\u003dsystem.slice                                                                                                                                              │\n_TRANSPORT\u003dstdout                                                                                                                                                        │\n_CAP_EFFECTIVE\u003d1ffffffffff                                                                                                                                               │\n_SELINUX_CONTEXT\u003dsystem_u:system_r:init_t:s0                                                                                                                             │\n_HOSTNAME\u003dcentos-9-stream-iweb-mtl01-0029374692                                                                                                                          │\nSYSLOG_IDENTIFIER\u003dhttpd                                                                                                                                                  │\n_COMM\u003dhttpd                                                                                                                                                              │\n_EXE\u003d/usr/sbin/httpd                                                                                                                                                     │\n_CMDLINE\u003d/usr/sbin/httpd -DFOREGROUND                                                                                                                                    │\n_SYSTEMD_CGROUP\u003d/system.slice/httpd.service                                                                                                                              │\n_SYSTEMD_UNIT\u003dhttpd.service                                                                                                                                              │\n_STREAM_ID\u003d50dd731125824b91be3b2751df12c060                                                                                                                              │\n_PID\u003d62648                                                                                                                                                               │\n_SYSTEMD_INVOCATION_ID\u003dd7bd389411c645b1b1676b9b61b1ea95                                                                                                                  │\nMESSAGE\u003dAH00526: Syntax error on line 2 of /etc/httpd/conf.d/horizon.conf:                                                                                               │\n                                                                                                                                                                         │\n__CURSOR\u003ds\u003d82b0d264d435406a8cc58a90957d1af8;i\u003d3f1c;b\u003d5be7c974634e4f63b0922e8dbf2d9e62;m\u003d4c6a23a9;t\u003d5dd08bf71882a;x\u003dcd73886a549bd261                                      │\n__REALTIME_TIMESTAMP\u003d1650404524918826                                                                                                                                    │\n__MONOTONIC_TIMESTAMP\u003d1282024361                                                                                                                                         │\n_BOOT_ID\u003d5be7c974634e4f63b0922e8dbf2d9e62                                                                                                                                │\n_MACHINE_ID\u003dc0959b08827f480480cc6c75519236e8                                                                                                                             │\nPRIORITY\u003d6                                                                                                                                                               │\nSYSLOG_FACILITY\u003d3                                                                                                                                                        │\n_UID\u003d0                                                                                                                                                                   │\n_GID\u003d0                                                                                                                                                                   │\n_SYSTEMD_SLICE\u003dsystem.slice                                                                                                                                              │\n_TRANSPORT\u003dstdout                                                                                                                                                        │\n_CAP_EFFECTIVE\u003d1ffffffffff                                                                                                                                               │\n_SELINUX_CONTEXT\u003dsystem_u:system_r:init_t:s0                                                                                                                             │\n_HOSTNAME\u003dcentos-9-stream-iweb-mtl01-0029374692                                                                                                                          │\nSYSLOG_IDENTIFIER\u003dhttpd                                                                                                                                                  │\n_COMM\u003dhttpd                                                                                                                                                              │\n_EXE\u003d/usr/sbin/httpd                                                                                                                                                     │\n_CMDLINE\u003d/usr/sbin/httpd -DFOREGROUND                                                                                                                                    │\n_SYSTEMD_CGROUP\u003d/system.slice/httpd.service                                                                                                                              │\n_SYSTEMD_UNIT\u003dhttpd.service                                                                                                                                              │\n_STREAM_ID\u003d50dd731125824b91be3b2751df12c060                                                                                                                              │\n_PID\u003d62648                                                                                                                                                               │\n_SYSTEMD_INVOCATION_ID\u003dd7bd389411c645b1b1676b9b61b1ea95                                                                                                                  │\nMESSAGE\u003dWSGIPythonHome cannot occur within \u003cVirtualHost\u003e section","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"15993ff65fbf300860386c00e103cad994abc541","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        s,%APACHE_NAME%,$APACHE_NAME,g;"},{"line_number":130,"context_line":"        s,%DEST%,$DEST,g;"},{"line_number":131,"context_line":"        s,%WEBROOT%,$HORIZON_APACHE_ROOT,g;"},{"line_number":132,"context_line":"        s,%WSGIPYTHONHOME%,$wsgi_venv_config,g;"},{"line_number":133,"context_line":"    \\\" $FILES/apache-horizon.template \u003e$horizon_conf\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"fb203a14_e17220e1","line":132,"in_reply_to":"c37c5990_c6e4b429","updated":"2023-07-18 17:11:14.000000000","message":"Done","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e8ad1a00b630a2754cb1ae6759f72ef00ae3432","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        s,%APACHE_NAME%,$APACHE_NAME,g;"},{"line_number":130,"context_line":"        s,%DEST%,$DEST,g;"},{"line_number":131,"context_line":"        s,%WEBROOT%,$HORIZON_APACHE_ROOT,g;"},{"line_number":132,"context_line":"        s,%WSGIPYTHONHOME%,$wsgi_venv_config,g;"},{"line_number":133,"context_line":"    \\\" $FILES/apache-horizon.template \u003e$horizon_conf\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    if is_ubuntu; then"}],"source_content_type":"application/x-shellscript","patch_set":26,"id":"c37c5990_c6e4b429","line":132,"in_reply_to":"d87be219_7014e601","updated":"2023-05-30 09:33:48.000000000","message":"This has been resolved by moving the line to outside the VirtualHost section","commit_id":"a8b988b0f021fab69178228bb66ab39659c48eab"}],"lib/neutron":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"90d179ea40247722b09922fd929acc14c7445fad","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    # Rely on $PATH set by devstack to determine what is safe to execute"},{"line_number":319,"context_line":"    # by rootwrap rather than use explicit whitelist of paths in"},{"line_number":320,"context_line":"    # rootwrap.conf"},{"line_number":321,"context_line":"    sudo sed -e \u0027s/^exec_dirs\u003d.*/#\u0026/\u0027 -i $NEUTRON_CONF_DIR/rootwrap.conf"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    # Set up the rootwrap sudoers for Neutron"},{"line_number":324,"context_line":"    tempfile\u003d`mktemp`"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"bf659307_75bdd866","line":321,"updated":"2018-04-09 12:28:02.000000000","message":"Dito","commit_id":"f08cb4f7314a86c7ee6b7ff489932eca5488a091"}],"lib/neutron-legacy":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"90d179ea40247722b09922fd929acc14c7445fad","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        sudo install -o root -g root -m 644 $NEUTRON_DIR/etc/rootwrap.conf $Q_RR_CONF_FILE"},{"line_number":880,"context_line":"    fi"},{"line_number":881,"context_line":"    sudo sed -e \"s:^filters_path\u003d.*$:filters_path\u003d$Q_CONF_ROOTWRAP_D:\" -i $Q_RR_CONF_FILE"},{"line_number":882,"context_line":"    sudo sed -e \u0027s:^exec_dirs\u003d\\(.*\\)$:exec_dirs\u003d\\1,/usr/local/bin:\u0027 -i $Q_RR_CONF_FILE"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    # Specify ``rootwrap.conf`` as first parameter to neutron-rootwrap"},{"line_number":885,"context_line":"    ROOTWRAP_SUDOER_CMD\u003d\"$NEUTRON_ROOTWRAP $Q_RR_CONF_FILE *\""}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"bf659307_d5a5c448","side":"PARENT","line":882,"updated":"2018-04-09 12:28:02.000000000","message":"I\u0027d leave this in for reference, even if the next step comments it out. Also see previous remark.","commit_id":"30b9d4879a5a0d353f08d6e355926a3ed8067f61"}],"stack.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f31f4c64f02205aaaed05befea79989c9d618854","unresolved":true,"context_lines":[{"line_number":814,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/openstack /usr/local/bin"},{"line_number":815,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/tox /usr/local/bin"},{"line_number":816,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/nova-manage /usr/local/bin"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    setup_devstack_virtualenv"},{"line_number":819,"context_line":"fi"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-sh","patch_set":33,"id":"9a9da304_9873205a","line":817,"updated":"2023-04-14 13:02:35.000000000","message":"instead of this can we just add /opt/stack/data/.venv/bin to the golbal system path?","commit_id":"4ff7902809b205cae7394a617f3b9390bce1311f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8e8ad1a00b630a2754cb1ae6759f72ef00ae3432","unresolved":true,"context_lines":[{"line_number":814,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/openstack /usr/local/bin"},{"line_number":815,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/tox /usr/local/bin"},{"line_number":816,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/nova-manage /usr/local/bin"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    setup_devstack_virtualenv"},{"line_number":819,"context_line":"fi"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-sh","patch_set":33,"id":"aac17779_ff738118","line":817,"in_reply_to":"9a9da304_9873205a","updated":"2023-05-30 09:33:48.000000000","message":"We might, but that would get rather distro specific. I can test for Ubuntu/Debian, others would have to take over the remaining cases.\n\nThere\u0027s also the issue where to insert it in the path. If you insert it at the front, you will override e.g. system python, which may lead to issues. If you insert it at the end, you might fail to override system tox or osc.","commit_id":"4ff7902809b205cae7394a617f3b9390bce1311f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"15993ff65fbf300860386c00e103cad994abc541","unresolved":false,"context_lines":[{"line_number":814,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/openstack /usr/local/bin"},{"line_number":815,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/tox /usr/local/bin"},{"line_number":816,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/nova-manage /usr/local/bin"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    setup_devstack_virtualenv"},{"line_number":819,"context_line":"fi"},{"line_number":820,"context_line":""}],"source_content_type":"text/x-sh","patch_set":33,"id":"f1ddd673_f3695c41","line":817,"in_reply_to":"aac17779_ff738118","updated":"2023-07-18 17:11:14.000000000","message":"Done","commit_id":"4ff7902809b205cae7394a617f3b9390bce1311f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1821b0b13d9553cc2ce9afd9ae61d5c7ad8e8ec2","unresolved":true,"context_lines":[{"line_number":828,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/cinder-rtstool /usr/local/bin"},{"line_number":829,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/openstack /usr/local/bin"},{"line_number":830,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/tox /usr/local/bin"},{"line_number":831,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/nova-manage /usr/local/bin"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    setup_devstack_virtualenv"},{"line_number":834,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":36,"id":"3128bcac_630ca85d","line":831,"updated":"2023-08-01 15:33:32.000000000","message":"These aren\u0027t removed by clean. Can we not just add the venv bin directory to PATH?","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aecb4997b13e8def47efd3e8395fdb59dd571785","unresolved":true,"context_lines":[{"line_number":828,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/cinder-rtstool /usr/local/bin"},{"line_number":829,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/openstack /usr/local/bin"},{"line_number":830,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/tox /usr/local/bin"},{"line_number":831,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/nova-manage /usr/local/bin"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    setup_devstack_virtualenv"},{"line_number":834,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":36,"id":"d7e9f44a_f4b3abb0","line":831,"in_reply_to":"3128bcac_630ca85d","updated":"2023-08-02 04:59:32.000000000","message":"This was discussed before, see https://review.opendev.org/c/openstack/devstack/+/558930/comment/9a9da304_9873205a/ . If you want to propose a different solution and test it on all distros, go ahead.\n\nI personally don\u0027t care much about cleanup, it isn\u0027t tested so I assume it is broken, IMO we should get rid of it and make sure that devstack is meant to be run only on throwaway machines. Feel free to propose an update for this, though.","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f7ba7b41d3ab0250e0f1ac299036fc979858a3","unresolved":true,"context_lines":[{"line_number":828,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/cinder-rtstool /usr/local/bin"},{"line_number":829,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/openstack /usr/local/bin"},{"line_number":830,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/tox /usr/local/bin"},{"line_number":831,"context_line":"    sudo ln -sf /opt/stack/data/.venv/bin/nova-manage /usr/local/bin"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    setup_devstack_virtualenv"},{"line_number":834,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":36,"id":"79a10de5_c63834b0","line":831,"in_reply_to":"d7e9f44a_f4b3abb0","updated":"2023-08-03 16:12:28.000000000","message":"i use it relitivly often so i dont think we should get rid of clean.sh\n\ni mostly do use disposable vms for devstack developemnt but i frequenly have them around for many months. generally unstack and stack is sufficnet but ocationlly i do use clean. i think its an impoarnt part of what devstack provides and we should adress dan\u0027s concen in a follow up.","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"90d179ea40247722b09922fd929acc14c7445fad","unresolved":false,"context_lines":[{"line_number":209,"context_line":"# instead we want one global set."},{"line_number":210,"context_line":"GLOBAL_VENV\u003d$(trueorfalse True GLOBAL_VENV)"},{"line_number":211,"context_line":"DEVSTACK_VENV2\u003d${DEVSTACK_VENV2:-$DATA_DIR/.venv2}"},{"line_number":212,"context_line":"DEVSTACK_VENV3\u003d${DEVSTACK_VENV3:-$DATA_DIR/.venv3}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# Enable use of Python virtual environments.  Individual project use of"},{"line_number":215,"context_line":"# venvs are controlled by the PROJECT_VENV array; every project with"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"bf659307_155a5c4f","line":212,"updated":"2018-04-09 12:28:02.000000000","message":"Minor question: Do we need these to be hidden? Might make manual testing easier to remove the \".\" from the dirnames.","commit_id":"f08cb4f7314a86c7ee6b7ff489932eca5488a091"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"51c72f186b0f54dc2cddb76a7b5bd491e2ece44c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"# instead we want one global set."},{"line_number":210,"context_line":"GLOBAL_VENV\u003d$(trueorfalse True GLOBAL_VENV)"},{"line_number":211,"context_line":"DEVSTACK_VENV2\u003d${DEVSTACK_VENV2:-$DATA_DIR/.venv2}"},{"line_number":212,"context_line":"DEVSTACK_VENV3\u003d${DEVSTACK_VENV3:-$DATA_DIR/.venv3}"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"# Enable use of Python virtual environments.  Individual project use of"},{"line_number":215,"context_line":"# venvs are controlled by the PROJECT_VENV array; every project with"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9f6a8fd7_c0e079fd","line":212,"in_reply_to":"bf659307_155a5c4f","updated":"2018-04-19 23:36:31.000000000","message":"They don\u0027t need to be hidden I think I did that because USE_VENV\u0027s default venv is .venv so this felt consistent. But we can make it more explicit (and not hidden) if we think it will help humans.","commit_id":"f08cb4f7314a86c7ee6b7ff489932eca5488a091"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0cf08444c3c840e7d6e19328dfc64da9fb85b276","unresolved":false,"context_lines":[{"line_number":215,"context_line":"# venvs are controlled by the PROJECT_VENV array; every project with"},{"line_number":216,"context_line":"# an entry in the array will be installed into the named venv."},{"line_number":217,"context_line":"# By default this will put each project into its own venv."},{"line_number":218,"context_line":"USE_VENV\u003d$(trueorfalse False USE_VENV)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# Add packages that need to be installed into a venv but are not in any"},{"line_number":221,"context_line":"# requirmenets files here, in a comma-separated list"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9f6a8fd7_60288de1","line":218,"updated":"2018-04-20 00:30:57.000000000","message":"dtroyer can probably confirm, but I don\u0027t think this really ever got to where we wanted it?  I think I\u0027d like to see us go one way or the other (per-service env, or a global) and remove this\n\nI would argue for this over per-service virtualenvs.  part of the testing has always been that things are co-installable, and i think that this keeps that largely the same","commit_id":"f08cb4f7314a86c7ee6b7ff489932eca5488a091"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a512e75bef38aa92d3658d592186edbe5894d535","unresolved":true,"context_lines":[{"line_number":189,"context_line":"# DATA_DIR but different DEST dirs and we don\u0027t want two sets of venvs,"},{"line_number":190,"context_line":"# instead we want one global set."},{"line_number":191,"context_line":"GLOBAL_VENV\u003d$(trueorfalse True GLOBAL_VENV)"},{"line_number":192,"context_line":"DEVSTACK_VENV\u003d${DEVSTACK_VENV3:-$DATA_DIR/.venv}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Enable use of Python virtual environments.  Individual project use of"},{"line_number":195,"context_line":"# venvs are controlled by the PROJECT_VENV array; every project with"}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"96f0653b_d44bc604","line":192,"updated":"2023-08-01 15:57:25.000000000","message":"Any reason this needs to be a hidden directory? I think it\u0027s unnecessary and just makes it more obscure. Also, why under data? I kinda expect I can nuke stuff under data to kill state and restart, but this would break the whole install.","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f7ba7b41d3ab0250e0f1ac299036fc979858a3","unresolved":false,"context_lines":[{"line_number":189,"context_line":"# DATA_DIR but different DEST dirs and we don\u0027t want two sets of venvs,"},{"line_number":190,"context_line":"# instead we want one global set."},{"line_number":191,"context_line":"GLOBAL_VENV\u003d$(trueorfalse True GLOBAL_VENV)"},{"line_number":192,"context_line":"DEVSTACK_VENV\u003d${DEVSTACK_VENV3:-$DATA_DIR/.venv}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Enable use of Python virtual environments.  Individual project use of"},{"line_number":195,"context_line":"# venvs are controlled by the PROJECT_VENV array; every project with"}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"915a3c4c_607f894c","line":192,"in_reply_to":"1d71b66d_12fe6168","updated":"2023-08-03 16:12:28.000000000","message":"Done","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aecb4997b13e8def47efd3e8395fdb59dd571785","unresolved":true,"context_lines":[{"line_number":189,"context_line":"# DATA_DIR but different DEST dirs and we don\u0027t want two sets of venvs,"},{"line_number":190,"context_line":"# instead we want one global set."},{"line_number":191,"context_line":"GLOBAL_VENV\u003d$(trueorfalse True GLOBAL_VENV)"},{"line_number":192,"context_line":"DEVSTACK_VENV\u003d${DEVSTACK_VENV3:-$DATA_DIR/.venv}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Enable use of Python virtual environments.  Individual project use of"},{"line_number":195,"context_line":"# venvs are controlled by the PROJECT_VENV array; every project with"}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"1d71b66d_12fe6168","line":192,"in_reply_to":"96f0653b_d44bc604","updated":"2023-08-02 04:59:32.000000000","message":"The argument for the data dir is in the comment above. If you can propose another directory that works fine with grenade, go ahead.\n\nI agree that is doesn\u0027t need to be hidden, this was mentioned a long time ago https://review.opendev.org/c/openstack/devstack/+/558930/comment/bf659307_155a5c4f/ but I missed to follow-up on it, will update.","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"}],"tools/install_prereqs.sh":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1821b0b13d9553cc2ce9afd9ae61d5c7ad8e8ec2","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# TODO(clarkb) remove these once we are switched to global venv by default"},{"line_number":83,"context_line":"export PYTHON\u003d$(which python${PYTHON3_VERSION} 2\u003e/dev/null || which python3 2\u003e/dev/null)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Mark end of run"}],"source_content_type":"text/x-sh","patch_set":36,"id":"f33b429a_baee7b94","line":82,"updated":"2023-08-01 15:33:32.000000000","message":"Doesn\u0027t this patch actually make it default?","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"80f7ba7b41d3ab0250e0f1ac299036fc979858a3","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# TODO(clarkb) remove these once we are switched to global venv by default"},{"line_number":83,"context_line":"export PYTHON\u003d$(which python${PYTHON3_VERSION} 2\u003e/dev/null || which python3 2\u003e/dev/null)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Mark end of run"}],"source_content_type":"text/x-sh","patch_set":36,"id":"84b7fcc4_4c34e6e2","line":82,"in_reply_to":"ebb8f449_77612323","updated":"2023-08-03 16:12:28.000000000","message":"then the comment is not really correct\n\nit should be more like \n\nTODO:  remove these once we only support venv installation","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aecb4997b13e8def47efd3e8395fdb59dd571785","unresolved":true,"context_lines":[{"line_number":79,"context_line":"    fi"},{"line_number":80,"context_line":"fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# TODO(clarkb) remove these once we are switched to global venv by default"},{"line_number":83,"context_line":"export PYTHON\u003d$(which python${PYTHON3_VERSION} 2\u003e/dev/null || which python3 2\u003e/dev/null)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Mark end of run"}],"source_content_type":"text/x-sh","patch_set":36,"id":"ebb8f449_77612323","line":82,"in_reply_to":"f33b429a_baee7b94","updated":"2023-08-02 04:59:32.000000000","message":"I think this comment means \"switched completely\", currently it can still be turned off since we couldn\u0027t get it working for all platforms. Feel free to propose a better wording.","commit_id":"06cd6b79d83cb3195e38da42907b40d4facce815"}]}