)]}'
{"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01ab1cc227bfdfab8ffd9520993daac22d7bb037","unresolved":false,"context_lines":[{"line_number":648,"context_line":"    if [[ $TEMPEST_PLUGINS !\u003d 0 ]] ; then"},{"line_number":649,"context_line":"        # Some in-tree plugins are referenced by path and may have already"},{"line_number":650,"context_line":"        # been added to upper constraints. If we are passed a filesystem path"},{"line_number":651,"context_line":"        # assume or url it is already the correct version. Otherwise you will"},{"line_number":652,"context_line":"        # get a pip error \"installation from path or url cannot be constrained"},{"line_number":653,"context_line":"        # to a version\""},{"line_number":654,"context_line":"        LOCAL_PLUGINS\u003d\"\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_70a5d2b4","line":651,"updated":"2018-04-19 08:11:20.000000000","message":"That sentence seems mangled. Did you mean this?\n\n\"If we are passed a filesystem path or url assume it is already the correct version.\"","commit_id":"76223ee9a52a25009ec6b744e8301dd061306715"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01ab1cc227bfdfab8ffd9520993daac22d7bb037","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        LOCAL_PLUGINS\u003d\"\""},{"line_number":655,"context_line":"        REMOTE_PLUGINS\u003d\"\""},{"line_number":656,"context_line":"        for plugin in $TEMPEST_PLUGINS; do"},{"line_number":657,"context_line":"            if [[ $plugin \u003d\u003d /* ]] || [[ $file \u003d~ ^.+://[^/]+ ]]; then"},{"line_number":658,"context_line":"                LOCAL_PLUGINS\u003d\"$LOCAL_PLUGINS $plugin\""},{"line_number":659,"context_line":"            else"},{"line_number":660,"context_line":"                REMOTE_PLUGINS\u003d\"$REMOTE_PLUGINS $plugin\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_30e19aff","line":657,"updated":"2018-04-19 08:11:20.000000000","message":"I can\u0027t see where you get \"$file\" from, shouldn\u0027t that be \"$plugin\", too?","commit_id":"76223ee9a52a25009ec6b744e8301dd061306715"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01ab1cc227bfdfab8ffd9520993daac22d7bb037","unresolved":false,"context_lines":[{"line_number":661,"context_line":"            fi"},{"line_number":662,"context_line":"        done"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if [[ ! -z \"${LOCAL_PLUGINS// }\" ]] ; then"},{"line_number":665,"context_line":"            tox -evenv-tempest -- pip install $LOCAL_PLUGINS"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":"        if [[ ! -z \"${REMOTE_PLUGINS// }\" ]] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_9078a62a","line":664,"updated":"2018-04-19 08:11:20.000000000","message":"You can use \"-n\" instead of \"! -z\" for simplicity.","commit_id":"76223ee9a52a25009ec6b744e8301dd061306715"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01ab1cc227bfdfab8ffd9520993daac22d7bb037","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        done"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if [[ ! -z \"${LOCAL_PLUGINS// }\" ]] ; then"},{"line_number":665,"context_line":"            tox -evenv-tempest -- pip install $LOCAL_PLUGINS"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":"        if [[ ! -z \"${REMOTE_PLUGINS// }\" ]] ; then"},{"line_number":668,"context_line":"            tox -evenv-tempest -- pip install -c $REQUIREMENTS_DIR/upper-constraints.txt $REMOTE_PLUGINS"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_50076e83","line":665,"range":{"start_line":665,"start_character":12,"end_line":665,"end_character":60},"updated":"2018-04-19 08:11:20.000000000","message":"Hmm, what happens if that local plugin has dependencies that are not installed yet? Wouldn\u0027t we still need to make sure that those are installed according to u-c.txt? I\u0027m thinking we may need to produce a modified version of u-c that omits just the $LOCAL_PLUGINS and still applies the remainder of the constraints. There should even be code for that in the tox-siblings stuff.","commit_id":"76223ee9a52a25009ec6b744e8301dd061306715"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"01ab1cc227bfdfab8ffd9520993daac22d7bb037","unresolved":false,"context_lines":[{"line_number":664,"context_line":"        if [[ ! -z \"${LOCAL_PLUGINS// }\" ]] ; then"},{"line_number":665,"context_line":"            tox -evenv-tempest -- pip install $LOCAL_PLUGINS"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":"        if [[ ! -z \"${REMOTE_PLUGINS// }\" ]] ; then"},{"line_number":668,"context_line":"            tox -evenv-tempest -- pip install -c $REQUIREMENTS_DIR/upper-constraints.txt $REMOTE_PLUGINS"},{"line_number":669,"context_line":"        fi"},{"line_number":670,"context_line":"        echo \"Checking installed Tempest plugins:\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f6a8fd7_5090ce43","line":667,"updated":"2018-04-19 08:11:20.000000000","message":"Dito","commit_id":"76223ee9a52a25009ec6b744e8301dd061306715"}]}
