)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f075c1565a0cd5bc7b282e5daa31ec16a66445c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-05-09 19:06:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure console proxy settings once globally"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change 12579c3db7b28381c8ec97945aa23ee02d54d22b moved console-related"},{"line_number":10,"context_line":"settings from the global nova.conf to the per cell nova_cellN.conf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_78d126fb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":46},"updated":"2018-05-09 20:26:10.000000000","message":"Need to update this too.","commit_id":"9c60c3c28b860606adc47b7a2bdabbabe6d2c4f5"}],"lib/nova":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"69a4983e8963fffe736d3e014a5c99639462358d","unresolved":false,"context_lines":[{"line_number":599,"context_line":"    # We need to configure the console proxies once globally even if we are in"},{"line_number":600,"context_line":"    # multi-cell mode because the nova-cpu.conf begins its life as a copy of"},{"line_number":601,"context_line":"    # the global nova.conf and nova-compute needs some of the console settings."},{"line_number":602,"context_line":"    configure_console_proxies"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    # If we\u0027re in multi-cell mode, add the console settings to each cell"},{"line_number":605,"context_line":"    # config because console proxies run per cell."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_9e20afb2","line":602,"updated":"2018-05-09 18:28:27.000000000","message":"Would it be better to just do the config directly in the nova-cpu.conf? Or is there no way to properly determine that this is going to be used for a compute only?","commit_id":"391f8fc330fd7b011c878389bc26fdf84ffc3cf2"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5376d7663f2fd729dc0ddbaccdfdec669111fea5","unresolved":false,"context_lines":[{"line_number":599,"context_line":"    # We need to configure the console proxies once globally even if we are in"},{"line_number":600,"context_line":"    # multi-cell mode because the nova-cpu.conf begins its life as a copy of"},{"line_number":601,"context_line":"    # the global nova.conf and nova-compute needs some of the console settings."},{"line_number":602,"context_line":"    configure_console_proxies"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    # If we\u0027re in multi-cell mode, add the console settings to each cell"},{"line_number":605,"context_line":"    # config because console proxies run per cell."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_290923dc","line":602,"in_reply_to":"5f7c97a3_9e20afb2","updated":"2018-05-09 18:45:42.000000000","message":"Maybe yeah -- I was concerned about having the global nova.conf contain the settings since that wouldn\u0027t be accurate/needed for a real deployment. So maybe we could call configure_console_proxies in start_nova_compute instead of here. Let me try something.","commit_id":"391f8fc330fd7b011c878389bc26fdf84ffc3cf2"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7bc340e911294eab4f6e36aa0c5b9b7340d41bd7","unresolved":false,"context_lines":[{"line_number":913,"context_line":"        # Because we\u0027re in multi-cell mode, console proxies were configured in"},{"line_number":914,"context_line":"        # the nova_cellN.conf and our nova-cpu.conf here was created as a copy"},{"line_number":915,"context_line":"        # of the global nova.conf. So, we need to configure the console-related"},{"line_number":916,"context_line":"        # in nova-cpu.conf separately."},{"line_number":917,"context_line":"        configure_console_proxies $NOVA_CPU_CONF"},{"line_number":918,"context_line":"    fi"},{"line_number":919,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_844b7e29","line":916,"updated":"2018-05-09 19:36:46.000000000","message":"Looks like I missed the word \"settings\" here.","commit_id":"9c60c3c28b860606adc47b7a2bdabbabe6d2c4f5"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4e30c734f8dd4246773d0b07d40f56620a944333","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        iniset $NOVA_CPU_CONF filter_scheduler track_instance_changes False"},{"line_number":911,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        # Because we\u0027re in multi-cell mode, console proxies were configured in"},{"line_number":914,"context_line":"        # the nova_cellN.conf and our nova-cpu.conf here was created as a copy"},{"line_number":915,"context_line":"        # of the global nova.conf. So, we need to configure the console-related"},{"line_number":916,"context_line":"        # settings in nova-cpu.conf separately."},{"line_number":917,"context_line":"        configure_console_proxies $NOVA_CPU_CONF"},{"line_number":918,"context_line":"    fi"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_c49ba363","line":917,"range":{"start_line":913,"start_character":0,"end_line":917,"end_character":48},"updated":"2018-05-10 14:11:36.000000000","message":"I\u0027m concerned that this is going to lead to a disconnect whereby multiple conf files must be edited in order to propagate changes. I assume there\u0027s some overlap between the options used by nova-compute and nova-conductor? If so, this disconnect is probably unavoidable but if not, we should probably break up \u0027configure_console_proxies\u0027 further.\n\nI think you touched on this in [1]\n\n[1] https://review.openstack.org/550141","commit_id":"9710dc8b5427dc8c6b8dd3fb2ad64acb9ba21c69"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d6d07b32c4f9951e23a8736a6fa4001fe19427a7","unresolved":false,"context_lines":[{"line_number":910,"context_line":"        iniset $NOVA_CPU_CONF filter_scheduler track_instance_changes False"},{"line_number":911,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        # Because we\u0027re in multi-cell mode, console proxies were configured in"},{"line_number":914,"context_line":"        # the nova_cellN.conf and our nova-cpu.conf here was created as a copy"},{"line_number":915,"context_line":"        # of the global nova.conf. So, we need to configure the console-related"},{"line_number":916,"context_line":"        # settings in nova-cpu.conf separately."},{"line_number":917,"context_line":"        configure_console_proxies $NOVA_CPU_CONF"},{"line_number":918,"context_line":"    fi"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_624396b0","line":917,"range":{"start_line":913,"start_character":0,"end_line":917,"end_character":48},"in_reply_to":"5f7c97a3_c49ba363","updated":"2018-05-10 22:53:14.000000000","message":"That\u0027s a good point. I think historically, it\u0027s just been mirror them between global nova.conf and compute nova.conf for ... ease?\n\nUpon auditing the options, I find for vnc, that these options are used by nova-compute and need to be in nova-cpu.conf:\n\n CONF.vnc.server_proxyclient_address\n CONF.vnc.keymap\n CONF.vnc.enabled\n CONF.vnc.server_listen\n CONF.vnc.novncproxy_base_url\n CONF.vnc.xvpvncproxy_base_url\n\nAnd these options are used by console proxies and need to be in nova_cellN.conf:\n\n CONF.vnc.xvpvncproxy_host\n CONF.vnc.xvpvncproxy_port\n CONF.vnc.novncproxy_host\n CONF.vnc.novncproxy_port\n CONF.vnc.vencrypt_client_key\n CONF.vnc.vencrypt_client_cert\n CONF.vnc.vencrypt_ca_certs\n CONF.vnc.auth_schemes\n\nMaybe it would be worthwhile to separate them to help convey what each set is for.","commit_id":"9710dc8b5427dc8c6b8dd3fb2ad64acb9ba21c69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"618a5d393d7a9199430a61a884c3f204a62c8cc4","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    fi"},{"line_number":607,"context_line":"}"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"function configure_console_compute {"},{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_e9dd4170","line":609,"range":{"start_line":609,"start_character":9,"end_line":609,"end_character":34},"updated":"2018-05-11 13:10:53.000000000","message":"nit: I\u0027d have called this something like \u0027configure_console_proxies_compute\u0027 and the below \u0027configure_console_proxies_conductor\u0027 to emphasize that these are two sides of the same coin","commit_id":"65ad79409537a76aec5cdba4360094a3047a025d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3dcec0386dfe880873237c1ef7081e8600c87c31","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    fi"},{"line_number":607,"context_line":"}"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"function configure_console_compute {"},{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_62101a01","line":609,"range":{"start_line":609,"start_character":9,"end_line":609,"end_character":34},"in_reply_to":"5f7c97a3_8c1a9bc9","updated":"2018-05-16 06:23:53.000000000","message":"IMHO the \"configure_console_\" prefix is a good enough grouping indicator.","commit_id":"65ad79409537a76aec5cdba4360094a3047a025d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5982ac80aaac9aec9b1b07b6525b588d4df1aa1d","unresolved":false,"context_lines":[{"line_number":606,"context_line":"    fi"},{"line_number":607,"context_line":"}"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"function configure_console_compute {"},{"line_number":610,"context_line":"    # All nova-compute workers need to know the vnc configuration options"},{"line_number":611,"context_line":"    # These settings don\u0027t hurt anything if n-xvnc and n-novnc are disabled"},{"line_number":612,"context_line":"    if is_service_enabled n-cpu; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_8c1a9bc9","line":609,"range":{"start_line":609,"start_character":9,"end_line":609,"end_character":34},"in_reply_to":"5f7c97a3_e9dd4170","updated":"2018-05-11 14:10:07.000000000","message":"K, I didn\u0027t use the word \"proxy\" here because no proxy runs on compute (and is a common misconception) so I was concerned about that being confusing. But I see your point, that being able to match them together as two sides of the same coin could be helpful too.","commit_id":"65ad79409537a76aec5cdba4360094a3047a025d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cc8074e41be993d426584a03198c8b776592b56e","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    if is_service_enabled n-spice; then"},{"line_number":633,"context_line":"        # Address on which instance spiceservers will listen on compute hosts."},{"line_number":634,"context_line":"        # For multi-host, this should be the management ip of the compute host."},{"line_number":635,"context_line":"        SPICESERVER_PROXYCLIENT_ADDRESS\u003d${SPICESERVER_PROXYCLIENT_ADDRESS\u003d$NOVA_SERVICE_LOCAL_HOST}"},{"line_number":636,"context_line":"        SPICESERVER_LISTEN\u003d${SPICESERVER_LISTEN\u003d$NOVA_SERVICE_LOCAL_HOST}"},{"line_number":637,"context_line":"        iniset $NOVA_CPU_CONF spice enabled true"},{"line_number":638,"context_line":"        iniset $NOVA_CPU_CONF spice server_listen \"$SPICESERVER_LISTEN\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_3420099c","line":635,"updated":"2018-05-17 05:30:31.000000000","message":"I think you actually want ${SPICESERVER_PROXYCLIENT_ADDRESS:-$NOVA_SERVICE_LOCAL_HOST} here ... it does not seem you\u0027d actually want to ignore a null value (dropping the \":\") and you don\u0027t really want assignment (\u003d) but just substitution (-) because you\u0027re assigning on the LHS\n\nanyway, it\u0027s just copy paste so not holding up for it...","commit_id":"65ad79409537a76aec5cdba4360094a3047a025d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"914684676b7e3118214ea5a7bacb1a9f8ef51a2d","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    if is_service_enabled n-spice; then"},{"line_number":633,"context_line":"        # Address on which instance spiceservers will listen on compute hosts."},{"line_number":634,"context_line":"        # For multi-host, this should be the management ip of the compute host."},{"line_number":635,"context_line":"        SPICESERVER_PROXYCLIENT_ADDRESS\u003d${SPICESERVER_PROXYCLIENT_ADDRESS\u003d$NOVA_SERVICE_LOCAL_HOST}"},{"line_number":636,"context_line":"        SPICESERVER_LISTEN\u003d${SPICESERVER_LISTEN\u003d$NOVA_SERVICE_LOCAL_HOST}"},{"line_number":637,"context_line":"        iniset $NOVA_CPU_CONF spice enabled true"},{"line_number":638,"context_line":"        iniset $NOVA_CPU_CONF spice server_listen \"$SPICESERVER_LISTEN\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5f7c97a3_b23180a5","line":635,"in_reply_to":"5f7c97a3_3420099c","updated":"2018-05-17 14:53:09.000000000","message":"Thanks for the note. I\u0027m not familiar with the pattern \"VNCSERVER_LISTEN\u003d${VNCSERVER_LISTEN\u003d$NOVA_SERVICE_LOCAL_HOST}\" (another example in this file) but doing a basic test locally, it seems to behave the same as using :-","commit_id":"65ad79409537a76aec5cdba4360094a3047a025d"}]}