)]}'
{"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1906f1c7ec80dfa4a52be3a1d77a1cf1f1ec585b","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled block_migration_for_live_migration ${USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION:-False}"},{"line_number":373,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled live_migrate_back_and_forth ${LIVE_MIGRATE_BACK_AND_FORTH:-False}"},{"line_number":374,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled attach_encrypted_volume ${ATTACH_ENCRYPTED_VOLUME_AVAILABLE:-True}"},{"line_number":375,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled scheduler_available_filters ${FILTERS}"},{"line_number":376,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":377,"context_line":"        # Cells doesn\u0027t support shelving/unshelving"},{"line_number":378,"context_line":"        iniset $TEMPEST_CONFIG compute-feature-enabled shelve False"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_84cdab86","line":375,"updated":"2018-05-25 12:56:40.000000000","message":"I\u0027m a bit uneasy because we are depending on a variable from lib/nova here. Is there a reasonable default we can add? Or otherwise wrap it in a \"[[ -n $FILTERS ]]\" check?","commit_id":"ac877bab417f4ceaba3e0bb44a28604bde426480"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"6f5b6482b5a8719913ed1a372aec2d79f99e0006","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled block_migration_for_live_migration ${USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION:-False}"},{"line_number":373,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled live_migrate_back_and_forth ${LIVE_MIGRATE_BACK_AND_FORTH:-False}"},{"line_number":374,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled attach_encrypted_volume ${ATTACH_ENCRYPTED_VOLUME_AVAILABLE:-True}"},{"line_number":375,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled scheduler_available_filters ${FILTERS}"},{"line_number":376,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":377,"context_line":"        # Cells doesn\u0027t support shelving/unshelving"},{"line_number":378,"context_line":"        iniset $TEMPEST_CONFIG compute-feature-enabled shelve False"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5f7c97a3_478b1567","line":375,"in_reply_to":"5f7c97a3_84cdab86","updated":"2018-05-25 13:52:32.000000000","message":"Done","commit_id":"ac877bab417f4ceaba3e0bb44a28604bde426480"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"549bf0285591f6857e457db4ccd2fc87ab15274d","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled live_migrate_back_and_forth ${LIVE_MIGRATE_BACK_AND_FORTH:-False}"},{"line_number":374,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled attach_encrypted_volume ${ATTACH_ENCRYPTED_VOLUME_AVAILABLE:-True}"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    if [[ -n \"$FILTERS\" ]]; then"},{"line_number":377,"context_line":"        iniset $TEMPEST_CONFIG compute-feature-enabled scheduler_available_filters ${FILTERS}"},{"line_number":378,"context_line":"    fi"},{"line_number":379,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5f7c97a3_e043fdae","line":376,"updated":"2018-06-12 05:45:26.000000000","message":"I *really* think we want some namespacing here.  It\u0027s one thing when it\u0027s only used sequentially within a single file, but I don\u0027t think we should expect that no plugin etc will set a variable FILTERS in between it being set in lib/nova and being used in here.\n\nSince nobody could be setting it to anything else (it\u0027s \u003d set in lib/nova) I think it\u0027s safe to at least call it NOVA_FILTERS","commit_id":"abc3e19af0747caa6f3ef417146502c06d8bc63c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ffeeaa02dfbb656744d13eb6a6cc128d70c1bf79","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    iniset $TEMPEST_CONFIG compute-feature-enabled attach_encrypted_volume ${ATTACH_ENCRYPTED_VOLUME_AVAILABLE:-True}"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    if [[ -n \"$NOVA_FILTERS\" ]]; then"},{"line_number":377,"context_line":"        iniset $TEMPEST_CONFIG compute-feature-enabled scheduler_available_filters ${NOVA_FILTERS}"},{"line_number":378,"context_line":"    fi"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    if is_service_enabled n-cell; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_abb55df2","line":377,"range":{"start_line":377,"start_character":55,"end_line":377,"end_character":82},"updated":"2018-11-02 06:58:20.000000000","message":"you should new config options - \u0027scheduler_enabled_filters\u0027 as you are changing this in https://review.openstack.org/#/c/570207/","commit_id":"0645bcbb1912311479e5c77503fcbbda5b55eef2"}]}