)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c833b948bf65f055515234796f9a9a311f179350","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow toggling of file_backed_memory for libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends on two things:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* the nova change that adds file-backed memory support"},{"line_number":12,"context_line":"  to the libvirt driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* a backport to stable/queens for devstack to enable"},{"line_number":15,"context_line":"  the queens UCA which has the minimum versions of"},{"line_number":16,"context_line":"  libvirt and qemu needed for file-backed memory to"},{"line_number":17,"context_line":"  pass grenade"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I56775a29c10d4ba5c8cddb3e3c512458c1064f41"},{"line_number":20,"context_line":"Depends-On: https://review.openstack.org/#/c/567876/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3f79a3b5_070344c0","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":14},"updated":"2018-08-29 19:44:29.000000000","message":"We can remove these now unless you plan on backporting this devstack change to stable/rocky.","commit_id":"62d83a5a92fa7d27bda291af170aef52f8cc469f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10d02c14e754330a6571dd3bbfdd8abdb47a375f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"00e6aca5_7ff86bb8","updated":"2022-05-31 14:28:46.000000000","message":"Ian seems to have a concern about the flag default, tho.","commit_id":"af42001eb7c19166b45a3ace8ab040f8b57c9bb0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"525610ff354ed97be109d635a47103e4b5fdae4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cbb48d15_90e0894f","updated":"2022-05-28 08:04:47.000000000","message":"recheck this still looks interesting, please follow ianw\u0027s comment if you still want to have this","commit_id":"af42001eb7c19166b45a3ace8ab040f8b57c9bb0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7fbedb0ef8a62ad6acd5b58f791b4d21e1a76bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"75acbf45_c0b73eb7","updated":"2022-05-31 14:38:25.000000000","message":"this shoudl no","commit_id":"af42001eb7c19166b45a3ace8ab040f8b57c9bb0"}],"lib/nova":[{"author":{"_account_id":26006,"name":"Zack Cornelius","email":"zack.cornelius@kove.net","username":"zcornelius"},"change_message_id":"b394752ef20d8df8fb86fbee1f062df1f707656b","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":931,"context_line":"\tiniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":932,"context_line":"\tiniset $NOVA_CPU_CONF libvirt ram_allocation_ratio 1.0"},{"line_number":933,"context_line":"\tsudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":934,"context_line":"\tsudo grep memory_backing_dir /etc/libvirt/qemu.conf"},{"line_number":935,"context_line":"\tsudo mount -t tmpfs none /var/lib/libvirt/qemu/ram"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f7c97a3_7ddc4644","line":932,"updated":"2018-06-13 19:14:26.000000000","message":"ram_allocation_ratio is in the DEFAULT group (Not sure if it would work in the libvirt group)","commit_id":"7779851ff016b9d55900ff9101418a5a31f06235"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"05ca89dcd92e4fbec105c712adb3d8aeaa36d47b","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":931,"context_line":"\tiniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":932,"context_line":"\tiniset $NOVA_CPU_CONF libvirt ram_allocation_ratio 1.0"},{"line_number":933,"context_line":"\tsudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":934,"context_line":"\tsudo grep memory_backing_dir /etc/libvirt/qemu.conf"},{"line_number":935,"context_line":"\tsudo mount -t tmpfs none /var/lib/libvirt/qemu/ram"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f7c97a3_72653f44","line":932,"in_reply_to":"5f7c97a3_7ddc4644","updated":"2018-06-14 14:54:46.000000000","message":"Guh, I know, I just copy/pasted too quick","commit_id":"7779851ff016b9d55900ff9101418a5a31f06235"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2dba84bab545160783beb71cedb1e17c550ce4fd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"QEMU_CONF\u003d/etc/libvirt/qemu.conf"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Allow toggling of file_backed_memory"},{"line_number":113,"context_line":"LIBVIRT_ENABLE_FILE_BACKED_MEMORY\u003d$(trueorfalse True LIBVIRT_ENABLE_FILE_BACKED_MEMORY)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Set default defaults here as some hypervisor drivers override these"},{"line_number":116,"context_line":"PUBLIC_INTERFACE_DEFAULT\u003dbr100"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5f7c97a3_1cd5dd1b","line":113,"range":{"start_line":113,"start_character":48,"end_line":113,"end_character":52},"updated":"2018-06-15 21:05:20.000000000","message":"Eventually if we get serious about keeping this change (I think we should), we can change this to False and then set it to True in a nova experimental queue job.","commit_id":"7ceb7695b6b79301af6f279316ae23e10e61b4ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2dba84bab545160783beb71cedb1e17c550ce4fd","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":928,"context_line":"    fi"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":931,"context_line":"\tiniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":932,"context_line":"\tiniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":933,"context_line":"\tsudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5f7c97a3_5cea75d8","line":930,"updated":"2018-06-15 21:05:20.000000000","message":"This should live in the libvirt-specific file:\n\nhttps://github.com/openstack-dev/devstack/blob/master/lib/nova_plugins/hypervisor-libvirt#L39","commit_id":"7ceb7695b6b79301af6f279316ae23e10e61b4ad"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce3307b45dfd3c2031e0617a652bcebbf2230d68","unresolved":false,"context_lines":[{"line_number":927,"context_line":"        iniset_rpc_backend nova $NOVA_CPU_CONF DEFAULT \"nova_cell${NOVA_CPU_CELL}\""},{"line_number":928,"context_line":"    fi"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":931,"context_line":"\tiniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":932,"context_line":"\tiniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":933,"context_line":"\tsudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5f7c97a3_cd6adbb3","line":930,"in_reply_to":"5f7c97a3_5cea75d8","updated":"2018-06-21 18:11:44.000000000","message":"TIL","commit_id":"7ceb7695b6b79301af6f279316ae23e10e61b4ad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c74322104983e2d6b2a968ffc62801836354da85","unresolved":false,"context_lines":[{"line_number":928,"context_line":"    fi"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":931,"context_line":"\tiniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":932,"context_line":"\tiniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":933,"context_line":"\tsudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":934,"context_line":"\tsudo grep memory_backing_dir /etc/libvirt/qemu.conf"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"5f7c97a3_9c1b2d1b","line":931,"range":{"start_line":931,"start_character":0,"end_line":931,"end_character":1},"updated":"2018-06-15 21:03:52.000000000","message":"bashate is blowing up on the whitespace:\n\nhttp://logs.openstack.org/92/574792/6/check/openstack-tox-bashate/f5fe3ae/job-output.txt.gz#_2018-06-15_15_59_30_648924","commit_id":"7ceb7695b6b79301af6f279316ae23e10e61b4ad"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9f748a0fb59c4a9d7d51a32c33789bbdefa637fd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"QEMU_CONF\u003d/etc/libvirt/qemu.conf"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Allow toggling of file_backed_memory, set to nonzero to enable"},{"line_number":113,"context_line":"LIBVIRT_ENABLE_FILE_BACKED_MEMORY\u003d0"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# Set default defaults here as some hypervisor drivers override these"},{"line_number":116,"context_line":"PUBLIC_INTERFACE_DEFAULT\u003dbr100"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3f79a3b5_5d4ea839","line":113,"updated":"2018-11-05 03:48:19.000000000","message":"we usually use trueorfalse for this sort of thing.  why isn\u0027t it in the plugin file?","commit_id":"af42001eb7c19166b45a3ace8ab040f8b57c9bb0"}],"lib/nova_plugins/hypervisor-libvirt":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce3307b45dfd3c2031e0617a652bcebbf2230d68","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":86,"context_line":"        iniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":87,"context_line":"        iniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":88,"context_line":"        sudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":89,"context_line":"        sudo grep memory_backing_dir /etc/libvirt/qemu.conf"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f7c97a3_ad3c3fbf","line":86,"range":{"start_line":86,"start_character":57,"end_line":86,"end_character":61},"updated":"2018-06-21 18:11:44.000000000","message":"I hardcoded this based on my guess about what would work for our gate workers. Maybe we should just make the enable flag be a non-zero integer, like our conf value? I\u0027ll defer to the devstack goes on this.","commit_id":"d96f8c2fa58a13af91da2fb79a8d3324266b0933"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e75a35c7a45ffd5cadf64317a10ab5423d4a4a85","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    fi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" \u003d\u003d \"True\" ]]; then"},{"line_number":86,"context_line":"        iniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":87,"context_line":"        iniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":88,"context_line":"        sudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":89,"context_line":"        sudo grep memory_backing_dir /etc/libvirt/qemu.conf"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f7c97a3_df236004","line":86,"range":{"start_line":86,"start_character":57,"end_line":86,"end_character":61},"in_reply_to":"5f7c97a3_ad3c3fbf","updated":"2018-06-21 21:24:54.000000000","message":"Yeah, I think that\u0027s a good idea to make this configurable. We should add a flag to adjust and maybe default to 4096. This value is going to depend a lot on both the disk and ram on the machine running devstack and people will likely need to adjust it.","commit_id":"d96f8c2fa58a13af91da2fb79a8d3324266b0933"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce3307b45dfd3c2031e0617a652bcebbf2230d68","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        iniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":87,"context_line":"        iniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":88,"context_line":"        sudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":89,"context_line":"        sudo grep memory_backing_dir /etc/libvirt/qemu.conf"},{"line_number":90,"context_line":"        sudo mount -t tmpfs none /var/lib/libvirt/qemu/ram"},{"line_number":91,"context_line":"        sudo systemctl restart libvirt-bin"},{"line_number":92,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f7c97a3_ad375fe3","line":89,"updated":"2018-06-21 18:11:44.000000000","message":"Note I had just put this here so I could see the result of my above damage. Doesn\u0027t hurt though.","commit_id":"d96f8c2fa58a13af91da2fb79a8d3324266b0933"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e75a35c7a45ffd5cadf64317a10ab5423d4a4a85","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        iniset $NOVA_CPU_CONF libvirt file_backed_memory 4096"},{"line_number":87,"context_line":"        iniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":88,"context_line":"        sudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":89,"context_line":"        sudo grep memory_backing_dir /etc/libvirt/qemu.conf"},{"line_number":90,"context_line":"        sudo mount -t tmpfs none /var/lib/libvirt/qemu/ram"},{"line_number":91,"context_line":"        sudo systemctl restart libvirt-bin"},{"line_number":92,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f7c97a3_7f7b2cbe","line":89,"in_reply_to":"5f7c97a3_ad375fe3","updated":"2018-06-21 21:24:54.000000000","message":"Honestly I would remove this, it\u0027ll just clutter the logs, if we need it for debugging we should have some other information about the context. Right now we\u0027ll just print the memory_backing_dir line without any context.","commit_id":"d96f8c2fa58a13af91da2fb79a8d3324266b0933"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"10d02c14e754330a6571dd3bbfdd8abdb47a375f","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" -gt 0 ]]; then"},{"line_number":86,"context_line":"        iniset $NOVA_CPU_CONF libvirt file_backed_memory ${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}"},{"line_number":87,"context_line":"        iniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":88,"context_line":"        sudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":89,"context_line":"        sudo mount -t tmpfs none /var/lib/libvirt/qemu/ram"},{"line_number":90,"context_line":"        sudo systemctl restart libvirt-bin"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7e336740_85cde2a4","line":87,"updated":"2022-05-31 14:28:46.000000000","message":"absolutely love this ^","commit_id":"af42001eb7c19166b45a3ace8ab040f8b57c9bb0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c7fbedb0ef8a62ad6acd5b58f791b4d21e1a76bf","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    if [[ \"${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}\" -gt 0 ]]; then"},{"line_number":86,"context_line":"        iniset $NOVA_CPU_CONF libvirt file_backed_memory ${LIBVIRT_ENABLE_FILE_BACKED_MEMORY}"},{"line_number":87,"context_line":"        iniset $NOVA_CPU_CONF DEFAULT ram_allocation_ratio 1.0"},{"line_number":88,"context_line":"        sudo sed -ri \u0027s/#(memory_backing_dir.*)$/\\1/\u0027 /etc/libvirt/qemu.conf"},{"line_number":89,"context_line":"        sudo mount -t tmpfs none /var/lib/libvirt/qemu/ram"},{"line_number":90,"context_line":"        sudo systemctl restart libvirt-bin"},{"line_number":91,"context_line":"    fi"},{"line_number":92,"context_line":"}"},{"line_number":93,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"0b99b814_3e3f3dcf","line":90,"range":{"start_line":88,"start_character":8,"end_line":90,"end_character":42},"updated":"2022-05-31 14:38:25.000000000","message":"this is not needed\nfile back memoy is also not intended to be on tempfs","commit_id":"af42001eb7c19166b45a3ace8ab040f8b57c9bb0"}]}