)]}'
{"roles/write-devstack-local-conf/library/devstack_local_conf.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"29098ea389a94ed1e5f4fb33d0d0607cecfcaee8","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                for project_name, project_info in self.projects.items():"},{"line_number":257,"context_line":"                    if project_info.get(\u0027required\u0027):"},{"line_number":258,"context_line":"                        required_projects.append(project_info[\u0027short_name\u0027])"},{"line_number":259,"context_line":"            if self.project:"},{"line_number":260,"context_line":"                if self.project[\u0027short_name\u0027] not in required_projects:"},{"line_number":261,"context_line":"                    required_projects.append(self.project[\u0027short_name\u0027])"},{"line_number":262,"context_line":"            if required_projects:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e9b28606","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":28},"updated":"2018-06-18 14:18:16.000000000","message":"I was thinking to add self.project to LIBS_FROM_GIT even lfg is set explicitly.","commit_id":"8e5f8c29b27c8dc83da31fbce5d92a173b91ba10"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bc437bf27b683f5d53e25d304ba0a85c6005688e","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                for project_name, project_info in self.projects.items():"},{"line_number":257,"context_line":"                    if project_info.get(\u0027required\u0027):"},{"line_number":258,"context_line":"                        required_projects.append(project_info[\u0027short_name\u0027])"},{"line_number":259,"context_line":"            if self.project:"},{"line_number":260,"context_line":"                if self.project[\u0027short_name\u0027] not in required_projects:"},{"line_number":261,"context_line":"                    required_projects.append(self.project[\u0027short_name\u0027])"},{"line_number":262,"context_line":"            if required_projects:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_90e877df","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":28},"in_reply_to":"5f7c97a3_55fd2806","updated":"2018-06-22 00:55:09.000000000","message":"self.project is no case i think. self.projects can be where jobs want to override the default LIB_FROM_GIT (means when it is coming from required_projects from base job definition)","commit_id":"8e5f8c29b27c8dc83da31fbce5d92a173b91ba10"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3ec18a944fa8c44fd4d7447e13fc67beca225a52","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                for project_name, project_info in self.projects.items():"},{"line_number":257,"context_line":"                    if project_info.get(\u0027required\u0027):"},{"line_number":258,"context_line":"                        required_projects.append(project_info[\u0027short_name\u0027])"},{"line_number":259,"context_line":"            if self.project:"},{"line_number":260,"context_line":"                if self.project[\u0027short_name\u0027] not in required_projects:"},{"line_number":261,"context_line":"                    required_projects.append(self.project[\u0027short_name\u0027])"},{"line_number":262,"context_line":"            if required_projects:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_55fd2806","line":259,"range":{"start_line":259,"start_character":12,"end_line":259,"end_character":28},"in_reply_to":"5f7c97a3_e9b28606","updated":"2018-06-19 21:30:50.000000000","message":"I think that makes sense, but I\u0027m not sure why we didn\u0027t do that in the first place. Do we have cases where we have jobs that set LIBS_FROM_GIT where we do not want the list extended with self.project or self.projects?","commit_id":"8e5f8c29b27c8dc83da31fbce5d92a173b91ba10"}]}