)]}'
{"functions":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d1ee7e7f7faf7d2fb7ebbb0eb431006d715618fc","unresolved":false,"context_lines":[{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"# Configure the API version for the OpenStack projects."},{"line_number":1054,"context_line":"# configure_API_version conf_file version"},{"line_number":1055,"context_line":"function configure_API_version() {"},{"line_number":1056,"context_line":"    iniset $1 keystone_authtoken auth_uri $KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_SERVICE_PORT/v$2"},{"line_number":1057,"context_line":"}"},{"line_number":1058,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAT3%2F%2FsJ4%3D","line":1055,"updated":"2014-01-03 12:44:28.000000000","message":"we should really be explicit here, so translate the $1 and $2 to local variables, and use those by name.","commit_id":"26f0cf51e383bfc0f479b0479b86def0c2857c53"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2785cc84b00c9abd0f35a37cc78b39288519d33f","unresolved":false,"context_lines":[{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"# Configure the API version for the OpenStack projects."},{"line_number":1054,"context_line":"# configure_API_version conf_file version"},{"line_number":1055,"context_line":"function configure_API_version() {"},{"line_number":1056,"context_line":"    iniset $1 keystone_authtoken auth_uri $KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_SERVICE_PORT/v$2"},{"line_number":1057,"context_line":"}"},{"line_number":1058,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAUH%2F%2F9mA%3D","line":1055,"in_reply_to":"AAAAT3%2F%2Frrw%3D","updated":"2014-01-06 06:29:13.000000000","message":"Thanks, Sean and Dean. I have moved this function to lib/keystone, and translated the variables to local ones.","commit_id":"26f0cf51e383bfc0f479b0479b86def0c2857c53"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"677ddc924986616128ff3a6e529684ca042d47ed","unresolved":false,"context_lines":[{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"# Configure the API version for the OpenStack projects."},{"line_number":1054,"context_line":"# configure_API_version conf_file version"},{"line_number":1055,"context_line":"function configure_API_version() {"},{"line_number":1056,"context_line":"    iniset $1 keystone_authtoken auth_uri $KEYSTONE_SERVICE_PROTOCOL://$KEYSTONE_SERVICE_HOST:$KEYSTONE_SERVICE_PORT/v$2"},{"line_number":1057,"context_line":"}"},{"line_number":1058,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAT3%2F%2Frrw%3D","line":1055,"in_reply_to":"AAAAT3%2F%2FsJ4%3D","updated":"2014-01-03 15:26:31.000000000","message":"This is one area Sean and I disagree...I\u0027d prefer to not have one line functions like this.\n\nThis one in particular adds 3 global variable dependencies to the functions file, maybe this should be in lib/keystone since everything hard-coded here is keystone-specific?","commit_id":"26f0cf51e383bfc0f479b0479b86def0c2857c53"}]}