)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1c5ba617e2368546b60bc1b3677c234c4938fd2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All these uwsgi invocations assume that the uwsgi binary is in the"},{"line_number":10,"context_line":"same directory as their project binaries are installed into.  That may"},{"line_number":11,"context_line":"not be correct if using a packaged wsgi.  Just find it in the path."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I298e3374e9c84e209ffcabbaaacda17f8df19f4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b3f47888","line":11,"updated":"2018-06-25 10:51:46.000000000","message":"These changes work fine on the Fedora gate, I\u0027m just a bit worried that there may be consumers that explicitly install uwsgi into some weird path outside of $PATH that may break by this.\n\nIn that case we\u0027d probably need to use some global $UWSGI_BINARY variable that we just initialize to $(which uwsgi) once that it installed.\n\nOr maybe I\u0027m overthinking this and we can go ahead with the current patch and see whether anything breaks.","commit_id":"838513b8f0364b51b472a234e6295bd991a841fa"}],"lib/nova":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1c5ba617e2368546b60bc1b3677c234c4938fd2","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    iniset $NOVA_CONF upgrade_levels compute \"auto\""},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    write_uwsgi_config \"$NOVA_UWSGI_CONF\" \"$NOVA_UWSGI\" \"/compute\""},{"line_number":521,"context_line":"    write_uwsgi_config \"$NOVA_METADATA_UWSGI_CONF\" \"$NOVA_METADATA_UWSGI\" \"\" \":${METADATA_SERVICE_PORT}\""},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    if is_service_enabled ceilometer; then"},{"line_number":524,"context_line":"        iniset $NOVA_CONF DEFAULT instance_usage_audit \"True\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_138f6c23","line":521,"updated":"2018-06-25 10:51:46.000000000","message":"This config is failing for me, since Fedora\u0027s uwsgi seems to always need a socket definition in addition to the http part.\n\nIf I manually add some random \"socket \u003d /path\", the service works fine.\n\nNot sure if that is a bug on the fedora side or whether we need to fix our function to always add a socket definition even for the http case.","commit_id":"838513b8f0364b51b472a234e6295bd991a841fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1c5ba617e2368546b60bc1b3677c234c4938fd2","unresolved":false,"context_lines":[{"line_number":986,"context_line":"    if [ \"$NOVA_USE_MOD_WSGI\" \u003d\u003d \"False\" ]; then"},{"line_number":987,"context_line":"        run_process n-api-meta \"$NOVA_BIN_DIR/nova-api-metadata --config-file $compute_cell_conf\""},{"line_number":988,"context_line":"    else"},{"line_number":989,"context_line":"        run_process n-api-meta \"$NOVA_BIN_DIR/uwsgi --procname-prefix nova-api-meta --ini $NOVA_METADATA_UWSGI_CONF\""},{"line_number":990,"context_line":"    fi"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    # nova-consoleauth always runs globally"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_f3975038","line":989,"updated":"2018-06-25 10:51:46.000000000","message":"This path needs fixing, too.","commit_id":"838513b8f0364b51b472a234e6295bd991a841fa"}]}