)]}'
{"lib/keystone":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8ae33cd28b8b7d9826ed6410e25c51becabce399","unresolved":false,"context_lines":[{"line_number":76,"context_line":"KEYSTONE_RESOURCE_BACKEND\u003d${KEYSTONE_RESOURCE_BACKEND:-sql}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Select Keystone\u0027s token provider (and format)"},{"line_number":79,"context_line":"# Choose from \u0027pki\u0027, \u0027pkiz\u0027, or \u0027fernet\u0027"},{"line_number":80,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d${KEYSTONE_TOKEN_FORMAT:-fernet}"},{"line_number":81,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d$(echo ${KEYSTONE_TOKEN_FORMAT} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_ffafe527","line":79,"updated":"2018-07-10 09:53:59.000000000","message":"Looking at https://review.openstack.org/#/c/543060/5/doc/source/admin/token-provider.rst I don\u0027t see pki* anymore, too, so maybe we can drop this part completely, too?","commit_id":"ced5cc1170e6092b921e6b3a04a9d8534ef9c06a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9007349bad687bcc9e2d1e0452b31917a677bf4e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"KEYSTONE_RESOURCE_BACKEND\u003d${KEYSTONE_RESOURCE_BACKEND:-sql}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Select Keystone\u0027s token provider (and format)"},{"line_number":79,"context_line":"# Choose from \u0027pki\u0027, \u0027pkiz\u0027, or \u0027fernet\u0027"},{"line_number":80,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d${KEYSTONE_TOKEN_FORMAT:-fernet}"},{"line_number":81,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d$(echo ${KEYSTONE_TOKEN_FORMAT} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_e86ac418","line":79,"in_reply_to":"5f7c97a3_b48c2cd8","updated":"2018-07-10 15:06:38.000000000","message":"My main point was dropping the options that are no longer supported.\n\nSince there are plans to add new options in the future, I\u0027m fine with leaving this in, even if the default deployment has only one option to choose from currently.","commit_id":"ced5cc1170e6092b921e6b3a04a9d8534ef9c06a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37bb35b1fbe913c799109d052fd74768ba0f6f07","unresolved":false,"context_lines":[{"line_number":76,"context_line":"KEYSTONE_RESOURCE_BACKEND\u003d${KEYSTONE_RESOURCE_BACKEND:-sql}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Select Keystone\u0027s token provider (and format)"},{"line_number":79,"context_line":"# Choose from \u0027pki\u0027, \u0027pkiz\u0027, or \u0027fernet\u0027"},{"line_number":80,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d${KEYSTONE_TOKEN_FORMAT:-fernet}"},{"line_number":81,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d$(echo ${KEYSTONE_TOKEN_FORMAT} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_a94925b9","line":79,"in_reply_to":"5f7c97a3_e86ac418","updated":"2018-07-11 00:57:26.000000000","message":"let\u0027s put keystone doc ref here which can be upto date doc to ref.","commit_id":"ced5cc1170e6092b921e6b3a04a9d8534ef9c06a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fc56d456e2b728c51bcbf5b55000254b9501ea24","unresolved":false,"context_lines":[{"line_number":76,"context_line":"KEYSTONE_RESOURCE_BACKEND\u003d${KEYSTONE_RESOURCE_BACKEND:-sql}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Select Keystone\u0027s token provider (and format)"},{"line_number":79,"context_line":"# Choose from \u0027pki\u0027, \u0027pkiz\u0027, or \u0027fernet\u0027"},{"line_number":80,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d${KEYSTONE_TOKEN_FORMAT:-fernet}"},{"line_number":81,"context_line":"KEYSTONE_TOKEN_FORMAT\u003d$(echo ${KEYSTONE_TOKEN_FORMAT} | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":82,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_b48c2cd8","line":79,"in_reply_to":"5f7c97a3_ffafe527","updated":"2018-07-10 14:31:37.000000000","message":"Removing token providers that we don\u0027t support anymore like PKI and PKIZ seems like a good idea for consistency. We\u0027ve talked about adding other formats though [0]. Would exposing this variable with a single option be out of the question?\n\n[0] https://review.openstack.org/#/c/541903/","commit_id":"ced5cc1170e6092b921e6b3a04a9d8534ef9c06a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c4e8b58661d7ef44671330a9129dec10b076c4c9","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    $KEYSTONE_BIN_DIR/keystone-manage --config-file $KEYSTONE_CONF db_sync"},{"line_number":439,"context_line":"    time_stop \"dbsync\""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    if [[ \"$KEYSTONE_TOKEN_FORMAT\" \u003d\u003d \"pki\" || \"$KEYSTONE_TOKEN_FORMAT\" \u003d\u003d \"pkiz\" ]]; then"},{"line_number":442,"context_line":"        # Set up certificates"},{"line_number":443,"context_line":"        rm -rf $KEYSTONE_CONF_DIR/ssl"},{"line_number":444,"context_line":"        $KEYSTONE_BIN_DIR/keystone-manage --config-file $KEYSTONE_CONF pki_setup"},{"line_number":445,"context_line":"    fi"},{"line_number":446,"context_line":"    if [[ \"$KEYSTONE_TOKEN_FORMAT\" \u003d\u003d \"fernet\" ]]; then"},{"line_number":447,"context_line":"        rm -rf \"$KEYSTONE_CONF_DIR/fernet-keys/\""},{"line_number":448,"context_line":"        $KEYSTONE_BIN_DIR/keystone-manage --config-file $KEYSTONE_CONF fernet_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_4806581d","line":445,"range":{"start_line":441,"start_character":0,"end_line":445,"end_character":6},"updated":"2018-07-10 14:38:19.000000000","message":"This will never be exercised. This subcommand is no longer a part of ``keystone-manage`` actually [0][1].\n\nSo another good bit to clean up.\n\n[0] https://docs.openstack.org/keystone/latest/cli/index.html#usage\n[1] https://review.openstack.org/#/c/430938/","commit_id":"ced5cc1170e6092b921e6b3a04a9d8534ef9c06a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"37bb35b1fbe913c799109d052fd74768ba0f6f07","unresolved":false,"context_lines":[{"line_number":438,"context_line":"    $KEYSTONE_BIN_DIR/keystone-manage --config-file $KEYSTONE_CONF db_sync"},{"line_number":439,"context_line":"    time_stop \"dbsync\""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    if [[ \"$KEYSTONE_TOKEN_FORMAT\" \u003d\u003d \"pki\" || \"$KEYSTONE_TOKEN_FORMAT\" \u003d\u003d \"pkiz\" ]]; then"},{"line_number":442,"context_line":"        # Set up certificates"},{"line_number":443,"context_line":"        rm -rf $KEYSTONE_CONF_DIR/ssl"},{"line_number":444,"context_line":"        $KEYSTONE_BIN_DIR/keystone-manage --config-file $KEYSTONE_CONF pki_setup"},{"line_number":445,"context_line":"    fi"},{"line_number":446,"context_line":"    if [[ \"$KEYSTONE_TOKEN_FORMAT\" \u003d\u003d \"fernet\" ]]; then"},{"line_number":447,"context_line":"        rm -rf \"$KEYSTONE_CONF_DIR/fernet-keys/\""},{"line_number":448,"context_line":"        $KEYSTONE_BIN_DIR/keystone-manage --config-file $KEYSTONE_CONF fernet_setup"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f7c97a3_495bb185","line":445,"range":{"start_line":441,"start_character":0,"end_line":445,"end_character":6},"in_reply_to":"5f7c97a3_4806581d","updated":"2018-07-11 00:57:26.000000000","message":"done. thanks","commit_id":"ced5cc1170e6092b921e6b3a04a9d8534ef9c06a"}]}