)]}'
{"lib/tempest":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ea3479db6e15ee80ab41ca24e9e7c798d3328cdc","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            # Ensure ``flavor_ref`` and ``flavor_ref_alt`` have different values."},{"line_number":225,"context_line":"            # Some resize instance in tempest tests depends on this."},{"line_number":226,"context_line":"            for f in ${flavors[@]:1}; do"},{"line_number":227,"context_line":"                if [[ \"$f\" !\u003d \"$flavor_ref\" ]]; then"},{"line_number":228,"context_line":"                    flavor_ref_alt\u003d$f"},{"line_number":229,"context_line":"                    break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_cfd08222","side":"PARENT","line":226,"updated":"2018-08-13 06:14:26.000000000","message":"So this chooses the first flavor in the list that is no the DEFAULT_INSTANCE_TYPE as the alternative flavor when DEFAULT_INSTANCE_TYPE is set, right?  And that is too small to resize to?\n\nthis all seems very non-deterministic ... \n\nwhat if you just took prior entry to DEFAULT_INSTANCE_TYPE?  Wouldn\u0027t that be basically the previous smallest size to DEFAULT_INSTANCE_TYPE?","commit_id":"1106e7e697e8ab65c77a9b2ad7a673adf18cf569"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"76c202320b154d4ea114fa1ea81289a4c97131ef","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            # Ensure ``flavor_ref`` and ``flavor_ref_alt`` have different values."},{"line_number":225,"context_line":"            # Some resize instance in tempest tests depends on this."},{"line_number":226,"context_line":"            for f in ${flavors[@]:1}; do"},{"line_number":227,"context_line":"                if [[ \"$f\" !\u003d \"$flavor_ref\" ]]; then"},{"line_number":228,"context_line":"                    flavor_ref_alt\u003d$f"},{"line_number":229,"context_line":"                    break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_4d7f1369","side":"PARENT","line":226,"in_reply_to":"3f79a3b5_9bf29ae2","updated":"2018-10-08 03:31:23.000000000","message":"Ok, choosing directly and maintaining the status quo is the least risky option.  I\u0027d be happy if it just has a few guiding comments around the magic numbers so the next poor sod doesn\u0027t have to reverse engineer this so much :)","commit_id":"1106e7e697e8ab65c77a9b2ad7a673adf18cf569"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"7441acf70970595f56df41341867b0c23c2e854c","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            # Ensure ``flavor_ref`` and ``flavor_ref_alt`` have different values."},{"line_number":225,"context_line":"            # Some resize instance in tempest tests depends on this."},{"line_number":226,"context_line":"            for f in ${flavors[@]:1}; do"},{"line_number":227,"context_line":"                if [[ \"$f\" !\u003d \"$flavor_ref\" ]]; then"},{"line_number":228,"context_line":"                    flavor_ref_alt\u003d$f"},{"line_number":229,"context_line":"                    break"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_9bf29ae2","side":"PARENT","line":226,"in_reply_to":"3f79a3b5_cfd08222","updated":"2018-10-03 09:33:41.000000000","message":"to the first 2 questions: yes, it does exactly that and yes it\u0027s too small to resize.\n\nto the third question: im not sure, is it enough to resize? we know that \u002784\u0027 is so i think that my approach is less deterministic than your suggestion but I\u0027m probably missing something","commit_id":"1106e7e697e8ab65c77a9b2ad7a673adf18cf569"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ea3479db6e15ee80ab41ca24e9e7c798d3328cdc","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        # If ``DEFAULT_INSTANCE_TYPE`` is not declared, use the new behavior"},{"line_number":189,"context_line":"        # Tempest creates its own instance types"},{"line_number":190,"context_line":"        available_flavors\u003d$(nova flavor-list)"},{"line_number":191,"context_line":"        if [[ ! ( $available_flavors \u003d~ \u0027m1.micro\u0027 ) ]]; then"},{"line_number":192,"context_line":"            openstack flavor create --id 84 --ram 128 --disk 0 --vcpus 1 m1.micro"},{"line_number":193,"context_line":"        fi"},{"line_number":194,"context_line":"        flavor_ref_alt\u003d84"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_cf9882c1","line":191,"updated":"2018-08-13 06:14:26.000000000","message":"We\u0027ve got to put some comments here, I can\u0027t see how anyone reading this a priori could understand what\u0027s going on.  I\u0027ve stared at it for 10 minutes and still not 100% sure, and moving this out makes the flow even less logical.","commit_id":"3ae7c62c52bdcc5f1bd5abd79ac4509bf2ef1206"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"7441acf70970595f56df41341867b0c23c2e854c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        # If ``DEFAULT_INSTANCE_TYPE`` is not declared, use the new behavior"},{"line_number":189,"context_line":"        # Tempest creates its own instance types"},{"line_number":190,"context_line":"        available_flavors\u003d$(nova flavor-list)"},{"line_number":191,"context_line":"        if [[ ! ( $available_flavors \u003d~ \u0027m1.micro\u0027 ) ]]; then"},{"line_number":192,"context_line":"            openstack flavor create --id 84 --ram 128 --disk 0 --vcpus 1 m1.micro"},{"line_number":193,"context_line":"        fi"},{"line_number":194,"context_line":"        flavor_ref_alt\u003d84"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_3bc4a65f","line":191,"in_reply_to":"3f79a3b5_cf9882c1","updated":"2018-10-03 09:33:41.000000000","message":"Agree, we need to comment that we want to force existing \u0027m1.micro\u0027 or equivalent (id 84) flavors in any case. I understand it\u0027s confusing but if somebody comes up with a better solution I\u0027d be glad to implement/review it.\nAlso in L194 i think that i need to set it either to \u0027m1.micro\u0027 (if it already exists) or to 84 if we created it.","commit_id":"3ae7c62c52bdcc5f1bd5abd79ac4509bf2ef1206"}]}