)]}'
{"id":"openstack%2Fdevstack~5925","triplet_id":"openstack%2Fdevstack~master~I6083a871209d30c81ca6876b1ef6c154aef7f598","project":"openstack/devstack","branch":"master","topic":"bug/967429","hashtags":[],"change_id":"I6083a871209d30c81ca6876b1ef6c154aef7f598","subject":"Don\u0027t use $USERNAME in openrc.","status":"MERGED","created":"2012-03-28 19:28:57.000000000","updated":"2012-03-28 21:28:14.000000000","submitted":"2012-03-28 21:28:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c85b5a36bda63d2440bbf2b624eb70bd9ec64249","_number":5925,"virtual_id_number":5925,"owner":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-03-28 21:28:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":2,"date":"2012-03-28 20:56:48.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-03-28 21:15:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2012-03-28 21:02:50.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"date":"2012-03-28 20:56:48.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2012-03-28 21:02:50.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-03-28 20:15:16.000000000","updated_by":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"reviewer":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"state":"REVIEWER"},{"updated":"2012-03-28 20:56:48.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-03-28 21:02:50.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2012-03-28 21:28:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5a4c69c0e247635e505c7a20afab1d4a4547e6b5","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2012-03-28 20:15:16.000000000","message":"Patch Set 1: (2 inline comments)\n\nSeems like we could just use the OS_[X] names rather than the CUSTOM_[x] names?","accounts_in_message":[],"_revision_number":1},{"id":"580f1f94a6d31807912525c722a3b2035b5656b8","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-03-28 20:18:45.000000000","message":"Patch Set 1:\n\nYeah, that works for me, too.","accounts_in_message":[],"_revision_number":1},{"id":"c119220d2a6980b95067ea9a5cdc43c4efa5629e","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2012-03-28 20:22:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"403effa398aba7eaa67878959107aa3deb5c70b3","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-03-28 20:56:48.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nthank god","accounts_in_message":[],"_revision_number":2},{"id":"906082b327d28058abd4da7c9c334f0467d56192","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-03-28 21:02:50.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nI\u0027ve been meaning to do this...thanks","accounts_in_message":[],"_revision_number":2},{"id":"ef397b12d3104b84b45b515d21451d69fe950a2b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-28 21:15:36.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3073/ : FAILURE \nhttps://jenkins.openstack.org/job/gate-devstack-merge/265/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ad729fee308d1d7d69866b7762dac23e929b0487","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-28 21:28:14.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/3075/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-devstack-merge/266/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4fa632e4ea22609a02e01235eea0227f86026091","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-03-28 21:28:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"08e07fb4c817796db06bf8b90982c3b7cc5c41f2","revisions":{"8c905ac905892f16b7b45d0b0a5f9a337f502e2e":{"kind":"REWORK","_number":1,"created":"2012-03-28 19:28:57.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/25/5925/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/25/5925/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/5925/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/5925/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/5925/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/25/5925/1"}}},"commit":{"parents":[{"commit":"408b009ccda94a95d3b3999f6db2bd62e92cdfb9","subject":"Allow skipping exercises.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/408b009ccda94a95d3b3999f6db2bd62e92cdfb9"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-03-28 19:23:58.000000000","tz":-240},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-03-28 19:28:50.000000000","tz":-240},"subject":"Don\u0027t use $USERNAME in openrc.","message":"Don\u0027t use $USERNAME in openrc.\n\nFix bug 967429.\n\nDon\u0027t use $USERNAME as a variable in openrc.  It\u0027s commonly set by\ndefault and can result in $OS_USERNAME getting set to something else\nunexpectedly, resulting in an environment that doesn\u0027t work.\n\nChange-Id: I6083a871209d30c81ca6876b1ef6c154aef7f598\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8c905ac905892f16b7b45d0b0a5f9a337f502e2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8c905ac905892f16b7b45d0b0a5f9a337f502e2e"}]},"branch":"refs/heads/master"},"08e07fb4c817796db06bf8b90982c3b7cc5c41f2":{"kind":"REWORK","_number":2,"created":"2012-03-28 20:22:18.000000000","uploader":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"ref":"refs/changes/25/5925/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/25/5925/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/5925/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/5925/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/5925/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/25/5925/2"}}},"commit":{"parents":[{"commit":"408b009ccda94a95d3b3999f6db2bd62e92cdfb9","subject":"Allow skipping exercises.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/408b009ccda94a95d3b3999f6db2bd62e92cdfb9"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-03-28 19:23:58.000000000","tz":-240},"committer":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-03-28 20:22:08.000000000","tz":-240},"subject":"Don\u0027t use $USERNAME in openrc.","message":"Don\u0027t use $USERNAME in openrc.\n\nFix bug 967429.\n\nDon\u0027t use $USERNAME as a variable in openrc.  It\u0027s commonly set by\ndefault and can result in $OS_USERNAME getting set to something else\nunexpectedly, resulting in an environment that doesn\u0027t work.\n\nChange-Id: I6083a871209d30c81ca6876b1ef6c154aef7f598\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/08e07fb4c817796db06bf8b90982c3b7cc5c41f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/08e07fb4c817796db06bf8b90982c3b7cc5c41f2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}