)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"a48230835d4d103877692494fd389ae2e6f5daa0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mykola Yakovliev \u003cVegasQ@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-21 15:24:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Q_QOS flag to enable QoS endpoints in neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patchsets allows to modify neutron.conf/service_plugins and"},{"line_number":10,"context_line":"ml2_conf.ini/extensions_drivers to include qos."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ec458471","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":9},"updated":"2018-08-24 21:53:34.000000000","message":"Is there a naming convention somewhere? Should it be Q_ML2_QOS, since it suppose to wor","commit_id":"5f7a22f63050a79e24364fd908ce976ff284117a"}],"lib/neutron":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"c900ac1a85249410b4b9b1f09e07c76603580676","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    Q_QOS\u003d${Q_QOS:-False}"},{"line_number":310,"context_line":"    if [[ \"$Q_QOS\" \u003d\u003d \"True\" ]]; then"},{"line_number":311,"context_line":"        neutron_service_plugin_class_add qos"},{"line_number":312,"context_line":"    fi"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_ccac4837","line":311,"range":{"start_line":311,"start_character":44,"end_line":311,"end_character":44},"updated":"2018-08-21 22:45:50.000000000","message":"We can\u0027t use neutron_ml2_extension_driver_add in here since [0] override it.\n\n[0] https://github.com/openstack-dev/devstack/blob/master/lib/neutron_plugins/ml2#L132","commit_id":"5f7a22f63050a79e24364fd908ce976ff284117a"}],"lib/neutron-legacy":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"c900ac1a85249410b4b9b1f09e07c76603580676","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    Q_QOS\u003d${Q_QOS:-False}"},{"line_number":754,"context_line":"    if [[ \"$Q_QOS\" \u003d\u003d \"True\" ]]; then"},{"line_number":755,"context_line":"        _neutron_service_plugin_class_add qos"},{"line_number":756,"context_line":"    fi"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    _neutron_setup_rootwrap"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_8ca65053","line":755,"range":{"start_line":755,"start_character":45,"end_line":755,"end_character":45},"updated":"2018-08-21 22:45:50.000000000","message":"We can\u0027t use _neutron_ml2_extension_driver_add in here since [0] override it.\n\n[0] https://github.com/openstack-dev/devstack/blob/master/lib/neutron_plugins/ml2#L132","commit_id":"5f7a22f63050a79e24364fd908ce976ff284117a"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":16274,"name":"Mykola Yakovliev","email":"VegasQ@gmail.com","username":"vegasq"},"change_message_id":"f667ef7981a43e7ac38b4440757c52c184b1bd36","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Make sure it is able to set empty to ML2_L3_PLUGIN."},{"line_number":47,"context_line":"ML2_L3_PLUGIN\u003d${ML2_L3_PLUGIN-neutron.services.l3_router.l3_router_plugin.L3RouterPlugin}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Q_QOS\u003d${Q_QOS:-False}"},{"line_number":50,"context_line":"if [[ \"$Q_QOS\" \u003d\u003d \"True\" ]]; then"},{"line_number":51,"context_line":"    Q_ML2_PLUGIN_EXT_DRIVERS\u003d\"$Q_ML2_PLUGIN_EXT_DRIVERS,qos\""},{"line_number":52,"context_line":"fi"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"function populate_ml2_config {"},{"line_number":55,"context_line":"    CONF\u003d$1"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_d1785f2c","line":52,"range":{"start_line":49,"start_character":0,"end_line":52,"end_character":2},"updated":"2018-08-21 21:35:51.000000000","message":"Worth mentioning that this part might be done with:\n\nQ_ML2_PLUGIN_EXT_DRIVERS\u003dqos,port_security\n\nBut this way to enable QoS you will need to specify 2 different options when one has a hard requirement for another. And missing value in Q_ML2_PLUGIN_EXT_DRIVERS will prevent neutron from starting.","commit_id":"5f7a22f63050a79e24364fd908ce976ff284117a"}]}