)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9c4b0c20d90283463e2ec6376f4b3a27935f908","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the API DB), we should run the nova-status upgrade check"},{"line_number":12,"context_line":"to verify the deployment."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.openstack.org/599875/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I9683bf94233ebacb3057ce159cb3dc53aa55a2f4"},{"line_number":17,"context_line":"Related-Bug: #1790721"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_a769b7be","line":14,"updated":"2018-09-05 01:03:08.000000000","message":"This fixes the issue where nova-status thought we had 0 compute nodes. Then it should fail on bug 1790721 because it won\u0027t think we have any resource providers because we\u0027re not using the proper placement DB API context manager.","commit_id":"b5355024ddf2c0c9b01be21b25d914bd000a2159"}],"stack.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a9a4fce5e89d611514880aedc9c6464b7cbe79f8","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1422,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1423,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1424,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1425,"context_line":"fi"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"# Run local script"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_ec947638","line":1424,"updated":"2018-09-05 00:15:47.000000000","message":"This seems to be hitting before we actually have compute nodes in the database, or the check isn\u0027t iterating the cells properly:\n\nhttp://logs.openstack.org/47/599847/1/check/tempest-full-py3/caf3557/controller/logs/devstacklog.txt.gz#_2018-09-04_22_05_45_875","commit_id":"bde4024ba6f0d35837062614adbc085fa45a0fad"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1a1fea290a8cc436f55f78a841983a174a26f389","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1422,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1423,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1424,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1425,"context_line":"fi"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"# Run local script"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_acf99e80","line":1424,"in_reply_to":"3f79a3b5_ec947638","updated":"2018-09-05 00:26:37.000000000","message":"Yeah the compute node on this same host was created before we run the check:\n\nhttp://logs.openstack.org/47/599847/1/check/tempest-full-py3/caf3557/controller/logs/screen-n-cpu.txt.gz#_Sep_04_22_05_02_228963\n\nby about 43 seconds, so the check isn\u0027t properly iterating cells or something...","commit_id":"bde4024ba6f0d35837062614adbc085fa45a0fad"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d781bc6bee4da1327186a6c7a50f35fc9fd06106","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1422,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1423,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1424,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1425,"context_line":"fi"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"# Run local script"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_42415561","line":1424,"updated":"2018-10-30 06:53:43.000000000","message":"If I read the commit message correctly, this should only be running if we have n-cpu enabled, so it should be moved directly after the discover_hosts call above.","commit_id":"f908483cb7318810901ddea7e7181ad3f232b11f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cbf529841f0e84a51f833e5641b708346ee8e692","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1422,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1423,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1424,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1425,"context_line":"fi"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"# Run local script"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_71bf6f79","line":1424,"in_reply_to":"3f79a3b5_42415561","updated":"2018-10-30 18:13:27.000000000","message":"It works without any computes being reported, it just assumes it\u0027s a base install (which this is) and no computes have started yet:\n\nhttp://logs.openstack.org/47/599847/3/check/tempest-full/6e6118a/controller/logs/devstacklog.txt.gz#_2018-10-26_01_33_01_548\n\nSo technically it\u0027s OK either way, and this still runs after discover_hosts, even though the commit message is a bit misleading.","commit_id":"f908483cb7318810901ddea7e7181ad3f232b11f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb172ed88027dac2d531475d67107dff2960ef80","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1422,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1423,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1424,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1425,"context_line":"fi"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"# Run local script"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_aa4a7057","line":1424,"in_reply_to":"3f79a3b5_71bf6f79","updated":"2018-10-30 20:04:11.000000000","message":"O.k., fine for me, then, thx.","commit_id":"f908483cb7318810901ddea7e7181ad3f232b11f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"92da41630eca5673ea58ca9f64c8bfd66b307d2d","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"    # to verify the base install. Note that this is good enough in a"},{"line_number":1447,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1448,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1449,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1450,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1451,"context_line":"fi"},{"line_number":1452,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffb9cba7_b2300fea","line":1449,"updated":"2019-04-29 13:04:03.000000000","message":"Looking at this again, I\u0027m not sure referencing the deprecated devstack-gate setup is the best thing to do.\n\nMaybe rather write this as a TODO item to update the devstack-multinode job tooling accordingly?","commit_id":"a242eba68f871aec32ccec6d5e01c8bade7bd54c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"92ddc84087022eaf6f34f39954e4f6dcba5b9cbf","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"    # to verify the base install. Note that this is good enough in a"},{"line_number":1447,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1448,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1449,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1450,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1451,"context_line":"fi"},{"line_number":1452,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffb9cba7_85649823","line":1449,"in_reply_to":"ffb9cba7_28a26e4c","updated":"2019-04-30 08:00:02.000000000","message":"Either way works for me, slightly preferring the second option.","commit_id":"a242eba68f871aec32ccec6d5e01c8bade7bd54c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"73bc58f5882abdbba5201bbdbc60f770b6a91aee","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"    # to verify the base install. Note that this is good enough in a"},{"line_number":1447,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1448,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1449,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1450,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1451,"context_line":"fi"},{"line_number":1452,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffb9cba7_843810ee","line":1449,"in_reply_to":"ffb9cba7_85649823","updated":"2019-04-30 22:30:00.000000000","message":"Done","commit_id":"a242eba68f871aec32ccec6d5e01c8bade7bd54c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6e2c3f6417386e7818c8299876e056c82d001673","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"    # to verify the base install. Note that this is good enough in a"},{"line_number":1447,"context_line":"    # single node deployment, but in a multi-node setup it won\u0027t verify"},{"line_number":1448,"context_line":"    # any subnodes - that would have to be driven from whatever tooling"},{"line_number":1449,"context_line":"    # is deploying the subnodes, e.g. devstack-gate."},{"line_number":1450,"context_line":"    $NOVA_BIN_DIR/nova-status --config-file $NOVA_CONF upgrade check"},{"line_number":1451,"context_line":"fi"},{"line_number":1452,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"ffb9cba7_28a26e4c","line":1449,"in_reply_to":"ffb9cba7_b2300fea","updated":"2019-04-29 16:10:07.000000000","message":"Sure, I\u0027d like to not lose the +2 from ianw - so are you OK with a follow up or will you fast approve if I make the change in this same patch?","commit_id":"a242eba68f871aec32ccec6d5e01c8bade7bd54c"}]}