)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"794c76342077eaf09b5e1bf150af221757b82185","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* a database table creation script (within placement)"},{"line_number":18,"context_line":"* a grenade change to upgrade from placement-in-nova to placement"},{"line_number":19,"context_line":"  migrating existing data"},{"line_number":20,"context_line":"* a devstack-gate change which will add openstack/placement to the"},{"line_number":21,"context_line":"  PROJECTS variable for legacy jobs (that change itself depends"},{"line_number":22,"context_line":"  on https://review.openstack.org/608266 which adds the"},{"line_number":23,"context_line":"  openstack/placement repo as a required project in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_bb36124f","line":20,"updated":"2018-10-08 15:50:21.000000000","message":"I\u0027m not entirely sure how much this will fix things because if jobs override required-projects in their job definition it might not matter what is in legacy-dsvm-base.","commit_id":"8fd3093b351f7b10d7e96e7a2387fa6c5fd37600"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"85956764d0a19af5b9190e6bd2dc25eea40bb4a9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"* a database table creation script (within placement)"},{"line_number":18,"context_line":"* a grenade change to upgrade from placement-in-nova to placement"},{"line_number":19,"context_line":"  migrating existing data"},{"line_number":20,"context_line":"* a devstack-gate change which will add openstack/placement to the"},{"line_number":21,"context_line":"  PROJECTS variable for legacy jobs (that change itself depends"},{"line_number":22,"context_line":"  on https://review.openstack.org/608266 which adds the"},{"line_number":23,"context_line":"  openstack/placement repo as a required project in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_437c9e70","line":20,"in_reply_to":"3f79a3b5_bb36124f","updated":"2018-10-09 13:42:30.000000000","message":"You do not override required-projects, you always inherit and add - meaning: IF you base it on legacy-dsvm-base, you always get the repo.","commit_id":"8fd3093b351f7b10d7e96e7a2387fa6c5fd37600"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dcce04b59f3b702471564b011e867214ebff7d4d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"nova-placement-api) in /etc/placement."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"openstack/placement is also added to the required-projects in"},{"line_number":16,"context_line":"the devstack-minimal zuul job."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I0b217e7a8c68a637b7a3445f6c44b7574117e320"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"3f79a3b5_dc414c64","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":20},"updated":"2018-11-20 23:42:03.000000000","message":"devstack; devstack-minimal is the parent","commit_id":"487d6c2be79f56c35bba1e2a81ab15fe50c61ee8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"88b23c5dac3fa723525546309abcd9e8f30abe75","unresolved":false,"context_lines":[{"line_number":15,"context_line":"openstack/placement is also added to the required-projects in"},{"line_number":16,"context_line":"the devstack zuul job."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"And placement is added ENABLED_PYTHON3_PACKAGES since it works"},{"line_number":19,"context_line":"just fine in python3."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0b217e7a8c68a637b7a3445f6c44b7574117e320"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3f79a3b5_0cb98f7a","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":22},"updated":"2018-11-26 14:10:47.000000000","message":"added to","commit_id":"087edf1bcad4c65dd8eaff750a4f7edf8d177bd9"}],"lib/placement":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9509f5dac98847b9396d98a08b7d623804d0ce5f","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    install_apache_wsgi"},{"line_number":172,"context_line":"    # Install the openstackclient placement client plugin for CLI"},{"line_number":173,"context_line":"    pip_install_gr osc-placement"},{"line_number":174,"context_line":"    git_clone $PLACEMENT_REPO $PLACEMENT_DIR $PLACEMENT_BRANCH"},{"line_number":175,"context_line":"    setup_develop $PLACEMENT_DIR"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_21c80c20","line":174,"updated":"2018-09-06 14:20:32.000000000","message":"This is what\u0027s killing grenade:\n\nhttp://logs.openstack.org/62/600162/3/check/neutron-grenade/5800f54/logs/grenade.sh.txt.gz#_2018-09-05_23_28_59_925\n\nBecause openstack/placement doesn\u0027t have a stable/rocky branch. Or I\u0027m assuming that\u0027s related.","commit_id":"5639e5012ae27d0a9fac221c3b4b46089f576b9a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"eb1d87216c07a2864457f40449d13e095de5cabb","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    install_apache_wsgi"},{"line_number":172,"context_line":"    # Install the openstackclient placement client plugin for CLI"},{"line_number":173,"context_line":"    pip_install_gr osc-placement"},{"line_number":174,"context_line":"    git_clone $PLACEMENT_REPO $PLACEMENT_DIR $PLACEMENT_BRANCH"},{"line_number":175,"context_line":"    setup_develop $PLACEMENT_DIR"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_3b7d3fb2","line":174,"in_reply_to":"3f79a3b5_0024a30d","updated":"2018-09-11 16:18:05.000000000","message":"I tried it here:\n\nhttps://review.openstack.org/#/c/601407/\n\nwhich failed a lot of stuff, but I haven\u0027t had a chance to walk through the logs to see if that is making it happen and/or why it\u0027s failing).","commit_id":"5639e5012ae27d0a9fac221c3b4b46089f576b9a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e05144594ea480f60b5e81e7926961b475ff21e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    install_apache_wsgi"},{"line_number":172,"context_line":"    # Install the openstackclient placement client plugin for CLI"},{"line_number":173,"context_line":"    pip_install_gr osc-placement"},{"line_number":174,"context_line":"    git_clone $PLACEMENT_REPO $PLACEMENT_DIR $PLACEMENT_BRANCH"},{"line_number":175,"context_line":"    setup_develop $PLACEMENT_DIR"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_81ffa000","line":174,"in_reply_to":"3f79a3b5_21c80c20","updated":"2018-09-06 14:29:34.000000000","message":"Hmm, actually, I bet this might be related to the list of projects included in the d-g run, so maybe something in the zuul config for the grenade job that needs to include the placement repo?\n\nhttp://git.openstack.org/cgit/openstack/neutron/tree/.zuul.yaml#n280\n\nOr something in here:\n\nhttps://github.com/openstack-infra/devstack-gate/blob/d2bd6faf5ecffbebe8eb721b7fb1bc366ca4bd9a/roles/test-matrix/files/features.yaml#L3","commit_id":"5639e5012ae27d0a9fac221c3b4b46089f576b9a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7ed4ef3d8038867f9bd4ff6fb58e2188ef1fe8c2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    install_apache_wsgi"},{"line_number":172,"context_line":"    # Install the openstackclient placement client plugin for CLI"},{"line_number":173,"context_line":"    pip_install_gr osc-placement"},{"line_number":174,"context_line":"    git_clone $PLACEMENT_REPO $PLACEMENT_DIR $PLACEMENT_BRANCH"},{"line_number":175,"context_line":"    setup_develop $PLACEMENT_DIR"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_0024a30d","line":174,"in_reply_to":"3f79a3b5_25abf11e","updated":"2018-09-10 20:48:32.000000000","message":"I may be misreading it, but it looks like devstack-gate sets both PROJECTS and LIBS_FROM_GIT, the former control the \"lays down the projects ahead\" and the latter controls what libs_from_git is able to do.\n\nSo it seems like none of that stuff is going to work until we modify PROJECTS. Is that right?\n\nIn which case, perhaps making a modification of the nova-next job (since it is in tree) that depends on this change might be worth exploring?","commit_id":"5639e5012ae27d0a9fac221c3b4b46089f576b9a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"358e38eec5575c1b0d7fea884051f3f1a23e80a7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    install_apache_wsgi"},{"line_number":172,"context_line":"    # Install the openstackclient placement client plugin for CLI"},{"line_number":173,"context_line":"    pip_install_gr osc-placement"},{"line_number":174,"context_line":"    git_clone $PLACEMENT_REPO $PLACEMENT_DIR $PLACEMENT_BRANCH"},{"line_number":175,"context_line":"    setup_develop $PLACEMENT_DIR"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_8591a5fa","line":174,"in_reply_to":"3f79a3b5_81ffa000","updated":"2018-09-10 19:42:01.000000000","message":"It\u0027s killing some of the devstack jobs as well.","commit_id":"5639e5012ae27d0a9fac221c3b4b46089f576b9a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5d9e312714b8d8577abb1a6b11ec9a0fa9550878","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    install_apache_wsgi"},{"line_number":172,"context_line":"    # Install the openstackclient placement client plugin for CLI"},{"line_number":173,"context_line":"    pip_install_gr osc-placement"},{"line_number":174,"context_line":"    git_clone $PLACEMENT_REPO $PLACEMENT_DIR $PLACEMENT_BRANCH"},{"line_number":175,"context_line":"    setup_develop $PLACEMENT_DIR"},{"line_number":176,"context_line":"}"},{"line_number":177,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_25abf11e","line":174,"in_reply_to":"3f79a3b5_8591a5fa","updated":"2018-09-10 19:44:14.000000000","message":"I think this is supposed to be gated on libs_from_git, like this:\n\nhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L835\n\nOtherwise, infra lays down the projects ahead of time so you get the proper git sha being tested I believe.","commit_id":"5639e5012ae27d0a9fac221c3b4b46089f576b9a"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"73d4cafb6d32c3df4f2cf55c2f0ac7e78730e8e8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"PLACEMENT_UWSGI\u003d$PLACEMENT_BIN_DIR/placement-api"},{"line_number":41,"context_line":"PLACEMENT_UWSGI_CONF\u003d$PLACEMENT_CONF_DIR/placement-uwsgi.ini"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The placement service can optionally use a separate database"},{"line_number":44,"context_line":"# connection. Set PLACEMENT_DB_ENABLED to True to use it."},{"line_number":45,"context_line":"PLACEMENT_DB_ENABLED\u003d$(trueorfalse False PLACEMENT_DB_ENABLED)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"if is_service_enabled tls-proxy; then"},{"line_number":48,"context_line":"    PLACEMENT_SERVICE_PROTOCOL\u003d\"https\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3f79a3b5_90c96152","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":62},"updated":"2018-10-24 06:28:23.000000000","message":"This can be dropped now, no?","commit_id":"8fd3093b351f7b10d7e96e7a2387fa6c5fd37600"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d6b6f4da24db0f654911f634152764be71d02d73","unresolved":false,"context_lines":[{"line_number":40,"context_line":"PLACEMENT_UWSGI\u003d$PLACEMENT_BIN_DIR/placement-api"},{"line_number":41,"context_line":"PLACEMENT_UWSGI_CONF\u003d$PLACEMENT_CONF_DIR/placement-uwsgi.ini"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The placement service can optionally use a separate database"},{"line_number":44,"context_line":"# connection. Set PLACEMENT_DB_ENABLED to True to use it."},{"line_number":45,"context_line":"PLACEMENT_DB_ENABLED\u003d$(trueorfalse False PLACEMENT_DB_ENABLED)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"if is_service_enabled tls-proxy; then"},{"line_number":48,"context_line":"    PLACEMENT_SERVICE_PROTOCOL\u003d\"https\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3f79a3b5_1c2d6bad","line":45,"range":{"start_line":43,"start_character":0,"end_line":45,"end_character":62},"in_reply_to":"3f79a3b5_90c96152","updated":"2018-10-24 08:45:30.000000000","message":"Yes, thanks for the close reading. I think I was so focussed on getting it to work at all that I forgot to go back and clean it up to be correct.","commit_id":"8fd3093b351f7b10d7e96e7a2387fa6c5fd37600"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a6a800738ab47e922904a3c5cacc7204c31ec2cd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    sudo rm -f $(apache_site_config_for nova-placement-api)"},{"line_number":65,"context_line":"    sudo rm -f $(apache_site_config_for placement-api)"},{"line_number":66,"context_line":"    remove_uwsgi_config \"$PLACEMENT_UWSGI_CONF\" \"$PLACEMENT_UWSGI\""},{"line_number":67,"context_line":"    sudo rm -rf $PLACEMENT_AUTH_CACHE_DIR"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# _config_placement_apache_wsgi() - Set WSGI config files"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_3dfb1a7a","line":67,"updated":"2018-10-30 07:55:52.000000000","message":"Not sure why you want to remove the directory here. All other services seem to do \"rm -f $..._AUTH_CACHE_DIR/*\" which seems a bit safer and I\u0027d prefer to stick to that if only for consistency.","commit_id":"e17c60e8e16e1b33b0f33f2836f5c5eedd8a557b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ccbf1cc24e2e37a6087a6d1a94b819f6b1af92ea","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    sudo rm -f $(apache_site_config_for nova-placement-api)"},{"line_number":65,"context_line":"    sudo rm -f $(apache_site_config_for placement-api)"},{"line_number":66,"context_line":"    remove_uwsgi_config \"$PLACEMENT_UWSGI_CONF\" \"$PLACEMENT_UWSGI\""},{"line_number":67,"context_line":"    sudo rm -rf $PLACEMENT_AUTH_CACHE_DIR"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# _config_placement_apache_wsgi() - Set WSGI config files"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_53b4c5d3","line":67,"in_reply_to":"3f79a3b5_3dfb1a7a","updated":"2018-10-30 10:00:46.000000000","message":"I\u0027ll change it, but note that this is in the cleanup, the rm\u0027s that you are talking about are after the dear has been optionally created","commit_id":"e17c60e8e16e1b33b0f33f2836f5c5eedd8a557b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a6a800738ab47e922904a3c5cacc7204c31ec2cd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    iniset $conf placement user_domain_name \"$SERVICE_DOMAIN_NAME\""},{"line_number":104,"context_line":"    iniset $conf placement project_name \"$SERVICE_TENANT_NAME\""},{"line_number":105,"context_line":"    iniset $conf placement project_domain_name \"$SERVICE_DOMAIN_NAME\""},{"line_number":106,"context_line":"    # TODO(cdent): auth_strategy, which is common to see in these"},{"line_number":107,"context_line":"    # blocks is not currently used here. For the time being the"},{"line_number":108,"context_line":"    # placement api uses the auth_strategy configuration setting"},{"line_number":109,"context_line":"    # established by the nova api. This avoids, for the time, being,"},{"line_number":110,"context_line":"    # creating redundant configuration items that are just used for"},{"line_number":111,"context_line":"    # testing."},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# create_placement_conf() - Write confg"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_5d75b6fe","line":111,"range":{"start_line":106,"start_character":0,"end_line":111,"end_character":14},"updated":"2018-10-30 07:55:52.000000000","message":"Is this still correct?","commit_id":"e17c60e8e16e1b33b0f33f2836f5c5eedd8a557b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ccbf1cc24e2e37a6087a6d1a94b819f6b1af92ea","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    iniset $conf placement user_domain_name \"$SERVICE_DOMAIN_NAME\""},{"line_number":104,"context_line":"    iniset $conf placement project_name \"$SERVICE_TENANT_NAME\""},{"line_number":105,"context_line":"    iniset $conf placement project_domain_name \"$SERVICE_DOMAIN_NAME\""},{"line_number":106,"context_line":"    # TODO(cdent): auth_strategy, which is common to see in these"},{"line_number":107,"context_line":"    # blocks is not currently used here. For the time being the"},{"line_number":108,"context_line":"    # placement api uses the auth_strategy configuration setting"},{"line_number":109,"context_line":"    # established by the nova api. This avoids, for the time, being,"},{"line_number":110,"context_line":"    # creating redundant configuration items that are just used for"},{"line_number":111,"context_line":"    # testing."},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"# create_placement_conf() - Write confg"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_33ad8982","line":111,"range":{"start_line":106,"start_character":0,"end_line":111,"end_character":14},"in_reply_to":"3f79a3b5_5d75b6fe","updated":"2018-10-30 10:00:46.000000000","message":"I guess we can make it explicit now, will fix. Had been using the defaults, so as to keep conf small.","commit_id":"e17c60e8e16e1b33b0f33f2836f5c5eedd8a557b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a6a800738ab47e922904a3c5cacc7204c31ec2cd","unresolved":false,"context_lines":[{"line_number":154,"context_line":"# init_placement() - Create service user and endpoints"},{"line_number":155,"context_line":"function init_placement {"},{"line_number":156,"context_line":"    recreate_database placement"},{"line_number":157,"context_line":"    placement-manage db sync"},{"line_number":158,"context_line":"    create_placement_accounts"},{"line_number":159,"context_line":"    create_placement_cache_dir"},{"line_number":160,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_ddad4632","line":157,"updated":"2018-10-30 07:55:52.000000000","message":"This is failing in some external CIs with\n\nplacement-manage: command not found\n\nso I think that you should be using \"$PLACEMENT_BIN_DIR/placement-manage\" similar to what is done for calls to nova-manage.","commit_id":"e17c60e8e16e1b33b0f33f2836f5c5eedd8a557b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ccbf1cc24e2e37a6087a6d1a94b819f6b1af92ea","unresolved":false,"context_lines":[{"line_number":154,"context_line":"# init_placement() - Create service user and endpoints"},{"line_number":155,"context_line":"function init_placement {"},{"line_number":156,"context_line":"    recreate_database placement"},{"line_number":157,"context_line":"    placement-manage db sync"},{"line_number":158,"context_line":"    create_placement_accounts"},{"line_number":159,"context_line":"    create_placement_cache_dir"},{"line_number":160,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_b33bd933","line":157,"in_reply_to":"3f79a3b5_ddad4632","updated":"2018-10-30 10:00:46.000000000","message":"Done","commit_id":"e17c60e8e16e1b33b0f33f2836f5c5eedd8a557b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d9f73d45475e46d665d532603eb96dd6fe90079","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# cleanup_placement() - Remove residual data files, anything left over from previous"},{"line_number":63,"context_line":"# runs that a clean run would need to clean up"},{"line_number":64,"context_line":"function cleanup_placement {"},{"line_number":65,"context_line":"    sudo rm -f $(apache_site_config_for nova-placement-api)"},{"line_number":66,"context_line":"    sudo rm -f $(apache_site_config_for placement-api)"},{"line_number":67,"context_line":"    remove_uwsgi_config \"$PLACEMENT_UWSGI_CONF\" \"$PLACEMENT_UWSGI\""},{"line_number":68,"context_line":"    sudo rm -f $PLACEMENT_AUTH_CACHE_DIR/*"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3f79a3b5_87fce240","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":59},"updated":"2018-11-20 20:58:02.000000000","message":"We probably don\u0027t need this anymore right? The only thing that might hit this is grenade, but I\u0027m not sure it matters, I don\u0027t think we really support unstack anymore right?","commit_id":"d98d7e3551713e54460116447b18e1ecd13cf18d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"a4b56b4e942a04d2f2f3b1b72fe70034719e7cad","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# cleanup_placement() - Remove residual data files, anything left over from previous"},{"line_number":63,"context_line":"# runs that a clean run would need to clean up"},{"line_number":64,"context_line":"function cleanup_placement {"},{"line_number":65,"context_line":"    sudo rm -f $(apache_site_config_for nova-placement-api)"},{"line_number":66,"context_line":"    sudo rm -f $(apache_site_config_for placement-api)"},{"line_number":67,"context_line":"    remove_uwsgi_config \"$PLACEMENT_UWSGI_CONF\" \"$PLACEMENT_UWSGI\""},{"line_number":68,"context_line":"    sudo rm -f $PLACEMENT_AUTH_CACHE_DIR/*"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3f79a3b5_b9010206","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":59},"in_reply_to":"3f79a3b5_87fce240","updated":"2018-11-20 21:07:23.000000000","message":"You\u0027re right that this can probably go as it refers to the old thing, but I suspect that it was helping me at some point while I was switching back and forth: There are plenty of situations where old apache config gets left behind and really messes with repeated devstack runs.","commit_id":"d98d7e3551713e54460116447b18e1ecd13cf18d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d9f73d45475e46d665d532603eb96dd6fe90079","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    iniset $conf placement auth_strategy $PLACEMENT_AUTH_STRATEGY"},{"line_number":108,"context_line":"}"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# create_placement_conf() - Write confg"},{"line_number":111,"context_line":"function create_placement_conf {"},{"line_number":112,"context_line":"    rm -f $PLACEMENT_CONF"},{"line_number":113,"context_line":"    iniset $PLACEMENT_CONF placement_database connection `database_connection_url placement`"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"3f79a3b5_87d382d4","line":110,"range":{"start_line":110,"start_character":34,"end_line":110,"end_character":39},"updated":"2018-11-20 20:58:02.000000000","message":"nit: config","commit_id":"d98d7e3551713e54460116447b18e1ecd13cf18d"}],"stack.sh":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"73d4cafb6d32c3df4f2cf55c2f0ac7e78730e8e8","unresolved":false,"context_lines":[{"line_number":901,"context_line":"fi"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"if is_service_enabled placement; then"},{"line_number":904,"context_line":"    # placement api"},{"line_number":905,"context_line":"    stack_install_service placement"},{"line_number":906,"context_line":"    configure_placement"},{"line_number":907,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3f79a3b5_95fcf33f","line":904,"range":{"start_line":904,"start_character":6,"end_line":904,"end_character":19},"updated":"2018-10-24 06:28:23.000000000","message":"nit: Placement service","commit_id":"8fd3093b351f7b10d7e96e7a2387fa6c5fd37600"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cf3c61ec3dc9c32d93a9aeae7a47e29bd3f6b6b6","unresolved":false,"context_lines":[{"line_number":133,"context_line":"# base name of the directory from which they are installed. See"},{"line_number":134,"context_line":"# enable_python3_package to edit this variable and use_python3_for to"},{"line_number":135,"context_line":"# test membership."},{"line_number":136,"context_line":"export ENABLED_PYTHON3_PACKAGES\u003d\"nova,glance,cinder,placement,uwsgi,python-openstackclient,openstacksdk\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# Explicitly list services not to run under Python 3. See"},{"line_number":139,"context_line":"# disable_python3_package to edit this variable."}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"3f79a3b5_8d2b47e7","line":136,"updated":"2018-11-27 10:30:27.000000000","message":"I don\u0027t think that this is necessary, placement was installed with py3 for earlier revisions, too.\n\nIIUC this override is/was only needed for pkgs that don\u0027t specify their py3 compatibility properly. We should avoid adding more cruft to it and rather look into cleaning it up.","commit_id":"087edf1bcad4c65dd8eaff750a4f7edf8d177bd9"}]}