)]}'
{"lib/tls":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"68cb2ce996e1ceda05fccabf342bc7cf0493a915","unresolved":false,"context_lines":[{"line_number":227,"context_line":"function init_cert {"},{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            # Lie to let incomplete match routines work with python2"},{"line_number":231,"context_line":"            # see https://bugs.python.org/issue23239"},{"line_number":232,"context_line":"            if python3_enabled; then"},{"line_number":233,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_5e136266","line":230,"updated":"2018-10-04 22:13:45.000000000","message":"nit: I would have moved this comment to be above the else, it is a bit confusing to me to have it here. It took me a second to figure out what you were doing.","commit_id":"526c2bc482d6453582450ec820b5b16e6fda0a3a"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"45db1c06cb05fcc29d7f7b9e05905a845a31f01d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"function init_cert {"},{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            # Lie to let incomplete match routines work with python2"},{"line_number":231,"context_line":"            # see https://bugs.python.org/issue23239"},{"line_number":232,"context_line":"            if python3_enabled; then"},{"line_number":233,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_b1b2e749","line":230,"in_reply_to":"3f79a3b5_5e136266","updated":"2018-10-04 22:23:30.000000000","message":"Done","commit_id":"526c2bc482d6453582450ec820b5b16e6fda0a3a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"79ee687be160e70901856790363568c1134f5a4f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            if python3_enabled; then"},{"line_number":231,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""},{"line_number":232,"context_line":"            else"},{"line_number":233,"context_line":"                # Lie to let incomplete match routines work with python2"},{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_c3dc2e73","line":231,"updated":"2018-10-09 13:43:34.000000000","message":"Given that we still can\u0027t get a successful deployment with python2.7 due to conflicting bugs, I\u0027m thinking maybe we should switch back to this original version unconditionally, be happy that py3 works and continue with python3-first.","commit_id":"9a543a81acb808e4275765da7ff0f613109b6603"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cdbfa23106efec140d4beef9237cbb5910bfc2ac","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            if python3_enabled; then"},{"line_number":231,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""},{"line_number":232,"context_line":"            else"},{"line_number":233,"context_line":"                # Lie to let incomplete match routines work with python2"},{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_db096029","line":231,"in_reply_to":"3f79a3b5_15ad7931","updated":"2018-10-10 07:51:38.000000000","message":"Yes you are right, I was somehow thinking that it would only affect IPv6, but of course it would break all IPv4 jobs.","commit_id":"9a543a81acb808e4275765da7ff0f613109b6603"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"4f4935663acd264accba4fa368b0c7a80330c72a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            if python3_enabled; then"},{"line_number":231,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""},{"line_number":232,"context_line":"            else"},{"line_number":233,"context_line":"                # Lie to let incomplete match routines work with python2"},{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_15ad7931","line":231,"in_reply_to":"3f79a3b5_35c2f536","updated":"2018-10-09 14:36:13.000000000","message":"I guess that the problem is that if we remove the if block all jobs with python2 and tls enabled are going to fail, the new IPv6 jobs and all the current python2 jobs that are running (IIRC it means all the gates are going to fail). I know that is ugly, but with python2 deprecation coming soon in 2020 I don\u0027t see that python community is going to fix this, so we have to keep the hack. Thoughts?","commit_id":"9a543a81acb808e4275765da7ff0f613109b6603"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a9ae41a9f403f0d19cbdde8fc7db79d2f5da284","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            if python3_enabled; then"},{"line_number":231,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""},{"line_number":232,"context_line":"            else"},{"line_number":233,"context_line":"                # Lie to let incomplete match routines work with python2"},{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_35c2f536","line":231,"in_reply_to":"3f79a3b5_958ae910","updated":"2018-10-09 14:25:00.000000000","message":"Yes, exactly, just replacing this whole block by this single line. Sorry for the unclear wording.","commit_id":"9a543a81acb808e4275765da7ff0f613109b6603"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"9cf4bbd2b373fffa016ff8404d874a857a4870b0","unresolved":false,"context_lines":[{"line_number":228,"context_line":"    if [[ ! -r $DEVSTACK_CERT ]]; then"},{"line_number":229,"context_line":"        if [[ -n \"$TLS_IP\" ]]; then"},{"line_number":230,"context_line":"            if python3_enabled; then"},{"line_number":231,"context_line":"                TLS_IP\u003d\"IP:$TLS_IP\""},{"line_number":232,"context_line":"            else"},{"line_number":233,"context_line":"                # Lie to let incomplete match routines work with python2"},{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3f79a3b5_958ae910","line":231,"in_reply_to":"3f79a3b5_c3dc2e73","updated":"2018-10-09 14:22:35.000000000","message":"sorry, you mean using TLS_IP\u003d\"IP:$TLS_IP\" by default?","commit_id":"9a543a81acb808e4275765da7ff0f613109b6603"}]}