)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c780441e9a4bc919851f89e988d45ae41f3b9b12","unresolved":false,"context_lines":[{"line_number":990,"context_line":"    fi"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    # nova-consoleauth always runs globally"},{"line_number":993,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":994,"context_line":"        run_process n-cauth \"$NOVA_BIN_DIR/nova-consoleauth --config-file $api_cell_conf\""},{"line_number":995,"context_line":"    fi"},{"line_number":996,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_5e09ac2f","line":993,"updated":"2018-10-10 20:51:37.000000000","message":"Couldn\u0027t there be an else to run it but enable the workaround? Or do you not want to run it so we get coverage in both cases?","commit_id":"7bd41fdc2f32ea68e3a49d8eaf4480a42f88b785"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8e6a94246e0edd803994a3bf860619b2eb4af7dc","unresolved":false,"context_lines":[{"line_number":990,"context_line":"    fi"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    # nova-consoleauth always runs globally"},{"line_number":993,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":994,"context_line":"        run_process n-cauth \"$NOVA_BIN_DIR/nova-consoleauth --config-file $api_cell_conf\""},{"line_number":995,"context_line":"    fi"},{"line_number":996,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_c472ceb0","line":993,"in_reply_to":"3f79a3b5_5e09ac2f","updated":"2018-10-10 20:57:19.000000000","message":"Oh I guess you do that in the change on top of this.","commit_id":"7bd41fdc2f32ea68e3a49d8eaf4480a42f88b785"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ee099746827d52aa6e8ef7aa970dd8038e9627cd","unresolved":false,"context_lines":[{"line_number":990,"context_line":"    fi"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    # nova-consoleauth always runs globally"},{"line_number":993,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":994,"context_line":"        run_process n-cauth \"$NOVA_BIN_DIR/nova-consoleauth --config-file $api_cell_conf\""},{"line_number":995,"context_line":"    fi"},{"line_number":996,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_e42fca3b","line":993,"in_reply_to":"3f79a3b5_c472ceb0","updated":"2018-10-10 21:13:21.000000000","message":"Right, wanted to run without it to prove that everything still works without it running. If we had had that coverage, it would have caught the mistake in thinking it wasn\u0027t required.\n\nAnd correct, I used the DNM change to make sure the workaround works too.\n\nMy plan was to remove the WIP from this and merge it, then make the changes to remove non cells v1 usage of nova-consoleauth on master.\n\nThat way, we\u0027ll be covering the cells v1 and no nova-consoleauth cases in the gate. The only case that won\u0027t be covered is the workaround case, but after we remove the nova-consoleauth usage from master, the workaround case will only be valid on the stable/rocky branch. And I\u0027m not sure if/how to cover all 3 cases on stable/rocky (cells v1 + nova-consoleauth, cells v2 without it, cells v2 + nova-consoleauth via [workarounds]).","commit_id":"7bd41fdc2f32ea68e3a49d8eaf4480a42f88b785"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"baf48783c4b427ab583419c042866c100109189f","unresolved":false,"context_lines":[{"line_number":990,"context_line":"    fi"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    # nova-consoleauth always runs globally"},{"line_number":993,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":994,"context_line":"        run_process n-cauth \"$NOVA_BIN_DIR/nova-consoleauth --config-file $api_cell_conf\""},{"line_number":995,"context_line":"    fi"},{"line_number":996,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_0aa52fa0","line":993,"in_reply_to":"3f79a3b5_e42fca3b","updated":"2018-10-10 23:03:08.000000000","message":"You could potentially leverage the nova-next job specifically on stable/rocky to do something differently, like enabling the workaround option if necessary.","commit_id":"7bd41fdc2f32ea68e3a49d8eaf4480a42f88b785"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"66d55f22c7fa7e46d50ee03f8bdebbf3490eb035","unresolved":false,"context_lines":[{"line_number":981,"context_line":"        run_process n-api-meta \"$NOVA_BIN_DIR/uwsgi --procname-prefix nova-api-meta --ini $NOVA_METADATA_UWSGI_CONF\""},{"line_number":982,"context_line":"    fi"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    # nova-consoleauth always runs globally"},{"line_number":985,"context_line":"    if is_service_enabled n-cell; then"},{"line_number":986,"context_line":"        run_process n-cauth \"$NOVA_BIN_DIR/nova-consoleauth --config-file $api_cell_conf\""},{"line_number":987,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_23f411cd","line":984,"updated":"2018-12-14 14:28:26.000000000","message":"I think this comment should contain some text similar to the commit message.","commit_id":"db3f4bc762333f6a3944ccdef6983e3f3ab14f86"}]}