)]}'
{"functions-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7c7cabd89ab9f396ee0df2456b689c8fd1aa9ba7","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"function enable_plugin {"},{"line_number":1569,"context_line":"    local name\u003d$1"},{"line_number":1570,"context_line":"    local url\u003d$2"},{"line_number":1571,"context_line":"    local branch\u003d${3:-$TARGET_BRANCH}"},{"line_number":1572,"context_line":"    if is_plugin_enabled $name; then"},{"line_number":1573,"context_line":"        die $LINENO \"Plugin attempted to be enabled twice: ${name} ${url} ${branch}\""},{"line_number":1574,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_d77448cf","line":1571,"updated":"2018-10-16 20:00:01.000000000","message":"This seems fairly sensible ... but then also does break the status quo from when the change was originally added.  I had a look at the old spec [1] and it wasn\u0027t explicitly discussed.\n\nI think the problem at this point is that it effectively an external interface ... I have no idea if people are installing a plugin that always lives on master on all their branches and we\u0027d break them, or indeed if their plugin comes from branches named differently to TARGET_BRANCH, etc.\n\nSo I think to be 100% safe, we could probably create a simple wrapper function that sets the branch to TARGET_BRANCH, e.g. follows the current branch.  \"enable_plugin_for_current_branch\" is maybe too long but that\u0027s the idea...\n\n[1] https://review.openstack.org/#/c/137054/9/specs/devstack/devstack-external-plugins.rst","commit_id":"13b2377e610bdccb3b2ef6e12b5560418adc7671"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"4eed8a0045ddace404fd6f3387f9e0ec944e5a1b","unresolved":false,"context_lines":[{"line_number":1568,"context_line":"function enable_plugin {"},{"line_number":1569,"context_line":"    local name\u003d$1"},{"line_number":1570,"context_line":"    local url\u003d$2"},{"line_number":1571,"context_line":"    local branch\u003d${3:-$TARGET_BRANCH}"},{"line_number":1572,"context_line":"    if is_plugin_enabled $name; then"},{"line_number":1573,"context_line":"        die $LINENO \"Plugin attempted to be enabled twice: ${name} ${url} ${branch}\""},{"line_number":1574,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_a607fd17","line":1571,"in_reply_to":"3f79a3b5_d77448cf","updated":"2018-10-18 03:04:02.000000000","message":"Done","commit_id":"13b2377e610bdccb3b2ef6e12b5560418adc7671"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5fae8fa047c3b658ed6b476222569b2dc2378ed1","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"function enable_plugin_for_current_branch {"},{"line_number":1586,"context_line":"    local name\u003d$1"},{"line_number":1587,"context_line":"    local url\u003d$2"},{"line_number":1588,"context_line":"    local branch\u003d$TARGET_BRANCH"},{"line_number":1589,"context_line":"    enable_plugin $name $url $branch"},{"line_number":1590,"context_line":"}"},{"line_number":1591,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_bb1b8f6d","line":1588,"updated":"2018-10-18 09:44:47.000000000","message":"To me this looks redundant. Calling\n\nenable_plugin_for_current_branch \u003cname\u003e \u003curl\u003e\n\nsomewhere would seem to be identical to calling\n\nenable_plugin \u003cname\u003e \u003curl\u003e $TARGET_BRANCH\n\nwhere the latter looks even easier to understand to me.","commit_id":"9014b3e6ca218341da7796c08b2aa2e1bb96ff5b"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"28a1b304fd9e7cb101e782347072477805769135","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"function enable_plugin_for_current_branch {"},{"line_number":1586,"context_line":"    local name\u003d$1"},{"line_number":1587,"context_line":"    local url\u003d$2"},{"line_number":1588,"context_line":"    local branch\u003d$TARGET_BRANCH"},{"line_number":1589,"context_line":"    enable_plugin $name $url $branch"},{"line_number":1590,"context_line":"}"},{"line_number":1591,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_be35abde","line":1588,"in_reply_to":"3f79a3b5_bb1b8f6d","updated":"2018-10-19 00:03:52.000000000","message":"Make sense. This doesn\u0027t make it better. I will drop this patch.","commit_id":"9014b3e6ca218341da7796c08b2aa2e1bb96ff5b"}]}