)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"4ff84df07cdf19c61f8553c9ccbcfc4a36a0538c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Fedora 29 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fedora 29 has just released and it had not support on devstack"},{"line_number":10,"context_line":"installation, support were only for fedora 27 and 29."},{"line_number":11,"context_line":"Running the stack.sh script threw an error that it has not been"},{"line_number":12,"context_line":"tested on fedora 29, and asked to run it with FORCE\u003dyes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f8eff0ae","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":13},"updated":"2018-11-12 16:29:39.000000000","message":"s/has just/was just/","commit_id":"b789ea8dd6a6b9c1fedcd9ce2e74ebd8b65eef9e"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"4ff84df07cdf19c61f8553c9ccbcfc4a36a0538c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Fedora 29 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fedora 29 has just released and it had not support on devstack"},{"line_number":10,"context_line":"installation, support were only for fedora 27 and 29."},{"line_number":11,"context_line":"Running the stack.sh script threw an error that it has not been"},{"line_number":12,"context_line":"tested on fedora 29, and asked to run it with FORCE\u003dyes."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d8f4748a","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":52},"updated":"2018-11-12 16:29:39.000000000","message":"Do you mean 28 here instead of 29?\n\nSuggest rewording to \"only Fedora 27 and 28 are supported\".","commit_id":"b789ea8dd6a6b9c1fedcd9ce2e74ebd8b65eef9e"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"4ff84df07cdf19c61f8553c9ccbcfc4a36a0538c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Fedora 29 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fedora 29 has just released and it had not support on devstack"},{"line_number":10,"context_line":"installation, support were only for fedora 27 and 29."},{"line_number":11,"context_line":"Running the stack.sh script threw an error that it has not been"},{"line_number":12,"context_line":"tested on fedora 29, and asked to run it with FORCE\u003dyes."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_182c2cfe","line":10,"range":{"start_line":9,"start_character":35,"end_line":10,"end_character":12},"updated":"2018-11-12 16:29:39.000000000","message":"s/had not support on devstack installation/installation of devstack is not supported on it/","commit_id":"b789ea8dd6a6b9c1fedcd9ce2e74ebd8b65eef9e"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"4ff84df07cdf19c61f8553c9ccbcfc4a36a0538c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Running the stack.sh script threw an error that it has not been"},{"line_number":12,"context_line":"tested on fedora 29, and asked to run it with FORCE\u003dyes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change add Fedora 29 as a supported distro version."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I29b688681b019a3240837b3b592d48da7a9353da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_382fa8f4","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":15},"updated":"2018-11-12 16:29:39.000000000","message":"s/add/adds/","commit_id":"b789ea8dd6a6b9c1fedcd9ce2e74ebd8b65eef9e"}],"stack.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"70391a06700601b3ed6e766d40e96b0ed86ce2e5","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"# Warn users who aren\u0027t on an explicitly supported distro, but allow them to"},{"line_number":223,"context_line":"# override check and attempt installation with ``FORCE\u003dyes ./stack``"},{"line_number":224,"context_line":"if [[ ! ${DISTRO} \u003d~ (xenial|artful|bionic|stretch|jessie|f27|f28|f29|opensuse-42.3|opensuse-15.0|opensuse-tumbleweed|rhel7) ]]; then"},{"line_number":225,"context_line":"    echo \"WARNING: this script has not been tested on $DISTRO\""},{"line_number":226,"context_line":"    if [[ \"$FORCE\" !\u003d \"yes\" ]]; then"},{"line_number":227,"context_line":"        die $LINENO \"If you wish to run this script anyway run with FORCE\u003dyes\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_c9102150","line":224,"updated":"2018-11-13 09:34:31.000000000","message":"It seems that f27 is outdated now, so we should drop it at the same time, see [0]. It would also be good to add some test job for the new release.\n\n[0] https://fedoraproject.org/wiki/Releases","commit_id":"b789ea8dd6a6b9c1fedcd9ce2e74ebd8b65eef9e"}]}