)]}'
{"id":"openstack%2Fdevstack~620624","triplet_id":"openstack%2Fdevstack~stable%2Fqueens~Ib29d3f5f18533115b9c51e27b373e92fc0a28d1a","project":"openstack/devstack","branch":"stable/queens","topic":"bp/websocket-proxy-to-host-security-stable/queens","hashtags":[],"change_id":"Ib29d3f5f18533115b9c51e27b373e92fc0a28d1a","subject":"nova: add support for TLS between novnc proxy \u0026 compute nodes","status":"MERGED","created":"2018-11-28 15:08:27.000000000","updated":"2018-12-07 13:25:03.000000000","submitted":"2018-12-07 13:25:03.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"620624-1544189103532-03b03b2d","meta_rev_id":"ca3158fe3092bf23fc8919130b2fba71e55baff0","_number":620624,"virtual_id_number":620624,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2018-11-28 17:36:16.000000000","_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"date":"2018-11-28 16:18:58.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2018-11-28 16:12:16.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2018-11-28 15:10:34.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":2,"date":"2018-12-07 13:25:03.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2018-11-29 03:07:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-12-06 19:46:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"date":"2018-11-28 15:08:27.000000000","_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-12-06 19:46:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-11-28 15:08:27.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2018-11-28 16:12:16.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-11-28 16:18:58.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-11-28 17:36:16.000000000","updated_by":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-11-29 03:07:17.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2018-12-06 19:46:46.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2018-12-07 13:25:03.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1a474a0ac01f3994bb418d77933a7482cf582d58","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-11-28 15:08:27.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"75efba70fa3c8d86c6d71a82013f1e9d5c900326","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2018-11-28 15:10:34.000000000","message":"Patch Set 1:\n\nThis is needed by https://review.openstack.org/#/c/513160/ to enable testing of this code in the nova-next job. Apparently turning this testing on just missed the Queens GA, but the dependent nova change (and feature) was implemented in Queens so it would be good to have test coverage for that code.","accounts_in_message":[],"_revision_number":1},{"id":"8cc2c07476a5c520cb50a646a06d035edb0fdade","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2018-11-28 16:12:16.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/devstack/24/620624/1/check/tempest-dsvm-full-xenial/d498d92/ : SUCCESS in 1h 03m 24s","accounts_in_message":[],"_revision_number":1},{"id":"b224e42eb06766a1b4dff44fc350c68dfe7f5cbd","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2018-11-28 16:18:58.000000000","message":"Patch Set 1:\n\nTesting succeeded on ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenail-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/620624/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/2b0d460 : SUCCESS in 1h 10m 02s","accounts_in_message":[],"_revision_number":1},{"id":"16c3055e55681b43be403e6c10983b2599b8ee5e","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2018-11-28 17:36:16.000000000","message":"Patch Set 1:\n\nBuild failed.  To recheck use \u0027xenserver: recheck\u0027.  For 3rd party ci contact info: https://wiki.openstack.org/wiki/ThirdPartySystems\n\n- dsvm-tempest-neutron-network http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/24/620624/1/check/dsvm-tempest-neutron-network/8375522 : FAILURE in 2h 27m 09s","accounts_in_message":[],"_revision_number":1},{"id":"dc2ba70cc56faf6acc53a648f3e6db727e03da4c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-11-28 18:50:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/24/620624/1/check/tempest-full/e418916/ : SUCCESS in 1h 28m 38s\n- neutron-grenade http://logs.openstack.org/24/620624/1/check/neutron-grenade/ba12b1d/ : SUCCESS in 56m 39s\n- tempest-full-py3 http://logs.openstack.org/24/620624/1/check/tempest-full-py3/1cd1e13/ : SUCCESS in 1h 16m 50s\n- build-openstack-sphinx-docs http://logs.openstack.org/24/620624/1/check/build-openstack-sphinx-docs/ad5c189/html/ : SUCCESS in 5m 03s\n- devstack http://logs.openstack.org/24/620624/1/check/devstack/b91213a/ : SUCCESS in 43m 57s\n- devstack-multinode http://logs.openstack.org/24/620624/1/check/devstack-multinode/e07408a/ : SUCCESS in 44m 25s\n- openstack-tox-bashate http://logs.openstack.org/24/620624/1/check/openstack-tox-bashate/f528c5e/ : SUCCESS in 20m 50s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/24/620624/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/b9ae52c/ : SUCCESS in 44m 26s (non-voting)\n- swift-dsvm-functional http://logs.openstack.org/24/620624/1/check/swift-dsvm-functional/7d6bcc5/ : SUCCESS in 25m 34s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/24/620624/1/check/neutron-grenade-multinode/0a31f5d/ : SUCCESS in 1h 25m 45s\n- neutron-tempest-linuxbridge http://logs.openstack.org/24/620624/1/check/neutron-tempest-linuxbridge/aea20e0/ : SUCCESS in 1h 11m 17s","accounts_in_message":[],"_revision_number":1},{"id":"dcf760eaacbbc09381cdc78f1de599b17c142e34","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2018-11-29 03:07:17.000000000","message":"Patch Set 1: Code-Review+2\n\nthanks","accounts_in_message":[],"_revision_number":1},{"id":"69aa4a32b6bb0e28ddb37e0c63b00a00a7cf5e86","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2018-12-06 19:46:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"508393b5c2235a547131e41ab71008b4f8804aa8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-07 02:42:00.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"46fb0fe77603b331637941064ee5925a32e90103","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-07 13:25:03.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"8578aec0fcf1adbd2f3def8c5f575ff5d7d98907","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-07 13:25:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/24/620624/1/gate/tempest-full/b7ace01/ : SUCCESS in 1h 26m 29s\n- neutron-grenade http://logs.openstack.org/24/620624/1/gate/neutron-grenade/827e74f/ : SUCCESS in 45m 48s\n- tempest-full-py3 http://logs.openstack.org/24/620624/1/gate/tempest-full-py3/17a5aa1/ : SUCCESS in 1h 07m 11s\n- build-openstack-sphinx-docs http://logs.openstack.org/24/620624/1/gate/build-openstack-sphinx-docs/5c82174/html/ : SUCCESS in 4m 38s\n- devstack http://logs.openstack.org/24/620624/1/gate/devstack/02213ab/ : SUCCESS in 23m 02s\n- openstack-tox-bashate http://logs.openstack.org/24/620624/1/gate/openstack-tox-bashate/c24790c/ : SUCCESS in 4m 16s\n- neutron-grenade-multinode http://logs.openstack.org/24/620624/1/gate/neutron-grenade-multinode/8d1b91a/ : SUCCESS in 1h 06m 18s\n- neutron-tempest-linuxbridge http://logs.openstack.org/24/620624/1/gate/neutron-tempest-linuxbridge/3d61f63/ : SUCCESS in 1h 17m 43s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fad20e605ca4e611df9a458e3b7ccbe130587c76","revisions":{"fad20e605ca4e611df9a458e3b7ccbe130587c76":{"kind":"REWORK","_number":1,"created":"2018-11-28 15:08:27.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/24/620624/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/24/620624/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/24/620624/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/24/620624/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/24/620624/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/24/620624/1"}}},"commit":{"parents":[{"commit":"97f88fc4e25c0e4b0b054becbd9d3fe0b5eca451","subject":"Add the project under test to LIBS_FROM_GIT","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/97f88fc4e25c0e4b0b054becbd9d3fe0b5eca451"}]}],"author":{"name":"Daniel P. Berrange","email":"berrange@redhat.com","date":"2016-11-10 13:03:32.000000000","tz":0},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-11-28 15:08:27.000000000","tz":0},"subject":"nova: add support for TLS between novnc proxy \u0026 compute nodes","message":"nova: add support for TLS between novnc proxy \u0026 compute nodes\n\nNova is gaining the ability to run TLS over the connection between the\nnovnc proxy service and the QEMU/KVM compute node VNC server.\n\nThis adds a new config param - \u0027NOVA_CONSOLE_PROXY_COMPUTE_TLS\u003dTrue\u0027 -\nwhich instructs devstack to configure libvirt/QEMU to enable TLS for the\nVNC server, and to configure the novncproxy to use TLS when connecting.\nNB this use of TLS is distinct from use of TLS for the public facing API\ncontrolled by USE_SSL, they can be enabled independently.\n\nThis is done in a generic manner so that it is easy to extend to cover\nuse of TLS with the SPICE and serial console proxy services too.\n\nChange-Id: Ib29d3f5f18533115b9c51e27b373e92fc0a28d1a\nDepends-on: I9cc9a380500715e60bd05aa5c29ee46bc6f8d6c2\nImplements bp: websocket-proxy-to-host-security\n(cherry picked from commit e9870eb18d19dbb807d4d312cf4aead23c6f8f40)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fad20e605ca4e611df9a458e3b7ccbe130587c76"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/fad20e605ca4e611df9a458e3b7ccbe130587c76"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}