)]}'
{"inc/python":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35401f9055dd8cf2577686c95a4aa570b0c16133","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                # in their classifier"},{"line_number":277,"context_line":"                echo \"Check python version for : $package_dir\""},{"line_number":278,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":279,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":280,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":281,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":282,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3f79a3b5_55e5fbcd","line":279,"updated":"2018-12-05 19:51:20.000000000","message":"Interestingly I expected to see this show up for swift:\n\nhttp://logs.openstack.org/15/622415/3/check/tempest-full-py3/74c1fff/controller/logs/devstacklog.txt.gz\n\nBut it doesn\u0027t. I guess we just don\u0027t install swift at all on py3 jobs.","commit_id":"6a828b7cc3bf98e40e9ffa28b7e65a25cd35bf16"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6fc19aeb75261a0d2add9bd0f4fc07749182b471","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                echo \"Check python version for : $package_dir\""},{"line_number":278,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":279,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":280,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":281,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":282,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":283,"context_line":"                    cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_4764804e","line":280,"updated":"2018-12-18 13:05:39.000000000","message":"If the above \"if\" branch is not taken, don\u0027t we now always take this branch, making the following \"elif\" and \"else\" branches obsolete?","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"aff501ea6654591c9da7c1a6c110320e72c6c7d4","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                echo \"Check python version for : $package_dir\""},{"line_number":278,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":279,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":280,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":281,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":282,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":283,"context_line":"                    cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f769fc5_47603902","line":280,"in_reply_to":"3f79a3b5_4764804e","updated":"2019-01-02 18:07:26.000000000","message":"Yes, I think you are correct.","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8f6ead4ec86927ae29e26c5d6048af643848a41b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":279,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":280,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":281,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":282,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":283,"context_line":"                    cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":284,"context_line":"                elif [[ -d \"$package_dir\" ]]; then"},{"line_number":285,"context_line":"                    python_versions\u003d$(get_python_versions_for_package $package_dir)"},{"line_number":286,"context_line":"                    if [[ $python_versions \u003d~ $PYTHON3_VERSION ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dfd5e7cf_afc56390","line":283,"range":{"start_line":281,"start_character":0,"end_line":283,"end_character":63},"updated":"2019-01-08 19:54:52.000000000","message":"In manila -- where we\u0027ve inherited some \"interesting\" customized legacy tempest jobs -- we discovered that with this patch, with python3 enabled for all services running in our devstack jobs, and with \u0027USE_PYTHON3\u003dtrue\u0027 in devstack\u0027s local conf, PYTHON3_VERSION was not set. So when we thought we were pip installing with python3 we were really just running \"pip\" (get_pip_version with null $1).\n\nI\u0027m working around this atm by explicitly setting PYTHON3_VERSION in local.conf and we plan to convert the legacy jobs to pure zuulv3 and quit (apparently) skipping the python version discovery code in devstack.\n\nNot sure it\u0027s worth putting defensive code here for nil PYTHON3_VERSION or not.  For PYTHON2_VERSION the issue is more subtle since current default for pip install is python 2.","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4c44c7ed957aae228da4fcfd4e517ebcfe526b33","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":279,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":280,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":281,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":282,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":283,"context_line":"                    cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":284,"context_line":"                elif [[ -d \"$package_dir\" ]]; then"},{"line_number":285,"context_line":"                    python_versions\u003d$(get_python_versions_for_package $package_dir)"},{"line_number":286,"context_line":"                    if [[ $python_versions \u003d~ $PYTHON3_VERSION ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"dfd5e7cf_75f0aeca","line":283,"range":{"start_line":281,"start_character":0,"end_line":283,"end_character":63},"in_reply_to":"dfd5e7cf_afc56390","updated":"2019-01-08 21:36:11.000000000","message":"That extra protection sounds like a good idea for a follow-up patch.","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"}],"stackrc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0202965c560e1e616b3f9c44fcfb31995e4c6441","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Explicitly list services not to run under Python 3. See"},{"line_number":133,"context_line":"# disable_python3_package to edit this variable."},{"line_number":134,"context_line":"export DISABLED_PYTHON3_PACKAGES\u003d\"swift\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# When Python 3 is supported by an application, adding the specific"},{"line_number":137,"context_line":"# version of Python 3 to this variable will install the app using that"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_754ef7c3","line":134,"updated":"2018-12-05 19:56:41.000000000","message":"Apparently this doesn\u0027t even matter, at least not in the tempest-full-py3 job, because swift is disabled in the job definition:\n\nhttps://github.com/openstack/tempest/blob/master/.zuul.yaml#L166\n\nThat\u0027s not true in the grenade-py3 job though:\n\nhttp://logs.openstack.org/15/622415/3/check/grenade-py3/341fea7/logs/new/local.conf.txt.gz\n\nENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,ceilometer-acentral,ceilometer-acompute,ceilometer-alarm-evaluator,ceilometer-alarm-notifier,ceilometer-anotification,ceilometer-api,ceilometer-collector,cinder,dstat,etcd3,g-api,g-reg,key,mysql,n-api,n-api-meta,n-cauth,n-cond,n-cpu,n-novnc,n-obj,n-sch,peakmem_tracker,placement-api,q-agt,q-dhcp,q-l3,q-meta,q-metering,q-svc,rabbit,s-account,s-container,s-object,s-proxy,tempest\n\nand ta-da! it\u0027s hitting the filter code:\n\nhttp://logs.openstack.org/15/622415/3/check/grenade-py3/341fea7/logs/grenade.sh.txt.gz#_2018-12-05_16_34_36_614\n\n2018-12-05 16:34:36.611 | Check python version for : /opt/stack/new/swift\n2018-12-05 16:34:36.614 | Explicitly using 2.7 version to install /opt/stack/new/swift based on DISABLED_PYTHON3_PACKAGES","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"76013e34791eeca573554ced6e48553be656e5b0","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Explicitly list services not to run under Python 3. See"},{"line_number":133,"context_line":"# disable_python3_package to edit this variable."},{"line_number":134,"context_line":"export DISABLED_PYTHON3_PACKAGES\u003d\"swift\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# When Python 3 is supported by an application, adding the specific"},{"line_number":137,"context_line":"# version of Python 3 to this variable will install the app using that"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_505509ec","line":134,"in_reply_to":"3f79a3b5_754ef7c3","updated":"2018-12-05 20:16:08.000000000","message":"Right, I added this to get the grenade job to pass.","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"44d09bcdbec27c890ed568c45b9f9160f4496fac","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"# Explicitly list services not to run under Python 3. See"},{"line_number":133,"context_line":"# disable_python3_package to edit this variable."},{"line_number":134,"context_line":"export DISABLED_PYTHON3_PACKAGES\u003d\"swift\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# When Python 3 is supported by an application, adding the specific"},{"line_number":137,"context_line":"# version of Python 3 to this variable will install the app using that"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3f79a3b5_9d2732b0","line":134,"in_reply_to":"3f79a3b5_754ef7c3","updated":"2018-12-06 08:11:18.000000000","message":"yeah tempest-full-py3 does not run swift test.","commit_id":"3db8c4bbb5963777c0702811319329758e4d134d"}],"tests/test_python.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d260b38245e0af0bfff69470288346d854f6d67","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Initialize variables manipulated by functions under test."},{"line_number":15,"context_line":"export DISABLED_PYTHON3_PACKAGES\u003d\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"assert_true \"should be enabled by defeault\" python3_enabled_for testpackage1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"assert_false \"should not be disabled yet\" python3_disabled_for testpackage2"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_55e2db00","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":42},"updated":"2018-12-05 19:47:35.000000000","message":"default","commit_id":"6a828b7cc3bf98e40e9ffa28b7e65a25cd35bf16"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"409daac7cf03c312447ad27ab4b58e6f6942d967","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Initialize variables manipulated by functions under test."},{"line_number":15,"context_line":"export DISABLED_PYTHON3_PACKAGES\u003d\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"assert_true \"should be enabled by defeault\" python3_enabled_for testpackage1"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"assert_false \"should not be disabled yet\" python3_disabled_for testpackage2"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_f5876709","line":17,"range":{"start_line":17,"start_character":34,"end_line":17,"end_character":42},"in_reply_to":"3f79a3b5_55e2db00","updated":"2018-12-05 19:48:45.000000000","message":"Done","commit_id":"6a828b7cc3bf98e40e9ffa28b7e65a25cd35bf16"}]}