)]}'
{"lib/tls":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"480a628fb42e82432fff6b880c5498a2ebf3c03b","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# Starts the TLS proxy for the given IP/ports"},{"line_number":508,"context_line":"# start_tls_proxy service-name front-host front-port back-host back-port"},{"line_number":509,"context_line":"function start_tls_proxy {"},{"line_number":510,"context_line":"    local b_service\u003d\"$1-tls-proxy\""},{"line_number":511,"context_line":"    local f_host\u003d$2"},{"line_number":512,"context_line":"    local f_port\u003d$3"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_8931a259","line":509,"range":{"start_line":509,"start_character":9,"end_line":509,"end_character":24},"updated":"2018-12-13 13:45:20.000000000","message":"I wonder if we\u0027re even hitting this code, because for nova, this is only called if NOVA_USE_MOD_WSGI\u003dFalse (it defaults to true) and if the tls-proxy service is enabled (which it\u0027s not by default in stackrc). I think we only get tls-proxy enabled by default, if at all, when using devstack-gate for legacy jobs:\n\nhttps://github.com/openstack-infra/devstack-gate/blob/d2bd6faf5ecffbebe8eb721b7fb1bc366ca4bd9a/roles/test-matrix/files/features.yaml#L204\n\nWhich would exclude the tempest-full* jobs since those are zuulv3 now.","commit_id":"2d5d50e6d8c1dc1f69bf5a0cbc0790325da89aba"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ad4021d845ba6f90ab0256b5e4163b75e9aedd9a","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# Starts the TLS proxy for the given IP/ports"},{"line_number":508,"context_line":"# start_tls_proxy service-name front-host front-port back-host back-port"},{"line_number":509,"context_line":"function start_tls_proxy {"},{"line_number":510,"context_line":"    local b_service\u003d\"$1-tls-proxy\""},{"line_number":511,"context_line":"    local f_host\u003d$2"},{"line_number":512,"context_line":"    local f_port\u003d$3"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_a9781ef6","line":509,"range":{"start_line":509,"start_character":9,"end_line":509,"end_character":24},"in_reply_to":"3f79a3b5_8931a259","updated":"2018-12-13 13:47:50.000000000","message":"Looking at a recent tempest-full run, it looks like that job explicitly enables tls-proxy:\n\nhttp://logs.openstack.org/16/624716/2/check/tempest-full/5943d1e/controller/logs/local_conf.txt\n\nBut *not* NOVA_USE_MOD_WSGI so I\u0027m not sure that we\u0027re using this code.","commit_id":"2d5d50e6d8c1dc1f69bf5a0cbc0790325da89aba"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"392c0d01a2ec519c57ff53bf6ea400a9396a27a8","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"# Starts the TLS proxy for the given IP/ports"},{"line_number":508,"context_line":"# start_tls_proxy service-name front-host front-port back-host back-port"},{"line_number":509,"context_line":"function start_tls_proxy {"},{"line_number":510,"context_line":"    local b_service\u003d\"$1-tls-proxy\""},{"line_number":511,"context_line":"    local f_host\u003d$2"},{"line_number":512,"context_line":"    local f_port\u003d$3"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_84c3c731","line":509,"range":{"start_line":509,"start_character":9,"end_line":509,"end_character":24},"in_reply_to":"3f79a3b5_a9781ef6","updated":"2018-12-13 14:22:58.000000000","message":"This code isn\u0027t used directly, but write_uwsgi_config from lib/apache also generates some snippets that ProxyPass the corresponding locations like \"/compute\" to the correct unix socket.\n\nThough actually I\u0027m not sure whether the SetEnv takes effect on those or might need to be moved outside of the VirtualHost maybe.","commit_id":"2d5d50e6d8c1dc1f69bf5a0cbc0790325da89aba"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dea4a352957672ea39c1cc163f3ee0b27f241b1d","unresolved":false,"context_lines":[{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    # Disable KeepAlive to fix bug #1630664 a.k.a the"},{"line_number":541,"context_line":"    # (\u0027Connection aborted.\u0027, BadStatusLine(\"\u0027\u0027\",)) error"},{"line_number":542,"context_line":"    KeepAlive Off"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    # This increase in allowed request header sizes is required"},{"line_number":545,"context_line":"    # for swift functional testing to work with tls enabled. It is 2 bytes"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_89052210","line":542,"updated":"2018-12-13 13:13:56.000000000","message":"I wonder if this should be:\n\nSetEnv proxy-nokeepalive 1\n\nBecause we still see this a ton:\n\nhttp://status.openstack.org/elastic-recheck/#1763070","commit_id":"2d5d50e6d8c1dc1f69bf5a0cbc0790325da89aba"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"392c0d01a2ec519c57ff53bf6ea400a9396a27a8","unresolved":false,"context_lines":[{"line_number":539,"context_line":""},{"line_number":540,"context_line":"    # Disable KeepAlive to fix bug #1630664 a.k.a the"},{"line_number":541,"context_line":"    # (\u0027Connection aborted.\u0027, BadStatusLine(\"\u0027\u0027\",)) error"},{"line_number":542,"context_line":"    KeepAlive Off"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    # This increase in allowed request header sizes is required"},{"line_number":545,"context_line":"    # for swift functional testing to work with tls enabled. It is 2 bytes"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_e4207b08","line":542,"in_reply_to":"3f79a3b5_89052210","updated":"2018-12-13 14:22:58.000000000","message":"As commented on IRC, I\u0027m fine to add that, too, but in a dedicated patch so that we can judge the effect of each change separately.","commit_id":"2d5d50e6d8c1dc1f69bf5a0cbc0790325da89aba"}]}