)]}'
{"lib/lvm":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4306f1a8fb2abcb8fbd2a84e9d57e9ebffecf4ac","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Only create if the file doesn\u0027t already exists"},{"line_number":101,"context_line":"        [[ -f $backing_file ]] || truncate -s $size $backing_file"},{"line_number":102,"context_line":"        local vg_dev"},{"line_number":103,"context_line":"        vg_dev\u003d`sudo losetup -f --show --direct-io\u003don $backing_file`"},{"line_number":104,"context_line":"        echo \u0027Dumping loops:\u0027"},{"line_number":105,"context_line":"        sudo losetup"},{"line_number":106,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_46359b43","line":103,"updated":"2018-12-14 15:22:16.000000000","message":"Is it going to be this easy to enable this? In nova we have a utility method to determine if we can use O_DIRECT:\n\nhttps://github.com/openstack/nova/blob/5ca357c100b15341001bff1bba663c36bb13d5a8/nova/privsep/utils.py#L35","commit_id":"74da77768f1e7cde13bc4a60d8337d113208ddc6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b04c092817e959e255d17c360b1acee4c2331bc3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Only create if the file doesn\u0027t already exists"},{"line_number":101,"context_line":"        [[ -f $backing_file ]] || truncate -s $size $backing_file"},{"line_number":102,"context_line":"        local vg_dev"},{"line_number":103,"context_line":"        vg_dev\u003d`sudo losetup -f --show --direct-io\u003don $backing_file`"},{"line_number":104,"context_line":"        echo \u0027Dumping loops:\u0027"},{"line_number":105,"context_line":"        sudo losetup"},{"line_number":106,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_a666ef26","line":103,"in_reply_to":"3f79a3b5_46359b43","updated":"2018-12-14 15:33:39.000000000","message":"Yeah, losetup probably does something similar internally. Either way, we\u0027re doing this on actual disk in the gate, which should be fine. Anyone running devstack with /opt on NFS might run into a problem I guess, but loop would seriously suck like crazy on that as it is.\n\nI\u0027ll try to get a new enough machine with an nfs mount to see what losetup behavior is if you ask for directio and can\u0027t get it.","commit_id":"74da77768f1e7cde13bc4a60d8337d113208ddc6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"62759f59d91c8508ba0be1d499f3e4ff7a212134","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Only create if the file doesn\u0027t already exists"},{"line_number":101,"context_line":"        [[ -f $backing_file ]] || truncate -s $size $backing_file"},{"line_number":102,"context_line":"        local vg_dev"},{"line_number":103,"context_line":"        vg_dev\u003d`sudo losetup -f --show --direct-io\u003don $backing_file`"},{"line_number":104,"context_line":"        echo \u0027Dumping loops:\u0027"},{"line_number":105,"context_line":"        sudo losetup"},{"line_number":106,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3f79a3b5_393760df","line":103,"in_reply_to":"3f79a3b5_a666ef26","updated":"2018-12-14 15:40:48.000000000","message":"Well, NFS and CIFS on linux both support directio, and this works fine there. So I\u0027m not sure what other boutique filesystems people might have that wouldn\u0027t support it that are likely to be used, but I think we can probably assume this is okay if ext4, xfs, nfs, and cifs all do.","commit_id":"74da77768f1e7cde13bc4a60d8337d113208ddc6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"40649c6d8e226abe947f35e563680e3d352cd46b","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Check to see if we can do direct-io"},{"line_number":104,"context_line":"        if losetup -h | grep -q direct-io; then"},{"line_number":105,"context_line":"            local directio"},{"line_number":106,"context_line":"            directio\u003d\"--direct-io\u003don\""},{"line_number":107,"context_line":"        fi"},{"line_number":108,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f79a3b5_ee402e8d","line":105,"updated":"2018-12-16 22:35:17.000000000","message":"we should move this outside so if we don\u0027t take this path it\u0027s defined blank (possibly this doesn\u0027t run with -u but i imagine would fail under that)","commit_id":"ddab0bf18a5f4a6feee0649e4c51da8fcc5cb795"}]}