)]}'
{"roles/setup-devstack-cache/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5ee010c525f5c3d2f10be9191bae70d3b3681ef7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Copy cached devstack files"},{"line_number":2,"context_line":"  command: \"find {{ devstack_cache_dir }}/files -mindepth 1 -maxdepth 1 -exec cp --reflink\u003dauto {} {{ devstack_base_dir }}/devstack/files/ ;\""},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Set ownership of cached files"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfd5e7cf_6060cea6","line":2,"updated":"2019-01-10 01:18:22.000000000","message":"I don\u0027t believe that reflink support is available for ext4 (which is what we use on all our nodes), hence this will fall back to a regular copy which is exactly what the hardlinking is avoiding?  \n\nMaybe symlinks can help here, but I don\u0027t see reflink being what we want.","commit_id":"a215d16ff7988b63cc22bd4f421fa9c94364f6b6"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"896f8ab3322b6aab573cffa48352667df68e0334","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Copy cached devstack files"},{"line_number":2,"context_line":"  command: \"find {{ devstack_cache_dir }}/files -mindepth 1 -maxdepth 1 -exec cp --reflink\u003dauto {} {{ devstack_base_dir }}/devstack/files/ ;\""},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Set ownership of cached files"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bfdaf3ff_f9a9f2de","line":2,"in_reply_to":"dfd5e7cf_6060cea6","updated":"2019-01-14 17:54:15.000000000","message":"Ian, the reason for doing this is not performance, is security. \n\nThe entire hardlink, chown o+w is was a dangereous hack that we are trying to undo. \n\nI am wondering why we really needed the chown approach when we could have tried to add stack and zuul users to the same group and avoid the need to touch everyone permissions, maybe even sharing the cache without any hardlinking/copy.","commit_id":"a215d16ff7988b63cc22bd4f421fa9c94364f6b6"}]}
