)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f78b12212ea3d9827fcc6c9cdf3c46a4e140ce91","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a devstack-system cloud for system scoped actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The registered limits in keystone require a system scoped token to"},{"line_number":10,"context_line":"work. Getting one of those requires that domain and project information"},{"line_number":11,"context_line":"are not set."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfd5e7cf_2548bdca","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":21},"updated":"2019-01-08 15:37:27.000000000","message":"This will eventually be more and more things. Think anything that isn\u0027t directly owned by a domain or project (which is most things in keystone).","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"42c6a692b04077846a797fb0a76ef692b2f74c8c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a devstack-system cloud for system scoped actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The registered limits in keystone require a system scoped token to"},{"line_number":10,"context_line":"work. Getting one of those requires that domain and project information"},{"line_number":11,"context_line":"are not set."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfd5e7cf_04833155","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":21},"in_reply_to":"dfd5e7cf_2548bdca","updated":"2019-01-08 23:25:05.000000000","message":"Done","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"}],"functions-common":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f78b12212ea3d9827fcc6c9cdf3c46a4e140ce91","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # admin with a system-scoped token -\u003e devstack-system"},{"line_number":124,"context_line":"    $PYTHON $TOP_DIR/tools/update_clouds_yaml.py \\"},{"line_number":125,"context_line":"        --file $CLOUDS_YAML \\"},{"line_number":126,"context_line":"        --os-cloud devstack-system \\"},{"line_number":127,"context_line":"        --os-region-name $REGION_NAME \\"},{"line_number":128,"context_line":"        $CA_CERT_ARG \\"},{"line_number":129,"context_line":"        --os-auth-url $KEYSTONE_SERVICE_URI \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfd5e7cf_451e21bb","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":34},"updated":"2019-01-08 15:37:27.000000000","message":"In the future, we could expand on this to be devstack-system-admin, since it is possible to have system \"members\" and system \"readers\", too.","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"42c6a692b04077846a797fb0a76ef692b2f74c8c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # admin with a system-scoped token -\u003e devstack-system"},{"line_number":124,"context_line":"    $PYTHON $TOP_DIR/tools/update_clouds_yaml.py \\"},{"line_number":125,"context_line":"        --file $CLOUDS_YAML \\"},{"line_number":126,"context_line":"        --os-cloud devstack-system \\"},{"line_number":127,"context_line":"        --os-region-name $REGION_NAME \\"},{"line_number":128,"context_line":"        $CA_CERT_ARG \\"},{"line_number":129,"context_line":"        --os-auth-url $KEYSTONE_SERVICE_URI \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfd5e7cf_a497c590","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":34},"in_reply_to":"dfd5e7cf_451e21bb","updated":"2019-01-08 23:25:05.000000000","message":"Done","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c98665fc25a0e3bdfeaa45507021ee54189ef062","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    # admin with a system-scoped token -\u003e devstack-system"},{"line_number":124,"context_line":"    $PYTHON $TOP_DIR/tools/update_clouds_yaml.py \\"},{"line_number":125,"context_line":"        --file $CLOUDS_YAML \\"},{"line_number":126,"context_line":"        --os-cloud devstack-system \\"},{"line_number":127,"context_line":"        --os-region-name $REGION_NAME \\"},{"line_number":128,"context_line":"        $CA_CERT_ARG \\"},{"line_number":129,"context_line":"        --os-auth-url $KEYSTONE_SERVICE_URI \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dfd5e7cf_5bb1228f","line":126,"range":{"start_line":126,"start_character":19,"end_line":126,"end_character":34},"in_reply_to":"dfd5e7cf_451e21bb","updated":"2019-01-08 16:47:29.000000000","message":"Yeah, this is still the scoped variant of the admin account, changing things later might break stuff again, so let\u0027s use \"devstack-system-admin\" from the start.","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"}],"tools/update_clouds_yaml.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f78b12212ea3d9827fcc6c9cdf3c46a4e140ce91","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if args.os_cacert:"},{"line_number":52,"context_line":"            self._cloud_data[\u0027cacert\u0027] \u003d args.os_cacert"},{"line_number":53,"context_line":"        if args.os_system_scope:"},{"line_number":54,"context_line":"            self._cloud_data[\u0027auth\u0027][\u0027system_scope\u0027] \u003d \u0027all\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def run(self):"},{"line_number":57,"context_line":"        self._read_clouds()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_a55b4d85","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":60},"updated":"2019-01-08 15:37:27.000000000","message":"This might change in the future, too.\n\nWhen we originally wrote the \"system\" functionality in keystone, we designed it to be hierarchical. This is interesting if you consider the service catalog as a system.\n\nFor example, someone could have `admin` on the identity service or compute service, making the authoritative surface area more specific to a single service as opposed to letting someone have admin authorization on the *entire* system.\n\nGranted, that doesn\u0027t exist yet, but something that could happen in the future. Maybe\n\n  --os-system-scope \u003csystem-scope\u003e\n\nmight be useful to do initially, where `all` is the only option that makes sense today.","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"42c6a692b04077846a797fb0a76ef692b2f74c8c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if args.os_cacert:"},{"line_number":52,"context_line":"            self._cloud_data[\u0027cacert\u0027] \u003d args.os_cacert"},{"line_number":53,"context_line":"        if args.os_system_scope:"},{"line_number":54,"context_line":"            self._cloud_data[\u0027auth\u0027][\u0027system_scope\u0027] \u003d \u0027all\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def run(self):"},{"line_number":57,"context_line":"        self._read_clouds()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_e4f2ad06","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":60},"in_reply_to":"dfd5e7cf_a55b4d85","updated":"2019-01-08 23:25:05.000000000","message":"Done","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c98665fc25a0e3bdfeaa45507021ee54189ef062","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if args.os_cacert:"},{"line_number":52,"context_line":"            self._cloud_data[\u0027cacert\u0027] \u003d args.os_cacert"},{"line_number":53,"context_line":"        if args.os_system_scope:"},{"line_number":54,"context_line":"            self._cloud_data[\u0027auth\u0027][\u0027system_scope\u0027] \u003d \u0027all\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def run(self):"},{"line_number":57,"context_line":"        self._read_clouds()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_bb3feed4","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":60},"in_reply_to":"dfd5e7cf_a55b4d85","updated":"2019-01-08 16:47:29.000000000","message":"I was about to write a similar comment on the other file, yes, let\u0027s set \u003d args.os_system_scope here and be prepared for the future.\n\nTo avoid the same confusion that OSC currently has, we\u0027ll also want at least a warning if this option is set at the same time as os_project_name.","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"42c6a692b04077846a797fb0a76ef692b2f74c8c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if args.os_cacert:"},{"line_number":52,"context_line":"            self._cloud_data[\u0027cacert\u0027] \u003d args.os_cacert"},{"line_number":53,"context_line":"        if args.os_system_scope:"},{"line_number":54,"context_line":"            self._cloud_data[\u0027auth\u0027][\u0027system_scope\u0027] \u003d \u0027all\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def run(self):"},{"line_number":57,"context_line":"        self._read_clouds()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_a44a6524","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":60},"in_reply_to":"dfd5e7cf_bb3feed4","updated":"2019-01-08 23:25:05.000000000","message":"Done","commit_id":"008b6bb1de243a1cb6b580b190a63ceb7c0b0c02"}]}