)]}'
{"lib/neutron":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bcac15470eddc33224f7969ac258e8f53ac38ade","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# Network type - default vxlan, however enables vlan based jobs to override"},{"line_number":107,"context_line":"# using the legacy environment variable as well as a new variable in greater"},{"line_number":108,"context_line":"# alignment with the naming scheme of this plugin."},{"line_number":109,"context_line":"NEUTRON_TENANT_NETWORK_TYPE\u003d${NEUTRON_TENANT_NETWORK_TYPE:-${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-vxlan}}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"NEUTRON_TENANT_VLAN_RANGE\u003d${NEUTRON_TENANT_VLAN_RANGE:-${TENANT_VLAN_RANGE:-100:150}}"},{"line_number":112,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_0277bb3c","line":109,"updated":"2019-06-04 09:55:05.000000000","message":"This looks wrong, Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS can be set to a list of options like \"(network_vlan_ranges\u003deth0:600:700)\" which doesn\u0027t make sense here. Maybe just default your new variable to \"vxlan\" and be done?","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dbf644065e26c45fa3c1bf4cc3ab393ca535dc0c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# Network type - default vxlan, however enables vlan based jobs to override"},{"line_number":107,"context_line":"# using the legacy environment variable as well as a new variable in greater"},{"line_number":108,"context_line":"# alignment with the naming scheme of this plugin."},{"line_number":109,"context_line":"NEUTRON_TENANT_NETWORK_TYPE\u003d${NEUTRON_TENANT_NETWORK_TYPE:-${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-vxlan}}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"NEUTRON_TENANT_VLAN_RANGE\u003d${NEUTRON_TENANT_VLAN_RANGE:-${TENANT_VLAN_RANGE:-100:150}}"},{"line_number":112,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_420db33c","line":109,"in_reply_to":"9fb8cfa7_0277bb3c","updated":"2019-06-04 10:09:59.000000000","message":"+1","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b70a97c0dc986a095efd56540cffc2eeec09a8ef","unresolved":false,"context_lines":[{"line_number":106,"context_line":"# Network type - default vxlan, however enables vlan based jobs to override"},{"line_number":107,"context_line":"# using the legacy environment variable as well as a new variable in greater"},{"line_number":108,"context_line":"# alignment with the naming scheme of this plugin."},{"line_number":109,"context_line":"NEUTRON_TENANT_NETWORK_TYPE\u003d${NEUTRON_TENANT_NETWORK_TYPE:-${Q_ML2_PLUGIN_VLAN_TYPE_OPTIONS:-vxlan}}"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"NEUTRON_TENANT_VLAN_RANGE\u003d${NEUTRON_TENANT_VLAN_RANGE:-${TENANT_VLAN_RANGE:-100:150}}"},{"line_number":112,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_e977d139","line":109,"in_reply_to":"9fb8cfa7_420db33c","updated":"2019-06-05 13:41:36.000000000","message":"Done","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bcac15470eddc33224f7969ac258e8f53ac38ade","unresolved":false,"context_lines":[{"line_number":111,"context_line":"NEUTRON_TENANT_VLAN_RANGE\u003d${NEUTRON_TENANT_VLAN_RANGE:-${TENANT_VLAN_RANGE:-100:150}}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Physical network for VLAN network usage."},{"line_number":114,"context_line":"PHYSICAL_NETWORK\u003d${PHYSICAL_NETWORK:-}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Additional neutron api config files"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_02f01bc9","line":114,"updated":"2019-06-04 09:55:05.000000000","message":"This is also being used in lib/neutron-legacy, but with a default of \"public\", so I think you should either be consistent here or use a different name like NEUTRON_PHYSICAL_NETWORK.","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dbf644065e26c45fa3c1bf4cc3ab393ca535dc0c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"NEUTRON_TENANT_VLAN_RANGE\u003d${NEUTRON_TENANT_VLAN_RANGE:-${TENANT_VLAN_RANGE:-100:150}}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Physical network for VLAN network usage."},{"line_number":114,"context_line":"PHYSICAL_NETWORK\u003d${PHYSICAL_NETWORK:-}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Additional neutron api config files"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_a2182f81","line":114,"in_reply_to":"9fb8cfa7_02f01bc9","updated":"2019-06-04 10:09:59.000000000","message":"+1 to be consistent here","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b70a97c0dc986a095efd56540cffc2eeec09a8ef","unresolved":false,"context_lines":[{"line_number":111,"context_line":"NEUTRON_TENANT_VLAN_RANGE\u003d${NEUTRON_TENANT_VLAN_RANGE:-${TENANT_VLAN_RANGE:-100:150}}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# Physical network for VLAN network usage."},{"line_number":114,"context_line":"PHYSICAL_NETWORK\u003d${PHYSICAL_NETWORK:-}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# Additional neutron api config files"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_0973454f","line":114,"in_reply_to":"9fb8cfa7_a2182f81","updated":"2019-06-05 13:41:36.000000000","message":"Done","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bcac15470eddc33224f7969ac258e8f53ac38ade","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        iniset $NEUTRON_CORE_PLUGIN_CONF ml2_type_vxlan vni_ranges 1001:2000"},{"line_number":230,"context_line":"        iniset $NEUTRON_CORE_PLUGIN_CONF ml2_type_flat flat_networks public"},{"line_number":231,"context_line":"        if [[ \"$NEUTRON_TENANT_NETWORK_TYPE\" \u003d~ \"vlan\" ]] \u0026\u0026 [[ \"$PHYSICAL_NETWORK\" !\u003d \"\" ]]; then"},{"line_number":232,"context_line":"            iniset $NEUTRON_CORE_PLUGIN_CONF ml2_type_vlan network_vlan_ranges ${PHYSICAL_NETWORK}:${NEUTRON_TENANT_VLAN_RANGE}"},{"line_number":233,"context_line":"        fi"},{"line_number":234,"context_line":"        if [[ \"$NEUTRON_PORT_SECURITY\" \u003d \"True\" ]]; then"},{"line_number":235,"context_line":"            neutron_ml2_extension_driver_add port_security"},{"line_number":236,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_42d053f8","line":233,"range":{"start_line":231,"start_character":8,"end_line":233,"end_character":10},"updated":"2019-06-04 09:55:05.000000000","message":"With the above change to have a default for PHYSICAL_NETWORK, this iniset could simply be done unconditionally.","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b70a97c0dc986a095efd56540cffc2eeec09a8ef","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        iniset $NEUTRON_CORE_PLUGIN_CONF ml2_type_vxlan vni_ranges 1001:2000"},{"line_number":230,"context_line":"        iniset $NEUTRON_CORE_PLUGIN_CONF ml2_type_flat flat_networks public"},{"line_number":231,"context_line":"        if [[ \"$NEUTRON_TENANT_NETWORK_TYPE\" \u003d~ \"vlan\" ]] \u0026\u0026 [[ \"$PHYSICAL_NETWORK\" !\u003d \"\" ]]; then"},{"line_number":232,"context_line":"            iniset $NEUTRON_CORE_PLUGIN_CONF ml2_type_vlan network_vlan_ranges ${PHYSICAL_NETWORK}:${NEUTRON_TENANT_VLAN_RANGE}"},{"line_number":233,"context_line":"        fi"},{"line_number":234,"context_line":"        if [[ \"$NEUTRON_PORT_SECURITY\" \u003d \"True\" ]]; then"},{"line_number":235,"context_line":"            neutron_ml2_extension_driver_add port_security"},{"line_number":236,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_69e761e6","line":233,"range":{"start_line":231,"start_character":8,"end_line":233,"end_character":10},"in_reply_to":"9fb8cfa7_42d053f8","updated":"2019-06-05 13:41:36.000000000","message":"True, but it is also vlan specific which is why I checked both.","commit_id":"74ea3d5af1104a1a68ac611e961f15fcda1601e5"}]}