)]}'
{"functions-common":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e3b28ab7bfb00586138fbc4c85aaf0dbbee7fae7","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        # with a \"dot\", so for example 15.0"},{"line_number":387,"context_line":"        [ \"$os_CODENAME\" \u003d \"n/a\" -a \"$os_RELEASE\" \u003d \"${os_RELEASE/\\./}\" ] \u0026\u0026 \\"},{"line_number":388,"context_line":"            DISTRO\u003d\"opensuse-tumbleweed\""},{"line_number":389,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (SUSE*) ]]; then"},{"line_number":390,"context_line":"        # just use major release"},{"line_number":391,"context_line":"        DISTRO\u003d\"sle${os_RELEASE%.*}\""},{"line_number":392,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red.*Hat) || \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_ea420bab","line":389,"updated":"2019-01-29 12:22:03.000000000","message":"This is a regex match, so the \u0027*\u0027 seems wrong unless you also want to match \u0027SUS\u0027 or \u0027SUSEE\u0027.\n\nI\u0027m also a bit worried that this match includes the \"openSUSE\" match that is handled differently above, so maybe a comment, noting that the ordering is important here, would be helpful.\n\nTechnically also the () aren\u0027t necessary, but as they are used everywhere else (probably for readability), I\u0027m fine with keeping them.","commit_id":"4c11b32781bc12d25a59fc2276ced5ffd5bb3a84"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"c480226d74e610a8642a118f91e7e647dcbd37d0","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        # with a \"dot\", so for example 15.0"},{"line_number":387,"context_line":"        [ \"$os_CODENAME\" \u003d \"n/a\" -a \"$os_RELEASE\" \u003d \"${os_RELEASE/\\./}\" ] \u0026\u0026 \\"},{"line_number":388,"context_line":"            DISTRO\u003d\"opensuse-tumbleweed\""},{"line_number":389,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (SUSE*) ]]; then"},{"line_number":390,"context_line":"        # just use major release"},{"line_number":391,"context_line":"        DISTRO\u003d\"sle${os_RELEASE%.*}\""},{"line_number":392,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (Red.*Hat) || \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_53ad0b99","line":389,"in_reply_to":"9fdfeff1_ea420bab","updated":"2019-01-29 19:12:33.000000000","message":"\u003e This is a regex match, so the \u0027*\u0027 seems wrong unless you also want to match \u0027SUS\u0027 or \u0027SUSEE\u0027.\n\nAh thanks, good catch - I was confusing it with \u003d\u003d which is a pattern match, but incidentally which wouldn\u0027t have allowed the surrounding parentheses - so I should have known better ;-)\n\n\u003e I\u0027m also a bit worried that this match includes the \"openSUSE\" match that is handled differently above, so maybe a comment, noting that the ordering is important here, would be helpful.\n\nRelying on ordering certainly wasn\u0027t my intention and is not great style in this scenario, so I\u0027ll simply fix the pattern matching in the next patch set instead.\n\n\u003e Technically also the () aren\u0027t necessary, but as they are used everywhere else (probably for readability), I\u0027m fine with keeping them.\n\nYes I\u0027m puzzled why they\u0027re used everywhere else but I guess it\u0027s a deliberate style decision, and I think it\u0027s more important to be consistent than concise.","commit_id":"4c11b32781bc12d25a59fc2276ced5ffd5bb3a84"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e3b28ab7bfb00586138fbc4c85aaf0dbbee7fae7","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        GetOSVersion"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    [[ \"$os_VENDOR\" \u003d~ (openSUSE) || \"$os_VENDOR\" \u003d~ (SUSE*) ]]"},{"line_number":468,"context_line":"}"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_aa1ac3c8","line":467,"updated":"2019-01-29 12:22:03.000000000","message":"This is redundant, see above, just using the second term (without the \u0027*\u0027) should be enough.","commit_id":"4c11b32781bc12d25a59fc2276ced5ffd5bb3a84"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"c480226d74e610a8642a118f91e7e647dcbd37d0","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        GetOSVersion"},{"line_number":465,"context_line":"    fi"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    [[ \"$os_VENDOR\" \u003d~ (openSUSE) || \"$os_VENDOR\" \u003d~ (SUSE*) ]]"},{"line_number":468,"context_line":"}"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fdfeff1_f37e7f17","line":467,"in_reply_to":"9fdfeff1_aa1ac3c8","updated":"2019-01-29 19:12:33.000000000","message":"Yeah but I think it\u0027s cleaner to have two explicitly separate tests - the next patch set will fix this.","commit_id":"4c11b32781bc12d25a59fc2276ced5ffd5bb3a84"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"239d4114fcbe912dae8c60ac8643734975683dfa","unresolved":false,"context_lines":[{"line_number":478,"context_line":"# Determine if current distribution is a SUSE Linux Enterprise (SLE)"},{"line_number":479,"context_line":"# distribution"},{"line_number":480,"context_line":"# is_sle"},{"line_number":481,"context_line":"function is_sle {"},{"line_number":482,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"},{"line_number":483,"context_line":"        GetOSVersion"},{"line_number":484,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fdfeff1_05a64b54","line":481,"updated":"2019-01-30 15:33:11.000000000","message":"My only remaining concern is that this function name might be a bit too cryptic when seen outside of the \"distro detection\" context, so maybe you could use \"is_suse_linux\" instead.","commit_id":"d3d4e54c349d1928cf34e61711c73c976a59eb55"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"6252713cc8aa1688dfeb88cb2ac6e5b1ed174e3f","unresolved":false,"context_lines":[{"line_number":478,"context_line":"# Determine if current distribution is a SUSE Linux Enterprise (SLE)"},{"line_number":479,"context_line":"# distribution"},{"line_number":480,"context_line":"# is_sle"},{"line_number":481,"context_line":"function is_sle {"},{"line_number":482,"context_line":"    if [[ -z \"$os_VENDOR\" ]]; then"},{"line_number":483,"context_line":"        GetOSVersion"},{"line_number":484,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fdfeff1_dbfa6041","line":481,"in_reply_to":"9fdfeff1_05a64b54","updated":"2019-01-30 16:50:58.000000000","message":"Good point, thanks! - fixed in next patchset.  BTW in case you\u0027re curious, the last release of \"SUSE Linux\" was version 10.1 in 2006.  Since then there has only been SUSE Linux Enterprise and openSUSE:\n\nhttps://en.wikipedia.org/wiki/SUSE_Linux","commit_id":"d3d4e54c349d1928cf34e61711c73c976a59eb55"}]}