)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"08ace807d20c17eede0c1ab5d2cc5c024a3856f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The read_password function is defined inside stack.sh"},{"line_number":10,"context_line":"and it cannot be used inside the \"public library interface\""},{"line_number":11,"context_line":"provided by DevStack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"While the call to read_password may be moved to stack.sh,"},{"line_number":14,"context_line":"both requirements are base ones and an error when they are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_0e57155a","line":11,"updated":"2019-02-17 22:46:10.000000000","message":"I don\u0027t think I\u0027m understanding the issue here?  We source the library files like this nova-plugin into the same shell as we\u0027re working in; e.g. it\u0027s really the same as\n\n $ cat a.sh\n #!/bin/bash\n function foo {\n   echo $1\n }\n source b.sh\n\n $ cat b.sh\n foo \"hello\"\n\nwhich would print \"hello\"\n\nSo I might need some more context to understand how this is actually failing?","commit_id":"52b3b6507525242e0badc8a6bd8b17d5f71d05af"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"698a9d9c87087cdb6da17113d43d4ea8c6eac25a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The read_password function is defined inside stack.sh"},{"line_number":10,"context_line":"and it cannot be used inside the \"public library interface\""},{"line_number":11,"context_line":"provided by DevStack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"While the call to read_password may be moved to stack.sh,"},{"line_number":14,"context_line":"both requirements are base ones and an error when they are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_2ee454df","line":11,"in_reply_to":"9fdfeff1_0e57155a","updated":"2019-02-18 09:18:43.000000000","message":"Try to import the files from lib/ from another project (grenade, in my case) and *not* define MYSQL_SERVER; the current code path calls read_password, which is defined inside stack.sh, and that result in an error.\nThe other removal is for consistency.","commit_id":"52b3b6507525242e0badc8a6bd8b17d5f71d05af"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"08ace807d20c17eede0c1ab5d2cc5c024a3856f9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Generally speaking, read_password seems a relic from the past"},{"line_number":18,"context_line":"and devstack does not seem to be advertised as an interactive"},{"line_number":19,"context_line":"tool."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I8adc6723b677dfac2bef735f660e056c498bf773"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_0e6e352e","line":19,"updated":"2019-02-17 22:46:10.000000000","message":"I think people do in fact start up devstack interactively for various reasons.\n\nBut also there\u0027s a couple of other external users in codesearch, although it is probably just copied in we should still need to ensure they\u0027re not broken","commit_id":"52b3b6507525242e0badc8a6bd8b17d5f71d05af"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"698a9d9c87087cdb6da17113d43d4ea8c6eac25a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Generally speaking, read_password seems a relic from the past"},{"line_number":18,"context_line":"and devstack does not seem to be advertised as an interactive"},{"line_number":19,"context_line":"tool."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I8adc6723b677dfac2bef735f660e056c498bf773"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fdfeff1_6ededc11","line":19,"in_reply_to":"9fdfeff1_0e6e352e","updated":"2019-02-18 09:18:43.000000000","message":"Grenade is broken, so either the calls to read_password are moved to stack.sh or they are removed. Pick a choice but please tell me which one.","commit_id":"52b3b6507525242e0badc8a6bd8b17d5f71d05af"}],"lib/database":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"706ada0f47754c700a514be083e70e7cdcb209e1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if [ -n \"$MYSQL_PASSWORD\" ]; then"},{"line_number":89,"context_line":"        DATABASE_PASSWORD\u003d$MYSQL_PASSWORD"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        read_password DATABASE_PASSWORD \"ENTER A PASSWORD TO USE FOR THE DATABASE.\""},{"line_number":92,"context_line":"    fi"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # We configure Nova, Horizon, Glance and Keystone to use MySQL as their"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9fdfeff1_5b826b02","side":"PARENT","line":91,"updated":"2019-02-21 08:55:38.000000000","message":"So plenty of people clone the git repo and run ./stack.sh by hand.  We can\u0027t just ignore that, and it seems to me that this is the only place DATABASE_PASSWORD is set.  ergo if we just remove this they are up the proverbial creek.\n\nI feel like setting it in stack.sh is the best solution\n\nOtherwise it seems you could also do\n\n if [ -z \"$DATABASE_PASSWORD\" ];\n   read_password ...\n fi \n\nbecause this is relying on \"read_password\"\u0027s ability to pickup the env variable if it\u0027s there.","commit_id":"a6c3f5886a1dbf27da6585b4958dac2aab566b6a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"87e6682d130f271cf5c821b519f9255ec3483c3d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if [ -n \"$MYSQL_PASSWORD\" ]; then"},{"line_number":89,"context_line":"        DATABASE_PASSWORD\u003d$MYSQL_PASSWORD"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        read_password DATABASE_PASSWORD \"ENTER A PASSWORD TO USE FOR THE DATABASE.\""},{"line_number":92,"context_line":"    fi"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # We configure Nova, Horizon, Glance and Keystone to use MySQL as their"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9fdfeff1_bbf1176d","side":"PARENT","line":91,"in_reply_to":"9fdfeff1_5b826b02","updated":"2019-02-21 09:03:59.000000000","message":"Given that all devstack configuration examples explicitly point out that you need to set DATABASE_PASSWORD, I disagree that this change would be a problem if implemented.\n\nThat said, not my call, so I would move the call to read_password elsewhere.\n\nShould the other call to read_password be handled in the same way?","commit_id":"a6c3f5886a1dbf27da6585b4958dac2aab566b6a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"87137609eec7e1693e567408711b15de4dc95612","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if [ -n \"$MYSQL_PASSWORD\" ]; then"},{"line_number":89,"context_line":"        DATABASE_PASSWORD\u003d$MYSQL_PASSWORD"},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        read_password DATABASE_PASSWORD \"ENTER A PASSWORD TO USE FOR THE DATABASE.\""},{"line_number":92,"context_line":"    fi"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # We configure Nova, Horizon, Glance and Keystone to use MySQL as their"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9fdfeff1_3b1e8774","side":"PARENT","line":91,"in_reply_to":"9fdfeff1_bbf1176d","updated":"2019-02-21 09:10:52.000000000","message":"\u003e Given that all devstack configuration examples explicitly point out that you need to set DATABASE_PASSWORD, I disagree that this change would be a problem if implemented.\n\nWell we go from \"user didn\u0027t do that and was prompted for a password\" to \"user gets an invalid SQL connection URL, which probably causes a bunch of random, hard to debug errors starting services\" which seems a regression\n\n\u003e Should the other call to read_password be handled in the same way?\n\nI think something like (pseudo-code)\n\n if [[ $VIRT_DRIVER \u003d\u003d xen ]]; then\n   read xen password\n fi\n\nwould be fine in stack.sh","commit_id":"a6c3f5886a1dbf27da6585b4958dac2aab566b6a"}]}