)]}'
{"id":"openstack%2Fdevstack~640985","triplet_id":"openstack%2Fdevstack~stable%2Fnewton~Ie810b22eacd81c3f648f351933106b3397c69773","project":"openstack/devstack","branch":"stable/newton","topic":"bug/1764046","hashtags":[],"change_id":"Ie810b22eacd81c3f648f351933106b3397c69773","subject":"Use split instead of strip","status":"ABANDONED","created":"2019-03-05 11:33:31.000000000","updated":"2019-03-05 12:51:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"86857ccb86539af5a4bf77573ee6f27e904ee8bf","_number":640985,"virtual_id_number":640985,"owner":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"actions":{},"labels":{"Verified":{"all":[{"date":"2019-03-05 11:42:01.000000000","_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2019-03-05 12:20:34.000000000","_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-03-05 11:34:40.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-03-05 11:38:43.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-03-05 11:38:54.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2019-03-05 12:20:34.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"905e6fd6b94cb0d401d5c8c23368b8389aa12862","author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"date":"2019-03-05 11:33:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c25356fe9bc69d392cf2c1e99f89b42c7a3e3140","author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"date":"2019-03-05 11:41:07.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6b04ea7a65cf03dd96d7ba5e240878a713d6354b","author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"date":"2019-03-05 11:42:01.000000000","message":"Patch Set 2:\n\nEh.. \n\nhttps://review.openstack.org/#/c/562610/\n\nI don\u0027t think we can merge things to newton as the jobs are broken ...","accounts_in_message":[],"_revision_number":2},{"id":"2e555544a6dd8c99275564bd72ccf2a93c002d21","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2019-03-05 12:20:34.000000000","message":"Patch Set 2:\n\nHi Paweł, newton version reached End Of Life in its life cycle.\n\nPlease use the latest or any maintained stable release instead. https://releases.openstack.org/","accounts_in_message":[],"_revision_number":2},{"id":"cec56cfc49b8a333ffe5f6474497a08e28e63414","author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"date":"2019-03-05 12:51:38.000000000","message":"Abandoned\n\nOk, got it, closing it, thank you!","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8be6dbc71e9d4ce5485ec3222970d1297ebd324b","revisions":{"edc2f4e4d4ac4c7c35957fa5045f2aa5a63d11d4":{"kind":"REWORK","_number":1,"created":"2019-03-05 11:33:31.000000000","uploader":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"ref":"refs/changes/85/640985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/85/640985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/640985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/640985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/640985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/85/640985/1"}}},"commit":{"parents":[{"commit":"386aefe441cdcdedb566dc014c6abd5f7dd16c97","subject":"Use \"pip list\" in check_libs_from_git","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/386aefe441cdcdedb566dc014c6abd5f7dd16c97"}]}],"author":{"name":"Pawel Suder","email":"pawel@suder.info","date":"2019-03-05 11:30:19.000000000","tz":60},"committer":{"name":"Pawel Suder","email":"pawel@suder.info","date":"2019-03-05 11:33:28.000000000","tz":60},"subject":"Use split instead of strip","message":"Use split instead of strip\n\nIf pip major version is greater than 9 stack.sh fails due\nto issue with incorrect version. strip return 1, split\nwill return 10 or higher.\n\nTrivialFix\n\nChange-Id: Ie810b22eacd81c3f648f351933106b3397c69773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/edc2f4e4d4ac4c7c35957fa5045f2aa5a63d11d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/edc2f4e4d4ac4c7c35957fa5045f2aa5a63d11d4"}]},"branch":"refs/heads/stable/newton"},"8be6dbc71e9d4ce5485ec3222970d1297ebd324b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-03-05 11:41:07.000000000","uploader":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"ref":"refs/changes/85/640985/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/85/640985/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/640985/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/640985/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/85/640985/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/85/640985/2"}}},"commit":{"parents":[{"commit":"386aefe441cdcdedb566dc014c6abd5f7dd16c97","subject":"Use \"pip list\" in check_libs_from_git","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/386aefe441cdcdedb566dc014c6abd5f7dd16c97"}]}],"author":{"name":"Pawel Suder","email":"pawel@suder.info","date":"2019-03-05 11:30:19.000000000","tz":60},"committer":{"name":"Pawel Suder","email":"pawel@suder.info","date":"2019-03-05 11:40:10.000000000","tz":60},"subject":"Use split instead of strip","message":"Use split instead of strip\n\nIf pip major version is greater than 9 stack.sh fails due\nto issue with incorrect version. strip return 1, split\nwill return 10 or higher\n\nIt was in past in review:\n\nProperly get pip version\n\nThe old code was strip()ing the version string instead of split()ing the\nversion string so we always got the first character of the version\nstring. This worked fine as long as the pip version was single digit but\nas soon as it rolls over to \u002710.stuff\u0027 we will compare:\n\n  pip version 1 (instead of 10) \u003e 6\n\nWhich fails bceause 1 is less than six. Instaed we really do want to\ncompare 10 \u003e 6 so use split on \u0027.\u0027 instead.\n\nCloses-Bug: #1764046\nChange-Id: Ic7d0c04d7fa77774ab2d70fb9d11f182becec553\n(cherry picked from commit 0657795)i\n\nChange-Id: Ie810b22eacd81c3f648f351933106b3397c69773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8be6dbc71e9d4ce5485ec3222970d1297ebd324b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8be6dbc71e9d4ce5485ec3222970d1297ebd324b"}]},"branch":"refs/heads/stable/newton"}},"requirements":[],"submit_records":[],"submit_requirements":[]}