)]}'
{"inc/python":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5dcb2db3d2683d507c3b4d85ff3bdb272f69389f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if python3_enabled \u0026\u0026 ([[ \"$os_VENDOR\" \u003d\u003d \"CentOS\" ]] || \\"},{"line_number":53,"context_line":"    [[ \"$os_VENDOR\" \u003d\u003d \"Fedora\" \u0026\u0026 $os_RELEASE -gt 26 ]]); then"},{"line_number":54,"context_line":"        # Default Python 3 install prefix changed to /usr/local in Fedora 27:"},{"line_number":55,"context_line":"        # https://fedoraproject.org/wiki/Changes/Making_sudo_pip_safe"},{"line_number":56,"context_line":"        echo \"/usr/local/bin\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_7b6ea600","line":53,"range":{"start_line":52,"start_character":26,"end_line":53,"end_character":58},"updated":"2019-03-18 10:03:52.000000000","message":"Now the indentation looks even worse (was wrong before)...","commit_id":"02255cbb32df3356ef8837740ff2ad42077f2aa8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ba632e2b1546a2511405219a51e9313cd942b03f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if python3_enabled \u0026\u0026 ([[ \"$os_VENDOR\" \u003d\u003d \"CentOS\" ]] || \\"},{"line_number":53,"context_line":"    [[ \"$os_VENDOR\" \u003d\u003d \"Fedora\" \u0026\u0026 $os_RELEASE -gt 26 ]]); then"},{"line_number":54,"context_line":"        # Default Python 3 install prefix changed to /usr/local in Fedora 27:"},{"line_number":55,"context_line":"        # https://fedoraproject.org/wiki/Changes/Making_sudo_pip_safe"},{"line_number":56,"context_line":"        echo \"/usr/local/bin\""},{"line_number":57,"context_line":"    elif is_fedora || is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_a5cddb85","line":54,"updated":"2019-03-15 21:11:51.000000000","message":"ok so you added () around the condtion\nthis should force the desired effect.\n\ni take it python2 on fedora was reporting /usr/local/bin.\n\nthe intent in python was \n\nif (python3 and (centos or (fedora \u003e26))):\n    return \"/usr/local/bin\"\n\nso i agree i think this change creates that behavior.\n\nthe previous code presuable was the same as\n\n(python3 and centos) or (fedora \u003e 26)\n\nthat is not what i was expecting but bash rarely is.","commit_id":"02255cbb32df3356ef8837740ff2ad42077f2aa8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b9aaceccf3405e83395b3a143879509026bc1fc4","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if python3_enabled \u0026\u0026 ([[ \"$os_VENDOR\" \u003d\u003d \"CentOS\" ]] || \\"},{"line_number":53,"context_line":"    [[ \"$os_VENDOR\" \u003d\u003d \"Fedora\" \u0026\u0026 $os_RELEASE -gt 26 ]]); then"},{"line_number":54,"context_line":"        # Default Python 3 install prefix changed to /usr/local in Fedora 27:"},{"line_number":55,"context_line":"        # https://fedoraproject.org/wiki/Changes/Making_sudo_pip_safe"},{"line_number":56,"context_line":"        echo \"/usr/local/bin\""},{"line_number":57,"context_line":"    elif is_fedora || is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_161bb9c9","line":54,"in_reply_to":"5fc1f717_a5cddb85","updated":"2019-03-18 10:46:14.000000000","message":"Even Fedora 27 is EOL for some time now, so maybe we can make this much simpler again instead of more complicated. Since the default is /usr/local/bin anyway, we should only need\n\n( is_fedora \u0026\u0026 !python3_enabled ) || is_suse \u003d\u003e /usr/bin\n\nMaybe even split that into two blocks, to avoid the conditionals getting too complicated again.","commit_id":"02255cbb32df3356ef8837740ff2ad42077f2aa8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4ef2249efa438af0ec165156cd8381c0aeff164c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    PYTHON_PATH\u003d\"/usr/local/bin\""},{"line_number":53,"context_line":"    ( is_fedora \u0026\u0026 ! python3_enabled ) || is_suse \u0026\u0026 PYTHON_PATH\u003d\"/usr/bin\""},{"line_number":54,"context_line":"    echo \"$PYTHON_PATH\""},{"line_number":55,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5fc1f717_f5f8f57c","line":52,"updated":"2019-03-22 11:18:03.000000000","message":"I think you should make this a local variable in order to avoid side-effects outside this function. The convention for that would also be to use a lower-cased name.\n\nAlso you are only dealing with fixed strings here that don\u0027t need to be quoted, so you could drop them.\n\n    local python_path\u003d/usr/local/bin","commit_id":"c04fcfc0ee67809ec425d9baae130e9bf93de47f"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"9098de451d575c81d1aadecdea561ce4493197f9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    fi"},{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    PYTHON_PATH\u003d\"/usr/local/bin\""},{"line_number":53,"context_line":"    ( is_fedora \u0026\u0026 ! python3_enabled ) || is_suse \u0026\u0026 PYTHON_PATH\u003d\"/usr/bin\""},{"line_number":54,"context_line":"    echo \"$PYTHON_PATH\""},{"line_number":55,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5fc1f717_20c142e5","line":52,"in_reply_to":"5fc1f717_f5f8f57c","updated":"2019-03-24 11:53:10.000000000","message":"Done","commit_id":"c04fcfc0ee67809ec425d9baae130e9bf93de47f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"622eedb6965076fb32f37239a64a9463b30394ab","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    local PYTHON_PATH\u003d/usr/local/bin"},{"line_number":53,"context_line":"    ( is_fedora \u0026\u0026 ! python3_enabled ) || is_suse \u0026\u0026 PYTHON_PATH\u003d/usr/bin"},{"line_number":54,"context_line":"    echo $PYTHON_PATH"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5fc1f717_f36404bb","line":53,"updated":"2019-03-28 11:04:24.000000000","message":"I have doubts about we have real distro differences today.","commit_id":"a30dd1cc96a75d565ae924e4698c4208150e5564"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"66f37ce12aa6da69f18f51fb12313424095ff081","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    local PYTHON_PATH\u003d/usr/local/bin"},{"line_number":53,"context_line":"    ( is_fedora \u0026\u0026 ! python3_enabled ) || is_suse \u0026\u0026 PYTHON_PATH\u003d/usr/bin"},{"line_number":54,"context_line":"    echo $PYTHON_PATH"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5fc1f717_85b211e4","line":53,"in_reply_to":"5fc1f717_456669ef","updated":"2019-03-28 13:50:07.000000000","message":"/usr/local/bin ALL py3 , /usr/bin ALL py2 . I do not know about exception.\n\nf27 EoL.","commit_id":"a30dd1cc96a75d565ae924e4698c4208150e5564"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8b443893f8a80ce9668b472ccf592f962886a369","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    local PYTHON_PATH\u003d/usr/local/bin"},{"line_number":53,"context_line":"    ( is_fedora \u0026\u0026 ! python3_enabled ) || is_suse \u0026\u0026 PYTHON_PATH\u003d/usr/bin"},{"line_number":54,"context_line":"    echo $PYTHON_PATH"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5fc1f717_f36388dc","line":53,"in_reply_to":"5fc1f717_85b211e4","updated":"2019-03-29 13:47:08.000000000","message":"For ubuntu we seem to be using /usr/local/bin for py27 jobs, too.","commit_id":"a30dd1cc96a75d565ae924e4698c4208150e5564"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"59ba83e5ace9a084923fb657edec385cf95dc896","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    $xtrace"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    local PYTHON_PATH\u003d/usr/local/bin"},{"line_number":53,"context_line":"    ( is_fedora \u0026\u0026 ! python3_enabled ) || is_suse \u0026\u0026 PYTHON_PATH\u003d/usr/bin"},{"line_number":54,"context_line":"    echo $PYTHON_PATH"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5fc1f717_456669ef","line":53,"in_reply_to":"5fc1f717_f36404bb","updated":"2019-03-28 13:35:38.000000000","message":"will the following do the work ? I dont have Python3 installed in my setup at this moment\n# dirname  $(which python)","commit_id":"a30dd1cc96a75d565ae924e4698c4208150e5564"}]}