)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"652e6bf52ab7b6164c3db38267b9c761825673c2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The pip_install function code that is dealing with installing py3"},{"line_number":21,"context_line":"packages is hitting a problem installing etcd3gw if the package is"},{"line_number":22,"context_line":"local because of the more restrictive grep in the"},{"line_number":23,"context_line":"check_python3_support_for_package_local function, and since"},{"line_number":24,"context_line":"PYTHON3_VERSION\u003d3.6 now, we don\u0027t install from py3 and install"},{"line_number":25,"context_line":"etcd3gw on python 2.7 which makes services like cinder-volume and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_b5bb92c2","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":5},"updated":"2019-03-19 19:13:53.000000000","message":"Looks like this is the case on the \"rax-dfw\" nodes so it must be pre-installed in those images.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f5a7be12e098db6ccb1ddc60bd4b59ae7b785a33","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The pip_install function code that is dealing with installing py3"},{"line_number":21,"context_line":"packages is hitting a problem installing etcd3gw if the package is"},{"line_number":22,"context_line":"local because of the more restrictive grep in the"},{"line_number":23,"context_line":"check_python3_support_for_package_local function, and since"},{"line_number":24,"context_line":"PYTHON3_VERSION\u003d3.6 now, we don\u0027t install from py3 and install"},{"line_number":25,"context_line":"etcd3gw on python 2.7 which makes services like cinder-volume and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_f0728849","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":5},"in_reply_to":"5fc1f717_b5bb92c2","updated":"2019-03-19 20:02:06.000000000","message":"yeah other images like on ovh-gra1[1], vexxhost-sjc1 nodes try with remote package installation with 3.5 classifier.\n\n- http://logs.openstack.org/21/641921/1/check/grenade-py3/e894fe1/logs/pip3-freeze.txt.gz\n\nand the testing patch of the bionic migration activity used ovh-gra1 node.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f5a7be12e098db6ccb1ddc60bd4b59ae7b785a33","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Note that alternatives would be:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"1. Update the etcd3gw package to add the 3.6 classifier and do"},{"line_number":45,"context_line":"   a release (this should probably happen anyway)."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"2. Add etcd3gw to ENABLED_PYTHON3_PACKAGES but that would be a"},{"line_number":48,"context_line":"   short-term hack workaround."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_5097dc3b","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":50},"updated":"2019-03-19 20:02:06.000000000","message":"+1, this is something dims should do to test it under bionic with default py3 version","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"}],"inc/python":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"600847a8c83c989801dbefb19ba97a8260e2d884","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    classifier\u003d$(python setup.py --classifiers \\"},{"line_number":104,"context_line":"        | grep \u0027Programming Language :: Python :: 3\u0027)"},{"line_number":105,"context_line":"    set -e"},{"line_number":106,"context_line":"    echo $classifier"},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# Check for python3 classifier on pypi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_c98c7e37","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":20},"updated":"2019-04-01 15:06:37.000000000","message":"This doesn\u0027t show up in the output.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2838c971573bb6505e0691d779764423b703e776","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    classifier\u003d$(python setup.py --classifiers \\"},{"line_number":104,"context_line":"        | grep \u0027Programming Language :: Python :: 3\u0027)"},{"line_number":105,"context_line":"    set -e"},{"line_number":106,"context_line":"    echo $classifier"},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# Check for python3 classifier on pypi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_89d3d6d5","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":20},"in_reply_to":"5fc1f717_c98c7e37","updated":"2019-04-01 15:16:57.000000000","message":"Oh nevermind this is the return value of the function.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"600847a8c83c989801dbefb19ba97a8260e2d884","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    classifier\u003d$(curl -s -L \"https://pypi.python.org/pypi/$name/json\" \\"},{"line_number":114,"context_line":"        | grep \u0027\"Programming Language :: Python :: 3\"\u0027)"},{"line_number":115,"context_line":"    set -e"},{"line_number":116,"context_line":"    echo $classifier"},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# python3_enabled_for() assumes the service(s) specified as arguments are"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_a987b212","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":20},"updated":"2019-04-01 15:06:37.000000000","message":"This doesn\u0027t seem to actually show up in the output, I wonder why.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2838c971573bb6505e0691d779764423b703e776","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    classifier\u003d$(curl -s -L \"https://pypi.python.org/pypi/$name/json\" \\"},{"line_number":114,"context_line":"        | grep \u0027\"Programming Language :: Python :: 3\"\u0027)"},{"line_number":115,"context_line":"    set -e"},{"line_number":116,"context_line":"    echo $classifier"},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# python3_enabled_for() assumes the service(s) specified as arguments are"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_29d8a2ee","line":116,"range":{"start_line":116,"start_character":4,"end_line":116,"end_character":20},"in_reply_to":"5fc1f717_a987b212","updated":"2019-04-01 15:16:57.000000000","message":"same as above","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f5a7be12e098db6ccb1ddc60bd4b59ae7b785a33","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":300,"context_line":"                        else"},{"line_number":301,"context_line":"                            echo \"WARNING: Did not find python 3 classifier for local package $package_dir\""},{"line_number":302,"context_line":"                        fi"},{"line_number":303,"context_line":"                    fi"},{"line_number":304,"context_line":"                else"},{"line_number":305,"context_line":"                    # Check pypi as we don\u0027t have the package on disk"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_d09c2c6c","line":302,"range":{"start_line":302,"start_character":24,"end_line":302,"end_character":26},"updated":"2019-03-19 20:02:06.000000000","message":"we could try the remote package in this else part and if py3 classifier not found in remote also then, echo warning. \n\nAs seen in this bug, we might have few bionic images having some local package but not with the right classifier (3.6 in case of bionic). Falling back to remote package is better try before we give up on package install.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4e882e62abcbb8ddb98736ee0806b9f10650f49b","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":300,"context_line":"                        else"},{"line_number":301,"context_line":"                            echo \"WARNING: Did not find python 3 classifier for local package $package_dir\""},{"line_number":302,"context_line":"                        fi"},{"line_number":303,"context_line":"                    fi"},{"line_number":304,"context_line":"                else"},{"line_number":305,"context_line":"                    # Check pypi as we don\u0027t have the package on disk"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_703e98db","line":302,"range":{"start_line":302,"start_character":24,"end_line":302,"end_character":26},"in_reply_to":"5fc1f717_50e83c7b","updated":"2019-03-19 20:18:05.000000000","message":"In this case, it does not make a difference. I am thinking if used image has the wrong package building which is rare but possible.\n\nanyways as discussed on IRC, we can do this as the followup if required. let\u0027s get this in to fix this bug.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b3bb1dbc401b4547b00d9c48b9fbda2a5796bc9c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":300,"context_line":"                        else"},{"line_number":301,"context_line":"                            echo \"WARNING: Did not find python 3 classifier for local package $package_dir\""},{"line_number":302,"context_line":"                        fi"},{"line_number":303,"context_line":"                    fi"},{"line_number":304,"context_line":"                else"},{"line_number":305,"context_line":"                    # Check pypi as we don\u0027t have the package on disk"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_50e83c7b","line":302,"range":{"start_line":302,"start_character":24,"end_line":302,"end_character":26},"in_reply_to":"5fc1f717_d09c2c6c","updated":"2019-03-19 20:10:57.000000000","message":"\u003e we could try the remote package in this else part and if py3\n \u003e classifier not found in remote also then, echo warning.\n \u003e \n \u003e As seen in this bug, we might have few bionic images having some\n \u003e local package but not with the right classifier (3.6 in case of\n \u003e bionic). Falling back to remote package is better try before we\n \u003e give up on package install.\n\nI\u0027m not sure what difference that would make, at least in this case. etcd3gw does not list python 3.6 in its classifiers, so whether we check it remotely or locally, if PYTHON3_VERSION is 3.6 it won\u0027t work on a strict check, which is why we fallback to check for just the \"Python :: 3\" classifier.","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"600847a8c83c989801dbefb19ba97a8260e2d884","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                        sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":311,"context_line":"                        cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":312,"context_line":"                    else"},{"line_number":313,"context_line":"                        echo \"WARNING: Did not find python 3 classifier for remote package $package_dir\""},{"line_number":314,"context_line":"                    fi"},{"line_number":315,"context_line":"                fi"},{"line_number":316,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_499dee55","line":313,"range":{"start_line":313,"start_character":92,"end_line":313,"end_character":103},"updated":"2019-04-01 15:06:37.000000000","message":"This should just be $package because $package_dir could have versions blacklisted in it:\n\nWARNING: Did not find python 3 classifier for remote package libvirt-python!\u003d4.1.0,!\u003d4.2.0","commit_id":"ddb6179b0479ea9478cf2a146fe9b0d7592acaec"}]}