)]}'
{"inc/python":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7592e21cac573d615284f74e3ba00629baff0bf1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    local meta"},{"line_number":106,"context_line":"    local classifiers"},{"line_number":107,"context_line":"    set +e"},{"line_number":108,"context_line":"    meta\u003d$(curl -s -L \"https://pypi.python.org/pypi/$name/json\")"},{"line_number":109,"context_line":"    # Check for missing data."},{"line_number":110,"context_line":"    if [[ -z $meta ]]; then"},{"line_number":111,"context_line":"        echo \"WARNING: Failed to get json metadata for package $name\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_74cd2285","line":108,"updated":"2019-04-01 16:30:54.000000000","message":"I was wondering earlier whether we should be using our mirror for this, too. Hopefully this patch will tell.","commit_id":"fd4613b64d4344a1032797db15880bfd3a587f0e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8341a558ef5dc3f97a7302b285feb5b79a60a6c0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    meta\u003d$(curl -s -L \"https://pypi.python.org/pypi/$name/json\")"},{"line_number":109,"context_line":"    # Check for missing data."},{"line_number":110,"context_line":"    if [[ -z $meta ]]; then"},{"line_number":111,"context_line":"        echo \"WARNING: Failed to get json metadata for package $name\""},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":"    classifiers\u003d$(echo $meta | grep \u0027\"classifiers\"\u0027)"},{"line_number":114,"context_line":"    # Check for incomplete data."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_7a6749ec","line":111,"updated":"2019-04-01 17:34:11.000000000","message":"Actually because of how this is called with $() this echo won\u0027t show up anyway, and worse it could result in the code calling this method below to think that it got the correct classifier, so what do we do? Change to die so the script just pukes if we don\u0027t get a result? Or maybe add a retry loop?","commit_id":"fd4613b64d4344a1032797db15880bfd3a587f0e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7592e21cac573d615284f74e3ba00629baff0bf1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    if [[ -z $classifiers ]]; then"},{"line_number":116,"context_line":"        echo \"WARNING: Failed to get classifiers metadata for package $name\""},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"    classifier\u003d$(echo $classifiers | grep \u0027\"Programming Language :: Python :: 3\"\u0027)"},{"line_number":119,"context_line":"    set -e"},{"line_number":120,"context_line":"    echo $classifier"},{"line_number":121,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_14093e94","line":118,"updated":"2019-04-01 16:30:54.000000000","message":"While we\u0027re at it, shouldn\u0027t this also be a local variable?","commit_id":"fd4613b64d4344a1032797db15880bfd3a587f0e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d48621874ab8ada35172dfcc1484e173dd7e04f5","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    if [[ -z $classifiers ]]; then"},{"line_number":116,"context_line":"        echo \"WARNING: Failed to get classifiers metadata for package $name\""},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"    classifier\u003d$(echo $classifiers | grep \u0027\"Programming Language :: Python :: 3\"\u0027)"},{"line_number":119,"context_line":"    set -e"},{"line_number":120,"context_line":"    echo $classifier"},{"line_number":121,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_142e1efa","line":118,"in_reply_to":"5fc1f717_14093e94","updated":"2019-04-01 16:32:47.000000000","message":"I thought about that but figured it\u0027s already here so I might get flak for an unrelated change.","commit_id":"fd4613b64d4344a1032797db15880bfd3a587f0e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2aa85e2ac876a1027927f10486a7276184709ab3","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                echo \"Check python version for : $package_dir\""},{"line_number":283,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":284,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":285,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":286,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":287,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":288,"context_line":"                    cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":289,"context_line":"                elif [[ -d \"$package_dir\" ]]; then"},{"line_number":290,"context_line":"                    python_versions\u003d$(get_python_versions_for_package $package_dir)"},{"line_number":291,"context_line":"                    if [[ $python_versions \u003d~ $PYTHON3_VERSION ]]; then"},{"line_number":292,"context_line":"                        echo \"Automatically using $PYTHON3_VERSION version to install $package_dir based on classifiers\""},{"line_number":293,"context_line":"                        sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":294,"context_line":"                        cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":295,"context_line":"                    else"},{"line_number":296,"context_line":"                        # The package may not have yet advertised python3.5"},{"line_number":297,"context_line":"                        # support so check for just python3 classifier and log"},{"line_number":298,"context_line":"                        # a warning."},{"line_number":299,"context_line":"                        python3_classifier\u003d$(check_python3_support_for_package_local $package_dir)"},{"line_number":300,"context_line":"                        if [[ ! -z \"$python3_classifier\" ]]; then"},{"line_number":301,"context_line":"                            echo \"Automatically using $PYTHON3_VERSION version to install $package_dir based on local package settings\""},{"line_number":302,"context_line":"                            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":303,"context_line":"                            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":304,"context_line":"                        else"},{"line_number":305,"context_line":"                            echo \"WARNING: Did not find python 3 classifier for local package $package_dir\""},{"line_number":306,"context_line":"                        fi"},{"line_number":307,"context_line":"                    fi"},{"line_number":308,"context_line":"                else"},{"line_number":309,"context_line":"                    # Check pypi as we don\u0027t have the package on disk"},{"line_number":310,"context_line":"                    package\u003d$(echo $package_dir | grep -o \u0027^[.a-zA-Z0-9_-]*\u0027)"},{"line_number":311,"context_line":"                    python3_classifier\u003d$(check_python3_support_for_package_remote $package)"},{"line_number":312,"context_line":"                    if [[ ! -z \"$python3_classifier\" ]]; then"},{"line_number":313,"context_line":"                        echo \"Automatically using $PYTHON3_VERSION version to install $package based on remote package settings\""},{"line_number":314,"context_line":"                        sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":315,"context_line":"                        cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":316,"context_line":"                    else"},{"line_number":317,"context_line":"                        echo \"WARNING: Did not find python 3 classifier for remote package $package\""},{"line_number":318,"context_line":"                    fi"},{"line_number":319,"context_line":"                fi"},{"line_number":320,"context_line":"            fi"},{"line_number":321,"context_line":"        fi"},{"line_number":322,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_548ca67e","line":319,"range":{"start_line":285,"start_character":16,"end_line":319,"end_character":18},"updated":"2019-04-01 16:13:04.000000000","message":"clarkb suggested that we just do away with all of this classifier checking stuff and assume if we\u0027re running with py3 we should be able to install everything with py3 unless it\u0027s explicitly blacklisted which is what python3_disabled_for is for.","commit_id":"fd4613b64d4344a1032797db15880bfd3a587f0e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7592e21cac573d615284f74e3ba00629baff0bf1","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                echo \"Check python version for : $package_dir\""},{"line_number":283,"context_line":"                if python3_disabled_for ${package_dir##*/}; then"},{"line_number":284,"context_line":"                    echo \"Explicitly using $PYTHON2_VERSION version to install $package_dir based on DISABLED_PYTHON3_PACKAGES\""},{"line_number":285,"context_line":"                elif python3_enabled_for ${package_dir##*/}; then"},{"line_number":286,"context_line":"                    echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":287,"context_line":"                    sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":288,"context_line":"                    cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":289,"context_line":"                elif [[ -d \"$package_dir\" ]]; then"},{"line_number":290,"context_line":"                    python_versions\u003d$(get_python_versions_for_package $package_dir)"},{"line_number":291,"context_line":"                    if [[ $python_versions \u003d~ $PYTHON3_VERSION ]]; then"},{"line_number":292,"context_line":"                        echo \"Automatically using $PYTHON3_VERSION version to install $package_dir based on classifiers\""},{"line_number":293,"context_line":"                        sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":294,"context_line":"                        cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":295,"context_line":"                    else"},{"line_number":296,"context_line":"                        # The package may not have yet advertised python3.5"},{"line_number":297,"context_line":"                        # support so check for just python3 classifier and log"},{"line_number":298,"context_line":"                        # a warning."},{"line_number":299,"context_line":"                        python3_classifier\u003d$(check_python3_support_for_package_local $package_dir)"},{"line_number":300,"context_line":"                        if [[ ! -z \"$python3_classifier\" ]]; then"},{"line_number":301,"context_line":"                            echo \"Automatically using $PYTHON3_VERSION version to install $package_dir based on local package settings\""},{"line_number":302,"context_line":"                            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":303,"context_line":"                            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":304,"context_line":"                        else"},{"line_number":305,"context_line":"                            echo \"WARNING: Did not find python 3 classifier for local package $package_dir\""},{"line_number":306,"context_line":"                        fi"},{"line_number":307,"context_line":"                    fi"},{"line_number":308,"context_line":"                else"},{"line_number":309,"context_line":"                    # Check pypi as we don\u0027t have the package on disk"},{"line_number":310,"context_line":"                    package\u003d$(echo $package_dir | grep -o \u0027^[.a-zA-Z0-9_-]*\u0027)"},{"line_number":311,"context_line":"                    python3_classifier\u003d$(check_python3_support_for_package_remote $package)"},{"line_number":312,"context_line":"                    if [[ ! -z \"$python3_classifier\" ]]; then"},{"line_number":313,"context_line":"                        echo \"Automatically using $PYTHON3_VERSION version to install $package based on remote package settings\""},{"line_number":314,"context_line":"                        sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":315,"context_line":"                        cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":316,"context_line":"                    else"},{"line_number":317,"context_line":"                        echo \"WARNING: Did not find python 3 classifier for remote package $package\""},{"line_number":318,"context_line":"                    fi"},{"line_number":319,"context_line":"                fi"},{"line_number":320,"context_line":"            fi"},{"line_number":321,"context_line":"        fi"},{"line_number":322,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_948f6e2d","line":319,"range":{"start_line":285,"start_character":16,"end_line":319,"end_character":18},"in_reply_to":"5fc1f717_548ca67e","updated":"2019-04-01 16:30:54.000000000","message":"Yeah, that\u0027s another good idea.","commit_id":"fd4613b64d4344a1032797db15880bfd3a587f0e"}]}