)]}'
{"stackrc":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e89a52b754069033556f12961b51a41f1b9f1ceb","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Create a virtualenv with this"},{"line_number":156,"context_line":"if [[ ${USE_PYTHON3} \u003d\u003d True ]]; then"},{"line_number":157,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv -p python3\""},{"line_number":158,"context_line":"else"},{"line_number":159,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv \""},{"line_number":160,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5fc1f717_f9000705","line":157,"updated":"2019-04-03 06:14:41.000000000","message":"hrm; is this generically applicable?  on infra nodes we have installed /usr/local/bin/virtualenv but on raw python3 only images like bionic even with python3-virtualenv you don\u0027t have a \"virtualenv\" binary installed -- basically this requires dragging in python2.  i think this (-m venv) is actually the most python3 compatible way to do it?","commit_id":"e7464530487fae9ccd90b73081ef5020fdfb0a73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0b1f177402a60500ded84f1e67da4f00a903eeeb","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Create a virtualenv with this"},{"line_number":156,"context_line":"if [[ ${USE_PYTHON3} \u003d\u003d True ]]; then"},{"line_number":157,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv -p python3\""},{"line_number":158,"context_line":"else"},{"line_number":159,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv \""},{"line_number":160,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5fc1f717_3fd42fbb","line":157,"in_reply_to":"5fc1f717_f9000705","updated":"2019-04-03 08:16:16.000000000","message":"It did work in local testing on my bionic cloud image. I can do some further tests, but the issue is that if we cannot use virtualenv, we need to create a tedious workaround for https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1822842 , see the earlier patchsets and the failures for the py3 jobs there.\n\nThe issue in this special case is that the old command installs the pip version from the distro package python-pip-whl into the venv  which has the broken behavior regarding the extra-index-url. Using virtualenv instead uses the pip version that devstack has installed earlier via get_pip.","commit_id":"e7464530487fae9ccd90b73081ef5020fdfb0a73"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e259fe1c209618f41328ea6f25cba73fc74ab4a9","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Create a virtualenv with this"},{"line_number":156,"context_line":"if [[ ${USE_PYTHON3} \u003d\u003d True ]]; then"},{"line_number":157,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv -p python3\""},{"line_number":158,"context_line":"else"},{"line_number":159,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv \""},{"line_number":160,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_cd4e3d38","line":157,"updated":"2019-11-19 16:54:08.000000000","message":"Not entirely sure this is necessary, though it\u0027s also not that harmful. Didn\u0027t this work as it was?","commit_id":"5ab57c6532ce7af91b79b849be24169386cb8b11"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"89ef12376ae20ce4da20000248cb454636974892","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Create a virtualenv with this"},{"line_number":156,"context_line":"if [[ ${USE_PYTHON3} \u003d\u003d True ]]; then"},{"line_number":157,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv -p python3\""},{"line_number":158,"context_line":"else"},{"line_number":159,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv \""},{"line_number":160,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_b546a3a6","line":157,"in_reply_to":"3fa7e38b_b5af83de","updated":"2019-11-19 20:03:37.000000000","message":"Hrm, I\u0027m a bit confused on this one ...\n\nfor ... reasons i guess ... Ubuntu has split out \"venv\" into it\u0027s own python3-venv package.  but i\u0027m 99% sure it\u0027s part of the base python install on centos8\n\nvenv is the \"pythonic\" way to get a virtualenv, but then virtualenv is the 3rd-party way (and in it\u0027s docs throws some shade on venv saying it doesn\u0027t support everything virutalenv does).  in short, i\u0027m never sure which one to use ...","commit_id":"5ab57c6532ce7af91b79b849be24169386cb8b11"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8812202d5d82c425a0bb9707df716745155ed771","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# Create a virtualenv with this"},{"line_number":156,"context_line":"if [[ ${USE_PYTHON3} \u003d\u003d True ]]; then"},{"line_number":157,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv -p python3\""},{"line_number":158,"context_line":"else"},{"line_number":159,"context_line":"    export VIRTUALENV_CMD\u003d\"virtualenv \""},{"line_number":160,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_b5af83de","line":157,"in_reply_to":"3fa7e38b_cd4e3d38","updated":"2019-11-19 19:25:12.000000000","message":"I don\u0027t remember why I changed this originally, but at least the old version doesn\u0027t work on centos8 as I re-discovered this morning.","commit_id":"5ab57c6532ce7af91b79b849be24169386cb8b11"}]}