)]}'
{"lib/nova":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"095a58d67305fd2f5361dca0aa935d51a61ad77b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# The total number of cells we expect. Must be greater than one and doesn\u0027t"},{"line_number":65,"context_line":"# count cell0."},{"line_number":66,"context_line":"NOVA_NUM_CELLS\u003d${NOVA_NUM_CELLS:-2}"},{"line_number":67,"context_line":"# Our cell index, so we know what rabbit vhost to connect to."},{"line_number":68,"context_line":"# This should be in the range of 1-$NOVA_NUM_CELLS"},{"line_number":69,"context_line":"NOVA_CPU_CELL\u003d${NOVA_CPU_CELL:-1}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_e82ef38a","line":66,"updated":"2019-04-02 22:59:41.000000000","message":"This is temporary just to test that this works. Will remove if CI passes.","commit_id":"3bbd4fcea802b87d4450b01a727b563799815e35"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"42bf20c85659612e7727504ce6605918f23cad00","unresolved":false,"context_lines":[{"line_number":607,"context_line":"    else"},{"line_number":608,"context_line":"        for i in $(seq 1 $NOVA_NUM_CELLS); do"},{"line_number":609,"context_line":"            local conf\u003d$(conductor_conf $i)"},{"line_number":610,"context_line":"            local offset\u003d$(($i-1))"},{"line_number":611,"context_line":"            configure_console_proxies $conf $offset"},{"line_number":612,"context_line":"        done"},{"line_number":613,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_e8d35300","line":610,"updated":"2019-04-02 23:39:05.000000000","message":"Looks like these local declarations need to be on separate lines:\n\n local conf\n local offset\n conf\u003d$(conductor_conf $i)\n offset\u003d$(($i-1))\n\nto avoid:\n\n E042: local declaration hides errors","commit_id":"3bbd4fcea802b87d4450b01a727b563799815e35"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7db10913ab0d0f35833faefc7a8e8c07e8deaa6e","unresolved":false,"context_lines":[{"line_number":678,"context_line":"function configure_console_proxies {"},{"line_number":679,"context_line":"    # Use the provided config file path or default to $NOVA_CONF."},{"line_number":680,"context_line":"    local conf\u003d${1:-$NOVA_CONF}"},{"line_number":681,"context_line":"    local offset\u003d${2:-0}"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    if is_service_enabled n-novnc || is_service_enabled n-xvnc || [ \"$NOVA_VNC_ENABLED\" !\u003d False ]; then"},{"line_number":684,"context_line":"        iniset $conf vnc novncproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5fc1f717_cb8f7173","line":681,"range":{"start_line":681,"start_character":10,"end_line":681,"end_character":24},"updated":"2019-04-03 00:29:11.000000000","message":"Derp, offset needs to be staggered: (cell number - 1) * (num_proxies (4)), otherwise the different proxies (novnc, xvpvnc, spice, serial) run over each other if they were all enabled.\n\nhttp://logs.openstack.org/73/649473/1/check/tempest-full-py3/81489c8/controller/logs/devstacklog.txt.gz#_2019-04-02_23_11_08_943","commit_id":"3bbd4fcea802b87d4450b01a727b563799815e35"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7bf8baa38aa64fab0a478c07b54dc4d888d29ca8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# The total number of cells we expect. Must be greater than one and doesn\u0027t"},{"line_number":65,"context_line":"# count cell0."},{"line_number":66,"context_line":"NOVA_NUM_CELLS\u003d${NOVA_NUM_CELLS:-2}"},{"line_number":67,"context_line":"# Our cell index, so we know what rabbit vhost to connect to."},{"line_number":68,"context_line":"# This should be in the range of 1-$NOVA_NUM_CELLS"},{"line_number":69,"context_line":"NOVA_CPU_CELL\u003d${NOVA_CPU_CELL:-1}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5fc1f717_eb482db4","line":66,"updated":"2019-04-03 01:20:17.000000000","message":"Leaving this for now to help with verifying this works as expected.","commit_id":"cedc4deac6d63131200265f414db31fa354eea3f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"126c00f588b7a76829c28a6a0e174e272946da47","unresolved":false,"context_lines":[{"line_number":681,"context_line":"    # Use the provided config file path or default to $NOVA_CONF."},{"line_number":682,"context_line":"    local conf\u003d${1:-$NOVA_CONF}"},{"line_number":683,"context_line":"    local offset\u003d${2:-0}"},{"line_number":684,"context_line":"    # Stagger the offset based on the total number of possible console proxies"},{"line_number":685,"context_line":"    # (novnc, xvpvnc, spice, serial) so that their ports will not collide if"},{"line_number":686,"context_line":"    # all are enabled."},{"line_number":687,"context_line":"    offset\u003d$((offset * 4))"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    if is_service_enabled n-novnc || is_service_enabled n-xvnc || [ \"$NOVA_VNC_ENABLED\" !\u003d False ]; then"},{"line_number":690,"context_line":"        iniset $conf vnc novncproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ffb9cba7_31e40be0","line":687,"range":{"start_line":684,"start_character":4,"end_line":687,"end_character":26},"updated":"2019-04-30 17:07:32.000000000","message":"Nice, I was just thinking we could hit this below if we had multiple consoles enabled with multiple cells.","commit_id":"d5a68a6b7039a66455d7e320379a6b0b3879891c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"126c00f588b7a76829c28a6a0e174e272946da47","unresolved":false,"context_lines":[{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    if is_service_enabled n-novnc || is_service_enabled n-xvnc || [ \"$NOVA_VNC_ENABLED\" !\u003d False ]; then"},{"line_number":690,"context_line":"        iniset $conf vnc novncproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":691,"context_line":"        iniset $conf vnc novncproxy_port $((6080 + offset))"},{"line_number":692,"context_line":"        iniset $conf vnc xvpvncproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":693,"context_line":"        iniset $conf vnc xvpvncproxy_port $((6081 + offset))"},{"line_number":694,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ffb9cba7_91be17b2","line":691,"range":{"start_line":691,"start_character":44,"end_line":691,"end_character":48},"updated":"2019-04-30 17:07:32.000000000","message":"ack this is the default https://docs.openstack.org/nova/latest/configuration/config.html#vnc.novncproxy_port","commit_id":"d5a68a6b7039a66455d7e320379a6b0b3879891c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"126c00f588b7a76829c28a6a0e174e272946da47","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        iniset $conf vnc novncproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":691,"context_line":"        iniset $conf vnc novncproxy_port $((6080 + offset))"},{"line_number":692,"context_line":"        iniset $conf vnc xvpvncproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":693,"context_line":"        iniset $conf vnc xvpvncproxy_port $((6081 + offset))"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        if is_nova_console_proxy_compute_tls_enabled ; then"},{"line_number":696,"context_line":"            iniset $conf vnc auth_schemes \"vencrypt\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ffb9cba7_51b41fd1","line":693,"range":{"start_line":693,"start_character":45,"end_line":693,"end_character":49},"updated":"2019-04-30 17:07:32.000000000","message":"ack https://docs.openstack.org/nova/latest/configuration/config.html#vnc.xvpvncproxy_port","commit_id":"d5a68a6b7039a66455d7e320379a6b0b3879891c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"126c00f588b7a76829c28a6a0e174e272946da47","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    if is_service_enabled n-spice; then"},{"line_number":724,"context_line":"        iniset $conf spice html5proxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":725,"context_line":"        iniset $conf spice html5proxy_port $((6082 + offset))"},{"line_number":726,"context_line":"    fi"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    if is_service_enabled n-sproxy; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ffb9cba7_b1c23b33","line":725,"range":{"start_line":725,"start_character":46,"end_line":725,"end_character":50},"updated":"2019-04-30 17:07:32.000000000","message":"https://docs.openstack.org/nova/latest/configuration/config.html#spice.html5proxy_port","commit_id":"d5a68a6b7039a66455d7e320379a6b0b3879891c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"126c00f588b7a76829c28a6a0e174e272946da47","unresolved":false,"context_lines":[{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    if is_service_enabled n-sproxy; then"},{"line_number":729,"context_line":"        iniset $conf serial_console serialproxy_host \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":730,"context_line":"        iniset $conf serial_console serialproxy_port $((6083 + offset))"},{"line_number":731,"context_line":"    fi"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ffb9cba7_d1bfafa7","line":730,"range":{"start_line":730,"start_character":36,"end_line":730,"end_character":52},"updated":"2019-04-30 17:07:32.000000000","message":"ack https://docs.openstack.org/nova/latest/configuration/config.html#serial_console.serialproxy_port","commit_id":"d5a68a6b7039a66455d7e320379a6b0b3879891c"}]}