)]}'
{"HACKING.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a800a5304b80176f73eade607faf815657a0f6f4","unresolved":false,"context_lines":[{"line_number":145,"context_line":"* Global configuration that may be referenced in ``local.conf``, i.e. ``DEST``, ``DATA_DIR``"},{"line_number":146,"context_line":"* Global service configuration like ``ENABLED_SERVICES``"},{"line_number":147,"context_line":"* Variables used by multiple services that do not have a clear owner, i.e."},{"line_number":148,"context_line":"  ``VOLUME_BACKING_FILE_SIZE`` (nova-compute, nova-volumes and cinder) or"},{"line_number":149,"context_line":"  ``PUBLIC_NETWORK_NAME`` (nova-network and neutron)"},{"line_number":150,"context_line":"* Variables that can not be cleanly declared in a project file due to"},{"line_number":151,"context_line":"  dependency ordering, i.e. the order of sourcing the project files can"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bfb3d3c7_ac716046","side":"PARENT","line":148,"range":{"start_line":148,"start_character":46,"end_line":148,"end_character":58},"updated":"2019-06-04 23:25:59.000000000","message":"nice catch","commit_id":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"}],"functions":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8d1b733da3b2d9d2495f1db193c8c9ef4e0d42e","unresolved":false,"context_lines":[{"line_number":483,"context_line":"    # if we don\u0027t specify a from_net we\u0027re expecting things to work"},{"line_number":484,"context_line":"    # fine from our local box."},{"line_number":485,"context_line":"    if [[ -n \"$from_net\" ]]; then"},{"line_number":486,"context_line":"        # TODO(stephenfin): Is there anyway neutron could be disabled now?"},{"line_number":487,"context_line":"        if is_service_enabled neutron; then"},{"line_number":488,"context_line":"            ping_cmd\u003d\"$TOP_DIR/tools/ping_neutron.sh $from_net\""},{"line_number":489,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bfb3d3c7_0b656fe1","line":486,"range":{"start_line":486,"start_character":37,"end_line":486,"end_character":43},"updated":"2019-05-22 09:56:12.000000000","message":"any way\n\nThis should be addressed before this review is closed out (or immediately after, at least)","commit_id":"5cd2ce4e20cc4601ae29ee3871ab041ff8dca9f6"}],"lib/nova_plugins/hypervisor-xenserver":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8d1b733da3b2d9d2495f1db193c8c9ef4e0d42e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfb3d3c7_8bcabf17","updated":"2019-05-22 09:56:12.000000000","message":"I have no idea if this still works now, but that\u0027s an investigation for someone else","commit_id":"5cd2ce4e20cc4601ae29ee3871ab041ff8dca9f6"}],"lib/tempest":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8d1b733da3b2d9d2495f1db193c8c9ef4e0d42e","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    iniset $TEMPEST_CONFIG compute flavor_ref $flavor_ref"},{"line_number":343,"context_line":"    iniset $TEMPEST_CONFIG compute flavor_ref_alt $flavor_ref_alt"},{"line_number":344,"context_line":"    iniset $TEMPEST_CONFIG validation connect_method $ssh_connect_method"},{"line_number":345,"context_line":"    if ! is_service_enabled neutron; then"},{"line_number":346,"context_line":"        iniset $TEMPEST_CONFIG compute fixed_network_name $PRIVATE_NETWORK_NAME"},{"line_number":347,"context_line":"    fi"},{"line_number":348,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bfb3d3c7_2bd153ce","line":345,"updated":"2019-05-22 09:56:12.000000000","message":"As before, is this even possible?","commit_id":"5cd2ce4e20cc4601ae29ee3871ab041ff8dca9f6"}],"stack.sh":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f7890c09b4c227e59f3c1cbb906b544810d6dcff","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"# Nova"},{"line_number":1171,"context_line":"# ----"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"if is_service_enabled n-net q-dhcp; then"},{"line_number":1174,"context_line":"    # Delete traces of nova networks from prior runs"},{"line_number":1175,"context_line":"    # Do not kill any dnsmasq instance spawned by NetworkManager"},{"line_number":1176,"context_line":"    netman_pid\u003d$(pidof NetworkManager || true)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bfb3d3c7_7dbce6db","side":"PARENT","line":1173,"range":{"start_line":1173,"start_character":28,"end_line":1173,"end_character":34},"updated":"2019-05-22 15:55:58.000000000","message":"I wonder if you need to keep some of this code block because of q-dhcp and the handling of dnsmasq etc? That is, are any parts of this applicable with neutron q-dhcp?","commit_id":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"730c9b2a2a7ef9cefaa2c2019367eff3997cdf44","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"# Nova"},{"line_number":1171,"context_line":"# ----"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"if is_service_enabled n-net q-dhcp; then"},{"line_number":1174,"context_line":"    # Delete traces of nova networks from prior runs"},{"line_number":1175,"context_line":"    # Do not kill any dnsmasq instance spawned by NetworkManager"},{"line_number":1176,"context_line":"    netman_pid\u003d$(pidof NetworkManager || true)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bfb3d3c7_bdc57e3e","side":"PARENT","line":1173,"range":{"start_line":1173,"start_character":28,"end_line":1173,"end_character":34},"in_reply_to":"bfb3d3c7_7dbce6db","updated":"2019-05-22 15:58:15.000000000","message":"Oh, I was reading this as an AND condition. If that\u0027s not true then yeah, we might need to keep some of this. I\u0027ll let someone else comment here too","commit_id":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63cc7e2d15329bb025713c1194c1d6cb2dbcfc72","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"# Nova"},{"line_number":1171,"context_line":"# ----"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"if is_service_enabled n-net q-dhcp; then"},{"line_number":1174,"context_line":"    # Delete traces of nova networks from prior runs"},{"line_number":1175,"context_line":"    # Do not kill any dnsmasq instance spawned by NetworkManager"},{"line_number":1176,"context_line":"    netman_pid\u003d$(pidof NetworkManager || true)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bfb3d3c7_2810d54d","side":"PARENT","line":1173,"range":{"start_line":1173,"start_character":28,"end_line":1173,"end_character":34},"in_reply_to":"bfb3d3c7_bd21fefd","updated":"2019-05-31 14:10:30.000000000","message":"Done","commit_id":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6f20c70cf48a42e8b4801105a2238d32c8fdf90b","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"# Nova"},{"line_number":1171,"context_line":"# ----"},{"line_number":1172,"context_line":""},{"line_number":1173,"context_line":"if is_service_enabled n-net q-dhcp; then"},{"line_number":1174,"context_line":"    # Delete traces of nova networks from prior runs"},{"line_number":1175,"context_line":"    # Do not kill any dnsmasq instance spawned by NetworkManager"},{"line_number":1176,"context_line":"    netman_pid\u003d$(pidof NetworkManager || true)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bfb3d3c7_bd21fefd","side":"PARENT","line":1173,"range":{"start_line":1173,"start_character":28,"end_line":1173,"end_character":34},"in_reply_to":"bfb3d3c7_bdc57e3e","updated":"2019-05-22 16:01:49.000000000","message":"Yeah, the list for service_enabled is an OR:\n\nhttps://github.com/openstack/devstack/blob/984c3ae33b6a55f04a2d64ea9ffbe47e37e89953/functions-common#L1919","commit_id":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8d1b733da3b2d9d2495f1db193c8c9ef4e0d42e","unresolved":false,"context_lines":[{"line_number":1202,"context_line":""},{"line_number":1203,"context_line":"    # Additional Nova configuration that is dependent on other services"},{"line_number":1204,"context_line":"    # TODO(stephenfin): Is it possible for neutron to *not* be enabled now? If"},{"line_number":1205,"context_line":"    # not, remove the if here"},{"line_number":1206,"context_line":"    if is_service_enabled neutron; then"},{"line_number":1207,"context_line":"        configure_neutron_nova"},{"line_number":1208,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bfb3d3c7_eb881bc7","line":1205,"updated":"2019-05-22 09:56:12.000000000","message":"Again, we might want to clarify this before or just after merge","commit_id":"5cd2ce4e20cc4601ae29ee3871ab041ff8dca9f6"}]}