)]}'
{"lib/nova":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7e7152ddb7d0a1491bb5fdc68936054375371680","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        # Stagger the offset based on the total number of possible console"},{"line_number":580,"context_line":"        # proxies (novnc, xvpvnc, spice, serial) so that their ports will not"},{"line_number":581,"context_line":"        # collide if all are enabled."},{"line_number":582,"context_line":"        offset\u003d$(((NOVA_CPU_CELL - 1) * 4))"},{"line_number":583,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":584,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":585,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:$((6080 + offset))/vnc_auto.html\"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_d2b0ed45","line":582,"updated":"2019-06-28 07:17:15.000000000","message":"offset is used below outside of this if block, can we move this outside so that if it being set independently of whether n-cpu is enabled?\n\nAlso might be safer to make it a local variable.","commit_id":"2aee1b25bd6e57675d1bbc8d69bfe45dbb454dee"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"992fefd0fa35726493dd408d6b083a413eb64328","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        # Stagger the offset based on the total number of possible console"},{"line_number":580,"context_line":"        # proxies (novnc, xvpvnc, spice, serial) so that their ports will not"},{"line_number":581,"context_line":"        # collide if all are enabled."},{"line_number":582,"context_line":"        offset\u003d$(((NOVA_CPU_CELL - 1) * 4))"},{"line_number":583,"context_line":"        if [ \"$NOVNC_FROM_PACKAGE\" \u003d\u003d \"True\" ]; then"},{"line_number":584,"context_line":"            # Use the old URL when installing novnc packages."},{"line_number":585,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:$((6080 + offset))/vnc_auto.html\"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_39e1edfd","line":582,"in_reply_to":"9fb8cfa7_d2b0ed45","updated":"2019-07-03 09:45:56.000000000","message":"Done","commit_id":"2aee1b25bd6e57675d1bbc8d69bfe45dbb454dee"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ab00147570afbd4c9ad2e12f3263b9db07bb99ce","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            NOVNCPROXY_URL\u003d${NOVNCPROXY_URL:-\"http://$SERVICE_HOST:$((6080 + offset))/vnc_lite.html\"}"},{"line_number":592,"context_line":"        fi"},{"line_number":593,"context_line":"        iniset $NOVA_CPU_CONF vnc novncproxy_base_url \"$NOVNCPROXY_URL\""},{"line_number":594,"context_line":"        XVPVNCPROXY_URL\u003d${XVPVNCPROXY_URL:-\"http://$SERVICE_HOST:$((6081 + offset))/console\"}"},{"line_number":595,"context_line":"        iniset $NOVA_CPU_CONF vnc xvpvncproxy_base_url \"$XVPVNCPROXY_URL\""},{"line_number":596,"context_line":"        SPICEHTML5PROXY_URL\u003d${SPICEHTML5PROXY_URL:-\"http://$SERVICE_HOST:$((6082 + offset))/spice_auto.html\"}"},{"line_number":597,"context_line":"        iniset $NOVA_CPU_CONF spice html5proxy_base_url \"$SPICEHTML5PROXY_URL\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_5290b84a","line":594,"range":{"start_line":594,"start_character":71,"end_line":594,"end_character":72},"updated":"2019-06-25 15:55:33.000000000","message":"I missed that these were also offset first go round","commit_id":"2aee1b25bd6e57675d1bbc8d69bfe45dbb454dee"}]}