)]}'
{"id":"openstack%2Fdevstack~662063","triplet_id":"openstack%2Fdevstack~master~I98b86b0338e859f0a6728200b91dd6295625c08e","project":"openstack/devstack","branch":"master","topic":"bug/1830002","hashtags":[],"change_id":"I98b86b0338e859f0a6728200b91dd6295625c08e","subject":"Create Keystone internal endpoint","status":"ABANDONED","created":"2019-05-29 18:43:20.000000000","updated":"2019-05-29 19:31:10.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2f0b0266eb7ae8b440984b27590f3bb41e1188bf","_number":662063,"virtual_id_number":662063,"owner":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2019-05-29 19:30:47.000000000","_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"all":[{"value":-1,"date":"2019-05-29 18:50:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"date":"2019-05-29 18:45:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-29 18:45:11.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-05-29 18:50:46.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"}],"messages":[{"id":"38e18c055f82a6bd986dfbd9437c916bb3badf88","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-05-29 18:43:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c4118b45baac870fa12ad4cf653451a24b440a97","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-05-29 18:44:33.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2d320012636b04b7ebdbfa6a313081ff560e1592","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2019-05-29 18:50:46.000000000","message":"Patch Set 2: Code-Review-1\n\nDevstack isn\u0027t supposed to be production-ready, it\u0027s supposed to be minimal. Currently all of the endpoints for all services except keystone are \u0027public\u0027. I\u0027d prefer to keep keystone similarly simple by only requiring \u0027public\u0027.\n\nWhat do you think of frickler\u0027s suggestion that we add the config option to keystone first with a default of \u0027admin\u0027, then switch devstack to set it to \u0027public\u0027, then change the default in keystone? http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2019-05-29.log.html#t2019-05-29T15:15:43","accounts_in_message":[],"_revision_number":2},{"id":"f4ff79625522a3c19ad0c44376a8febf511eba92","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-05-29 19:30:47.000000000","message":"Patch Set 2:\n\n\u003e Devstack isn\u0027t supposed to be production-ready, it\u0027s supposed to be\n \u003e minimal. Currently all of the endpoints for all services except\n \u003e keystone are \u0027public\u0027. I\u0027d prefer to keep keystone similarly simple\n \u003e by only requiring \u0027public\u0027.\n \u003e \n \u003e What do you think of frickler\u0027s suggestion that we add the config\n \u003e option to keystone first with a default of \u0027admin\u0027, then switch\n \u003e devstack to set it to \u0027public\u0027, then change the default in\n \u003e keystone? http://eavesdrop.openstack.org/irclogs/%23openstack-keystone/%23openstack-keystone.2019-05-29.log.html#t2019-05-29T15:15:43\n\nYes, that\u0027s a good idea. Let me abandon this patch then.","accounts_in_message":[],"_revision_number":2},{"id":"756db59f374e569929690646e670d6ddd8699a59","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-05-29 19:31:10.000000000","message":"Abandoned\n\nNot needed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc894e93b7aea0238794ef979a39a21a4c8ae394","revisions":{"4463a349b71f6f7045c2514deefafdb6c55e48ec":{"kind":"REWORK","_number":1,"created":"2019-05-29 18:43:20.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/63/662063/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/63/662063/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/63/662063/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/63/662063/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/63/662063/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/63/662063/1"}}},"commit":{"parents":[{"commit":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953","subject":"Merge \"Safety check for python version in get_pip_command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-05-29 18:28:52.000000000","tz":-420},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-05-29 18:43:19.000000000","tz":-420},"subject":"Create Keystone internal endpoint","message":"Create Keystone internal endpoint\n\nNeed to create the Keystone internal endpoint to facilitate the\ndeprecation of the admin endpoint and the transition to the\ninternal endpoint. With the removal of Keystone v2 APIs, the admin\nendpoint is subsequently deprecated because there\u0027s no longer a\ndistinction between admin and internal endpoints.\n\nNotice that on a typical production environment, the controllers\nare running on an internal management network, which is segmented\noff from the public network per standard security practice.\nTherefore, admin endpoint is really functional equivalent to the\ninternal endpoint, as opposed to the public endpoint.\n\nChange-Id: I98b86b0338e859f0a6728200b91dd6295625c08e\nCloses-Bug: 1830002\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4463a349b71f6f7045c2514deefafdb6c55e48ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/4463a349b71f6f7045c2514deefafdb6c55e48ec"}]},"branch":"refs/heads/master"},"bc894e93b7aea0238794ef979a39a21a4c8ae394":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-05-29 18:44:33.000000000","uploader":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"ref":"refs/changes/63/662063/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/63/662063/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/63/662063/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/63/662063/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/63/662063/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/63/662063/2"}}},"commit":{"parents":[{"commit":"984c3ae33b6a55f04a2d64ea9ffbe47e37e89953","subject":"Merge \"Safety check for python version in get_pip_command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/984c3ae33b6a55f04a2d64ea9ffbe47e37e89953"}]}],"author":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-05-29 18:28:52.000000000","tz":-420},"committer":{"name":"Guang Yee","email":"guang.yee@suse.com","date":"2019-05-29 18:43:39.000000000","tz":-420},"subject":"Create Keystone internal endpoint","message":"Create Keystone internal endpoint\n\nNeed to create the Keystone internal endpoint to facilitate the\ndeprecation of the admin endpoint and the transition to the\ninternal endpoint. With the removal of Keystone v2 APIs, the admin\nendpoint is subsequently deprecated because there\u0027s no longer a\ndistinction between admin and internal endpoints.\n\nNotice that on a typical production environment, the controllers\nare running on an internal management network, which is segmented\noff from the public network per standard security practice.\nTherefore, admin endpoint is really functional equivalent to the\ninternal endpoint, as opposed to the public endpoint.\n\nTODO: we will need to remove the admin endpoint creation once\nthe transition is completed.\n\nChange-Id: I98b86b0338e859f0a6728200b91dd6295625c08e\nCloses-Bug: 1830002\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bc894e93b7aea0238794ef979a39a21a4c8ae394"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bc894e93b7aea0238794ef979a39a21a4c8ae394"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}