)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6c24fc37dab217c7b7b44aaba484e821eca39617","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Turek \u003cmjturek@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-06-06 13:57:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip creating tempest networks if TEMPEST_CREATE_INITIAL_NETWORKS is false"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some cases, for example in the case of a flat provider network,  you want to"},{"line_number":10,"context_line":"have lib/neutron handle all network setup. This patch adds a switch to allow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_4e3b679b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":74},"updated":"2019-06-06 15:32:22.000000000","message":"this is already skipped by NEUTRON_CREATE_INITIAL_NETWORKS ? is this proposal to rename the var ?","commit_id":"17c0be0f95cd27f4970b286304a1961f8c5d2e5b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4509dc90d6a8d0c20093d2396741e752abf42d3f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Turek \u003cmjturek@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-02 14:08:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Skip creating tempest networks if TEMPEST_CREATE_INITIAL_NETWORKS is false"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some cases, for example in the case of a flat provider network,  you want to"},{"line_number":10,"context_line":"have lib/neutron handle all network setup. This patch adds a switch to allow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_6481ff4d","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":30},"updated":"2019-10-17 23:27:35.000000000","message":"this is not to create the networks actually, it is only used to skip to set the public_network_id which is used for external connectivity in tests.\n\nshared network creation is added in this same condition just to make sure that tempest works fine if there is a shared network exist in env.","commit_id":"81a323a6a19e7778ac89740770136e7c410f24c4"}],"lib/tempest":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4509dc90d6a8d0c20093d2396741e752abf42d3f","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    # the public network (for floating ip access) is only available"},{"line_number":254,"context_line":"    # if the extension is enabled."},{"line_number":255,"context_line":"    # If NEUTRON_CREATE_INITIAL_NETWORKS is not true, there is no network created"},{"line_number":256,"context_line":"    # and the public_network_id should not be set."},{"line_number":257,"context_line":"    if [[ \"$TEMPEST_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]] \u0026\u0026 is_networking_extension_supported \u0027external-net\u0027; then"},{"line_number":258,"context_line":"        public_network_id\u003d$(openstack network show -f value -c id $PUBLIC_NETWORK_NAME)"},{"line_number":259,"context_line":"        # make sure shared network presence does not confuses the tempest tests"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_84ebdb10","line":256,"range":{"start_line":255,"start_character":0,"end_line":256,"end_character":50},"updated":"2019-10-17 23:27:35.000000000","message":"this change basically will handle below two use case-\n\n1. NEUTRON_CREATE_INITIAL_NETWORKS is true when neutron create initial network but you want to skip setting the public_network_id\n- Not sure why we need to skip public_network_id and so does tempest tests external connectivity checks also.\n\n2. NEUTRON_CREATE_INITIAL_NETWORKS is false where there is no network created by neutron but we do have neutron\u0027s public network available in env ? \n- This seems valid case.\n\nlet me know if my understanding is correct?","commit_id":"81a323a6a19e7778ac89740770136e7c410f24c4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5ca7146ec18bab2dee21e86e28e02191687eb7cf","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    # the public network (for floating ip access) is only available"},{"line_number":254,"context_line":"    # if the extension is enabled."},{"line_number":255,"context_line":"    # If NEUTRON_CREATE_INITIAL_NETWORKS is not true, there is no network created"},{"line_number":256,"context_line":"    # and the public_network_id should not be set."},{"line_number":257,"context_line":"    if [[ \"$TEMPEST_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]] \u0026\u0026 is_networking_extension_supported \u0027external-net\u0027; then"},{"line_number":258,"context_line":"        public_network_id\u003d$(openstack network show -f value -c id $PUBLIC_NETWORK_NAME)"},{"line_number":259,"context_line":"        # make sure shared network presence does not confuses the tempest tests"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff570b3c_33c74615","line":256,"range":{"start_line":255,"start_character":0,"end_line":256,"end_character":50},"in_reply_to":"3fa7e38b_20f8f379","updated":"2020-05-28 13:16:38.000000000","message":"I guess it occurred to me, some operators don\u0027t actually to have \"public networks\", and to force a hard constraint on them is actually making openstack harder to use. Harder to fit into a production environment.","commit_id":"81a323a6a19e7778ac89740770136e7c410f24c4"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"cbedc7ed4955a354ce2410efd11d0ef6bcc99199","unresolved":false,"context_lines":[{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    # the public network (for floating ip access) is only available"},{"line_number":254,"context_line":"    # if the extension is enabled."},{"line_number":255,"context_line":"    # If NEUTRON_CREATE_INITIAL_NETWORKS is not true, there is no network created"},{"line_number":256,"context_line":"    # and the public_network_id should not be set."},{"line_number":257,"context_line":"    if [[ \"$TEMPEST_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]] \u0026\u0026 is_networking_extension_supported \u0027external-net\u0027; then"},{"line_number":258,"context_line":"        public_network_id\u003d$(openstack network show -f value -c id $PUBLIC_NETWORK_NAME)"},{"line_number":259,"context_line":"        # make sure shared network presence does not confuses the tempest tests"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_20f8f379","line":256,"range":{"start_line":255,"start_character":0,"end_line":256,"end_character":50},"in_reply_to":"3fa7e38b_84ebdb10","updated":"2019-12-12 18:23:03.000000000","message":"So I guess the case that makes sense is that some test scenarios and environments may have certian constraints, like in reality may be pure private IaaS configurations where there is no real \"public\" network?","commit_id":"81a323a6a19e7778ac89740770136e7c410f24c4"}]}