)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7e33804a6a2c19d5a7c74dcfd2a954310608c7dc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova change https://review.opendev.org/603079/ is changing the"},{"line_number":10,"context_line":"default configuration to send only unversioned notfications rather"},{"line_number":11,"context_line":"than both versioned and unversioned notifications. This could break"},{"line_number":12,"context_line":"unsuspecting downstream projects (like Watcher) whose CI jobs are"},{"line_number":13,"context_line":"not explicitly configuring nova for the types of notifications"},{"line_number":14,"context_line":"they need but are just relying on getting both."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_26f3fca0","line":12,"range":{"start_line":11,"start_character":62,"end_line":12,"end_character":32},"updated":"2019-06-03 22:35:17.000000000","message":"Wouldn\u0027t it be better to let those projects decide for themselves whether they should fix this for themselves, and at what level?\n\nI would be afraid that, by overriding this \"default\" in devstack, we\u0027d be masking some behavior that will break downstream *outside* of the CI, which would be worse. Rather catch it early.","commit_id":"5e55d8ce86cb5ce6c15dbb35bca747bcdf5a2583"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca8b06dc6bb20bb37d573109b9946db93bb2778e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova change https://review.opendev.org/603079/ is changing the"},{"line_number":10,"context_line":"default configuration to send only unversioned notfications rather"},{"line_number":11,"context_line":"than both versioned and unversioned notifications. This could break"},{"line_number":12,"context_line":"unsuspecting downstream projects (like Watcher) whose CI jobs are"},{"line_number":13,"context_line":"not explicitly configuring nova for the types of notifications"},{"line_number":14,"context_line":"they need but are just relying on getting both."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_1e77f9d6","line":12,"range":{"start_line":11,"start_character":62,"end_line":12,"end_character":32},"in_reply_to":"9fb8cfa7_26f3fca0","updated":"2019-06-05 13:16:45.000000000","message":"I thought about that, and it\u0027s probably best long-term but I was trying to make a quick fix so all downstream projects that need versioned don\u0027t start breaking without any awareness of the default changing (nothing was mentioned in the ML, at least recently).","commit_id":"5e55d8ce86cb5ce6c15dbb35bca747bcdf5a2583"}],"lib/nova":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e3cc58626eb33b56b77315b959d0c068a0f15f0c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"ISCSID_DEBUG_LEVEL\u003d${ISCSID_DEBUG_LEVEL:-4}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Format for notifications. Nova defaults to \"unversioned\" since Train."},{"line_number":191,"context_line":"# Other options include \"versioned\" and \"both\"."},{"line_number":192,"context_line":"NOVA_NOTIFICATION_FORMAT\u003d${NOVA_NOTIFICATION_FORMAT:-unversioned}"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Functions"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_c6582a32","line":191,"updated":"2019-06-13 14:16:39.000000000","message":"Nit: s/include/are/ as that seems to be the complete list of possible options. But fine to change that next time this is touched.","commit_id":"b57757ae14a54e78ebd533198564d24af77c51da"}]}