)]}'
{"lib/tempest":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"eb9582c37f2d5abc975541082a8bd85602d925af","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",\" + ADDITIONAL_NETWORK_API_EXTENSIONS"},{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled api_extensions $network_api_extensions"},{"line_number":626,"context_line":"    # Swift API Extensions"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_1e50425e","line":623,"updated":"2019-06-21 03:36:26.000000000","message":"I think this wants to be ${ADDITIONAL_NETWORK_API_EXTENSIONS}?\n\n+2 with that","commit_id":"8b6af2387e27a5d9bdad237102e51337a364cb8e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5db99d5280bd6c650f543c64df6d16256b87c43d","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",\" + ADDITIONAL_NETWORK_API_EXTENSIONS"},{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled api_extensions $network_api_extensions"},{"line_number":626,"context_line":"    # Swift API Extensions"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_2ef07367","line":623,"in_reply_to":"9fb8cfa7_1e50425e","updated":"2019-06-21 11:14:05.000000000","message":"ahh yea. done","commit_id":"8b6af2387e27a5d9bdad237102e51337a364cb8e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ca1eafa89add2e1179775a0386d4c36a73040a94","unresolved":false,"context_lines":[{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",\" + ADDITIONAL_NETWORK_API_EXTENSIONS"},{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled api_extensions $network_api_extensions"},{"line_number":626,"context_line":"    # Swift API Extensions"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9fb8cfa7_6f83ca57","line":623,"in_reply_to":"9fb8cfa7_1e50425e","updated":"2019-06-21 08:09:50.000000000","message":"good catch, this is why I hate jumping between python and bash reviews....","commit_id":"8b6af2387e27a5d9bdad237102e51337a364cb8e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e4c9c7a4e65c5b80171043ed709ff0369a1d378f","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        # Remove disabled extensions"},{"line_number":619,"context_line":"        network_api_extensions\u003d$(remove_disabled_extensions $network_api_extensions $DISABLE_NETWORK_API_EXTENSIONS)"},{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",$ADDITIONAL_NETWORK_API_EXTENSIONS\""},{"line_number":624,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_a5ba3e07","line":621,"updated":"2019-06-21 15:59:23.000000000","message":"Hmm, this still looks too pythonistic to me.\n\nwhy not just drop this line, leaving the var empty by default, and ...","commit_id":"fe9e0f6e39aa31e90eb98ab80ecde34d57198884"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"342ffa5817b64c94247160244844b92f3bbda852","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        # Remove disabled extensions"},{"line_number":619,"context_line":"        network_api_extensions\u003d$(remove_disabled_extensions $network_api_extensions $DISABLE_NETWORK_API_EXTENSIONS)"},{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",$ADDITIONAL_NETWORK_API_EXTENSIONS\""},{"line_number":624,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_80c92879","line":621,"in_reply_to":"9fb8cfa7_a5ba3e07","updated":"2019-06-21 17:03:35.000000000","message":"Done","commit_id":"fe9e0f6e39aa31e90eb98ab80ecde34d57198884"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e4c9c7a4e65c5b80171043ed709ff0369a1d378f","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        network_api_extensions\u003d$(remove_disabled_extensions $network_api_extensions $DISABLE_NETWORK_API_EXTENSIONS)"},{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",$ADDITIONAL_NETWORK_API_EXTENSIONS\""},{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled api_extensions $network_api_extensions"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_0541ca0b","line":622,"updated":"2019-06-21 15:59:23.000000000","message":"change the first condition here to a simpler\n\n[[ -n \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" ]]","commit_id":"fe9e0f6e39aa31e90eb98ab80ecde34d57198884"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"342ffa5817b64c94247160244844b92f3bbda852","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        network_api_extensions\u003d$(remove_disabled_extensions $network_api_extensions $DISABLE_NETWORK_API_EXTENSIONS)"},{"line_number":620,"context_line":"    fi"},{"line_number":621,"context_line":"    ADDITIONAL_NETWORK_API_EXTENSIONS\u003d${ADDITIONAL_NETWORK_API_EXTENSIONS:-None}"},{"line_number":622,"context_line":"    if [[ \"$ADDITIONAL_NETWORK_API_EXTENSIONS\" !\u003d \"None\" ]] \u0026\u0026 [[ \"$network_api_extensions\" !\u003d \"all\" ]]; then"},{"line_number":623,"context_line":"        network_api_extensions+\u003d\",$ADDITIONAL_NETWORK_API_EXTENSIONS\""},{"line_number":624,"context_line":"    fi"},{"line_number":625,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled api_extensions $network_api_extensions"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_a0c46c60","line":622,"in_reply_to":"9fb8cfa7_0541ca0b","updated":"2019-06-21 17:03:35.000000000","message":"Done","commit_id":"fe9e0f6e39aa31e90eb98ab80ecde34d57198884"}]}