)]}'
{"lib/tls":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ffffbeb877dfe1b1f29f955dc523907c624ac216","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"},{"line_number":235,"context_line":"                TLS_IP\u003d\"DNS:$TLS_IP,IP:$TLS_IP\""},{"line_number":236,"context_line":"            fi"},{"line_number":237,"context_line":"            if [[ \"$IP_VERSION\" \u003d\u003d \"6\" ]]; then"},{"line_number":238,"context_line":"                TLS_IP\u003d\"$TLS_IP,IP:$HOST_IPV6\""},{"line_number":239,"context_line":"            fi"},{"line_number":240,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_55c32139","line":237,"updated":"2019-08-09 17:01:53.000000000","message":"You should check if IP_VERSION is 4+6 too. Or as an alternative maybe always add IP:$HOST_IPV6 as long as that var is set.","commit_id":"e64b8adfac7b17b0aa401ac2bd8954d8c5f7bef3"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3f3b1cecd6e1c300da03e84da2be15390274f84b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                # see https://bugs.python.org/issue23239"},{"line_number":235,"context_line":"                TLS_IP\u003d\"DNS:$TLS_IP,IP:$TLS_IP\""},{"line_number":236,"context_line":"            fi"},{"line_number":237,"context_line":"            if [[ \"$IP_VERSION\" \u003d\u003d \"6\" ]]; then"},{"line_number":238,"context_line":"                TLS_IP\u003d\"$TLS_IP,IP:$HOST_IPV6\""},{"line_number":239,"context_line":"            fi"},{"line_number":240,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_13938102","line":237,"in_reply_to":"7faddb67_55c32139","updated":"2019-08-09 19:11:39.000000000","message":"That is news to me that it can be configured as 4+6... ugh.","commit_id":"e64b8adfac7b17b0aa401ac2bd8954d8c5f7bef3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"415b17b95eb8fd85559bc9c1c2067bdcc685114a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                TLS_IP\u003d\"DNS:$TLS_IP,IP:$TLS_IP\""},{"line_number":236,"context_line":"            fi"},{"line_number":237,"context_line":"            if [[ -n \"$HOST_IPV6\" ]]; then"},{"line_number":238,"context_line":"                TLS_IP\u003d\"$TLS_IP,IP:$HOST_IPV6\""},{"line_number":239,"context_line":"            fi"},{"line_number":240,"context_line":"        fi"},{"line_number":241,"context_line":"        make_cert $INT_CA_DIR $DEVSTACK_CERT_NAME $DEVSTACK_HOSTNAME \"$TLS_IP\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_1b5e1376","line":238,"range":{"start_line":238,"start_character":25,"end_line":238,"end_character":31},"updated":"2019-08-13 10:02:24.000000000","message":"this is set as SERVICE_HOST which will be HOST_IPV6 when SERVICE_IP_VERSION is configured as 6. stacrc adjust the SERVICE_HOST HOST_IP or HOST_IPV6 based on SERVICE_IP_VERSION.\n\nSERVICE_IP_VERSION is var to tell devstack to deploy services over IPv6 or IPv4. So setting SERVICE_IP_VERSION to 6 should do tls on HOST_IPv6 automatically Or you want to test the tls with ipv6 even other services are deployed on Ipv4 by devstack? if so then this lgtm.","commit_id":"0fe25e31a8ff40d76279e55c731fd31a93f0d21c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"db8fd9f940efe577c41bc335ae531bb698e032f6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                TLS_IP\u003d\"DNS:$TLS_IP,IP:$TLS_IP\""},{"line_number":236,"context_line":"            fi"},{"line_number":237,"context_line":"            if [[ -n \"$HOST_IPV6\" ]]; then"},{"line_number":238,"context_line":"                TLS_IP\u003d\"$TLS_IP,IP:$HOST_IPV6\""},{"line_number":239,"context_line":"            fi"},{"line_number":240,"context_line":"        fi"},{"line_number":241,"context_line":"        make_cert $INT_CA_DIR $DEVSTACK_CERT_NAME $DEVSTACK_HOSTNAME \"$TLS_IP\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_e1d6e453","line":238,"range":{"start_line":238,"start_character":25,"end_line":238,"end_character":31},"in_reply_to":"7faddb67_1b5e1376","updated":"2019-08-13 11:41:33.000000000","message":"When I started down the path of ensuring that an IP was populated, it ended up being when I was setting IP_VERSION to 6, although I\u0027ve since learned there is apparently a 6+4 option to that as well. I may have found SERVICE_IP_VERSION, but regardless I always seemed to find myself with mixed stacks so maybe I was just doing it wrong, but what I was ultimately trying to do was run ipv6 with ironic and we were hitting the lack of validation on one of the socket connections where the endpoint in keystone was registered as the v4 address, but the socket was bound to a v6 socket on ::.","commit_id":"0fe25e31a8ff40d76279e55c731fd31a93f0d21c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"77dff2ce190bf5b7b39c0cff795388e04e9a66fb","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                TLS_IP\u003d\"DNS:$TLS_IP,IP:$TLS_IP\""},{"line_number":236,"context_line":"            fi"},{"line_number":237,"context_line":"            if [[ -n \"$HOST_IPV6\" ]]; then"},{"line_number":238,"context_line":"                TLS_IP\u003d\"$TLS_IP,IP:$HOST_IPV6\""},{"line_number":239,"context_line":"            fi"},{"line_number":240,"context_line":"        fi"},{"line_number":241,"context_line":"        make_cert $INT_CA_DIR $DEVSTACK_CERT_NAME $DEVSTACK_HOSTNAME \"$TLS_IP\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_fd15169c","line":238,"range":{"start_line":238,"start_character":25,"end_line":238,"end_character":31},"in_reply_to":"7faddb67_e1d6e453","updated":"2019-08-14 11:14:42.000000000","message":"Thanks for the clarification. \n\nHOST_IPV6 will be set automatically always (irrespective of SERVICE_IP_VERISION or IP_VERSION ) as long as there is ipv6 nic on the system [1]. I am not sure if any issue on adding ipv6 also always but we can at least check on some tls-proxy enabled job (nova-next is one i know).\n\nDo you want to add ipv6 address in TLS_IP always or only when devstack is asked to configure for IPv6? \nSERVICE_IP_VERISION does not support dual-stack as of now. it can be either deploy the services on ipv4 or ipv6. \n\n[1] https://github.com/openstack/devstack/blob/1f6bea1768c2066f3dd5604aee569ad633f45fbc/stackrc#L862","commit_id":"0fe25e31a8ff40d76279e55c731fd31a93f0d21c"}]}